Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7C11C4741F for ; Thu, 5 Nov 2020 16:20:18 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7FDB420786 for ; Thu, 5 Nov 2020 16:20:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="uIVhbP7K"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=kernel-dk.20150623.gappssmtp.com header.i=@kernel-dk.20150623.gappssmtp.com header.b="DNZLkMoV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7FDB420786 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe :List-Id:In-Reply-To:MIME-Version:Date:Message-ID:References:To:From:Subject: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=M/R+PUKEl/V1yckcVZVuwNjB9ZjkE0UizHRUxsFWBTg=; b=uIVhbP7KY4PZsUaRRjZxGOXvOG SVjYor3hoqTcyTrGFQTylg8ORK76oTgNMC2W5X0ta4v6Rg2lRuu3IASTFLKZPR8tFapRAKgKgNGoU zE2Zx+SLJrC8TLVFlQMtAJdKVeVc5yl/Uf6U3ic0LtIeiqTS1d/ltU8ihJ5uVatxdAaaE9yJlYFzP TF/mlTort1HjIpFvxCn3Yf9oYkzIFdC0/r7lNufqtwj1NdWyPFWlnQfdE42r45QK5Afq2Aoea2uC1 jj8SwqO35+n7ZonV9pZSNwUF8XMRg5Pyu67Fmx1l6vilZp45uZ2X2AXZEEDa/nwYYA54w8Wma+PMt X5LwfKoQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kahzO-0004Bp-EQ; Thu, 05 Nov 2020 16:19:54 +0000 Received: from mail-io1-xd43.google.com ([2607:f8b0:4864:20::d43]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kahzM-0004BG-7b for linux-arm-kernel@lists.infradead.org; Thu, 05 Nov 2020 16:19:53 +0000 Received: by mail-io1-xd43.google.com with SMTP id u19so2374002ion.3 for ; Thu, 05 Nov 2020 08:19:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:from:to:references:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=KHSw8BCaBneL7yefJvCH31K8rDF8VGfJY5ZNIV4l/RM=; b=DNZLkMoVJF5/DCoZ/3n3FUwUMny5nkCM0sc1QO2+oIDf+hPO2rz17RKlouGFFBI579 urxkDFSvDHNmTO467ck62ipT6c463yEwFACsZK2+NPWFjMzoNP3swtHpBPPsNYzTe05Y YrALy9mUSQruZPpLWSmNejeFI7o4+5OpkoouKZNJJ4NTMBKjtzHnBkLigSky11pqLqLg rb+aGloCp+gOpZz4u6vf3THbOf5gzX1VwdntSXtxK+54oRauoZZGR13KM7KZad1HphYb +7ZwL4vkWRA2cxIO8+oNl0p+4Rn4VvMMCi2+hOD4AstB2glbRR74j5W6t07PtVfV3emU hbsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=KHSw8BCaBneL7yefJvCH31K8rDF8VGfJY5ZNIV4l/RM=; b=C5RlTnW/60k6Srpg+dYn3dPLfefUosmhdilgJzGirSDjFmxST0Z8CGWTQF6H9JOWBn +aGWc8Dk1J7GBalebl9P+dk+ThgaKRjwZoUk8tIKH/uCNIOvF1fr860N593BZbkL5JnS dJaPF22jX9G7uS3eChBjx36EGIIsFPd9eCpqoy47S3LyPEz2mc1H+in8FvClB5TIFZVt BFDhQvGW7QqyE8Ofzfp5UaBnXJ6ExfV2P7RxSRSHytfImyIn2nCrfZ/vuIsiNsGYFOST aoxliCWs2nPiBgc3pNQ1E8LC0BAK2GH4lDTa8MRGvSSp3T2BIPNZN0p01R/go0Ty+iM1 giRQ== X-Gm-Message-State: AOAM530u0CO293GREGBc9/2ZQXoV63HaxbpYc7aETly+Y6FWjatVYoju TjqC2zfKl31fsQmA2k52+b3lyQ8Tu6H6dQ== X-Google-Smtp-Source: ABdhPJycfWenQzHaYEzx25u7oXT8pesnWSKRbSCGw2I0q51UK2UvK7sEJAyLpGiuv3SE3/Pw3UjpOw== X-Received: by 2002:a5e:950a:: with SMTP id r10mr2317636ioj.34.1604593189917; Thu, 05 Nov 2020 08:19:49 -0800 (PST) Received: from [192.168.1.30] ([65.144.74.34]) by smtp.gmail.com with ESMTPSA id o124sm1451680ila.62.2020.11.05.08.19.49 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Nov 2020 08:19:49 -0800 (PST) Subject: Re: [PATCH] arm64: add support for TIF_NOTIFY_SIGNAL From: Jens Axboe To: "linux-arm-kernel@lists.infradead.org" References: <111f501e-33e7-ad38-6476-9874f1226ad7@kernel.dk> Message-ID: <335c437e-d504-635a-ffc3-c6fc75215f8f@kernel.dk> Date: Thu, 5 Nov 2020 09:19:49 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <111f501e-33e7-ad38-6476-9874f1226ad7@kernel.dk> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201105_111952_619369_F6BAB0BB X-CRM114-Status: GOOD ( 24.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Gentle nudge on this one. On 10/29/20 10:11 AM, Jens Axboe wrote: > Cc: linux-arm-kernel@lists.infradead.org > Signed-off-by: Jens Axboe > --- > > 5.11 has support queued up for TIF_NOTIFY_SIGNAL, see this posting > for details: > > https://lore.kernel.org/io-uring/20201026203230.386348-1-axboe@kernel.dk/ > > As part of that work, I'm adding TIF_NOTIFY_SIGNAL support to all archs, > as that will enable a set of cleanups once all of them support it. I'm > happy carrying this patch if need be, or it can be funelled through the > arch tree. Let me know. > > arch/arm64/include/asm/thread_info.h | 5 ++++- > arch/arm64/kernel/signal.c | 2 +- > 2 files changed, 5 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/include/asm/thread_info.h b/arch/arm64/include/asm/thread_info.h > index 1fbab854a51b..cdcf307764aa 100644 > --- a/arch/arm64/include/asm/thread_info.h > +++ b/arch/arm64/include/asm/thread_info.h > @@ -68,6 +68,7 @@ void arch_release_task_struct(struct task_struct *tsk); > #define TIF_UPROBE 4 /* uprobe breakpoint or singlestep */ > #define TIF_FSCHECK 5 /* Check FS is USER_DS on return */ > #define TIF_MTE_ASYNC_FAULT 6 /* MTE Asynchronous Tag Check Fault */ > +#define TIF_NOTIFY_SIGNAL 7 /* signal notifications exist */ > #define TIF_SYSCALL_TRACE 8 /* syscall trace active */ > #define TIF_SYSCALL_AUDIT 9 /* syscall auditing */ > #define TIF_SYSCALL_TRACEPOINT 10 /* syscall tracepoint for ftrace */ > @@ -98,10 +99,12 @@ void arch_release_task_struct(struct task_struct *tsk); > #define _TIF_32BIT (1 << TIF_32BIT) > #define _TIF_SVE (1 << TIF_SVE) > #define _TIF_MTE_ASYNC_FAULT (1 << TIF_MTE_ASYNC_FAULT) > +#define _TIF_NOTIFY_SIGNAL (1 << TIF_NOTIFY_SIGNAL) > > #define _TIF_WORK_MASK (_TIF_NEED_RESCHED | _TIF_SIGPENDING | \ > _TIF_NOTIFY_RESUME | _TIF_FOREIGN_FPSTATE | \ > - _TIF_UPROBE | _TIF_FSCHECK | _TIF_MTE_ASYNC_FAULT) > + _TIF_UPROBE | _TIF_FSCHECK | _TIF_MTE_ASYNC_FAULT | \ > + _TIF_NOTIFY_SIGNAL) > > #define _TIF_SYSCALL_WORK (_TIF_SYSCALL_TRACE | _TIF_SYSCALL_AUDIT | \ > _TIF_SYSCALL_TRACEPOINT | _TIF_SECCOMP | \ > diff --git a/arch/arm64/kernel/signal.c b/arch/arm64/kernel/signal.c > index a8184cad8890..bec6ef69704f 100644 > --- a/arch/arm64/kernel/signal.c > +++ b/arch/arm64/kernel/signal.c > @@ -942,7 +942,7 @@ asmlinkage void do_notify_resume(struct pt_regs *regs, > (void __user *)NULL, current); > } > > - if (thread_flags & _TIF_SIGPENDING) > + if (thread_flags & (_TIF_SIGPENDING | _TIF_NOTIFY_SIGNAL)) > do_signal(regs); > > if (thread_flags & _TIF_NOTIFY_RESUME) { > -- Jens Axboe _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel