From: Maarten Lankhorst Subject: Re: [v2 2/2] drm/i915/icl: Enable Plane Input CSC for YUV to RGB Conversion Date: Thu, 25 Oct 2018 11:47:06 +0200 Message-ID: <3379e956-0ef4-c353-ea1f-84e19f88d370@linux.intel.com> References: <1540397893-3301-1-git-send-email-uma.shankar@intel.com> <1540397893-3301-3-git-send-email-uma.shankar@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 19A646E3BF for ; Thu, 25 Oct 2018 09:47:09 +0000 (UTC) In-Reply-To: <1540397893-3301-3-git-send-email-uma.shankar@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Uma Shankar , intel-gfx@lists.freedesktop.org Cc: ville.syrjala@intel.com, maarten.lankhorst@intel.com List-Id: intel-gfx@lists.freedesktop.org T3AgMjQtMTAtMTggb20gMTg6MTggc2NocmVlZiBVbWEgU2hhbmthcjoKPiBQbGFuZSBpbnB1dCBD U0MgbmVlZHMgdG8gYmUgZW5hYmxlZCB0byBjb252ZXJ0IGZyYW1idWZmZXJzIGZyb20KPiBZVVYg dG8gUkdCLiBUaGlzIGlzIG5lZWRlZCBmb3IgYm90dG9tIDMgcGxhbmVzIG9uIElDTCwgcmVzdCBv Zgo+IHRoZSBwbGFuZXMgaGF2ZSBoYXJkY29kZWQgY29udmVyc2lvbiBhbmQgdGFrZW4gY2FyZSBi eSB0aGUgbGVnYWN5Cj4gY29kZS4KPgo+IFRoaXMgcGF0Y2ggZGVmaW5lcyB0aGUgY28tZWZmaWNp ZW50IHZhbHVlcyBmb3IgWVVWIHRvIFJHQiBjb252ZXJzaW9uCj4gaW4gQlQ3MDkgYW5kIEJUNjAx IGZvcm1hdHMuIEl0IHByb2dyYW1zIHRoZSBjb2VmZmljaWVudHMgYW5kIGVuYWJsZXMKPiB0aGUg cGxhbmUgaW5wdXQgY3NjIHVuaXQgaW4gaGFyZHdhcmUuCj4KPiBOb3RlOiBUaGlzIGlzIGN1cnJl bnRseSB1bnRlc3RlZCBhbmQgZmxvYXRlZCB0byBnZXQgYW4gZWFybHkgZmVlZGJhY2sKPiBvbiB0 aGUgZGVzaWduIGFuZCBpbXBsZW1lbnRhdGlvbiBmb3IgdGhpcyBmZWF0dXJlLiBJbiBwYXJhbGxl bCwKPiBJIHdpbGwgdGVzdCB0aGlzIG9uIGFjdHVhbCBJQ0wgaGFyZHdhcmUgYW5kIGNvbmZpcm0g d2l0aCBwbGFuYXIKPiBmb3JtYXRzLgo+Cj4gdjI6IEFkZHJlc3NlZCBNYWFydGVuJ3MgYW5kIFZp bGxlJ3MgcmV2aWV3IGNvbW1lbnRzIGFuZCBhZGRlZCB0aGUKPiBjb2VmZmljaWVudHMgaW4gYSAy RCBhcnJheSBpbnN0ZWFkIG9mIGluZGVwZW5kZW50IE1hY3Jvcy4KPgo+IFNpZ25lZC1vZmYtYnk6 IFVtYSBTaGFua2FyIDx1bWEuc2hhbmthckBpbnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2NvbG9yLmMgICB8IDQ5ICsrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKwo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgfCAyNCAr KysrKysrKysrKysrLS0tLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmggICAg IHwgIDIgKysKPiAgMyBmaWxlcyBjaGFuZ2VkLCA2OSBpbnNlcnRpb25zKCspLCA2IGRlbGV0aW9u cygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2NvbG9yLmMg Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9jb2xvci5jCj4gaW5kZXggNTEyN2RhMi4uZGU3 MzNjZiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9jb2xvci5jCj4g KysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfY29sb3IuYwo+IEBAIC01Nyw2ICs1Nywx MSBAQAo+ICAjZGVmaW5lIENTQ19SR0JfVE9fWVVWX1JWX0dWIDB4YmNlODlhZDgKPiAgI2RlZmlu ZSBDU0NfUkdCX1RPX1lVVl9CViAweDFlMDgwMDAwCj4gIAo+ICsvKiBQcmVvZmZzZXQgdmFsdWVz IGZvciBZVVYgdG8gUkdCIENvbnZlcnNpb24gKi8KPiArI2RlZmluZSBQUkVPRkZfWVVWX1RPX1JH Ql9ISQkJMHg4MDAKPiArI2RlZmluZSBQUkVPRkZfWVVWX1RPX1JHQl9NRQkJMHhGMDAKPiArI2Rl ZmluZSBQUkVPRkZfWVVWX1RPX1JHQl9MTwkJMHg4MDAKPiArCj4gIC8qCj4gICAqIEV4dHJhY3Qg dGhlIENTQyBjb2VmZmljaWVudCBmcm9tIGEgQ1RNIGNvZWZmaWNpZW50IChpbiBVMzIuMzIgZml4 ZWQgcG9pbnQKPiAgICogZm9ybWF0KS4gVGhpcyBtYWNybyB0YWtlcyB0aGUgY29lZmZpY2llbnQg d2Ugd2FudCB0cmFuc2Zvcm1lZCBhbmQgdGhlCj4gQEAgLTY0Myw2ICs2NDgsNTAgQEAgaW50IGlu dGVsX2NvbG9yX2NoZWNrKHN0cnVjdCBkcm1fY3J0YyAqY3J0YywKPiAgCXJldHVybiAtRUlOVkFM Owo+ICB9Cj4gIAo+ICt2b2lkIGljbF9wcm9ncmFtX2lucHV0X2NzY19jb2VmZihjb25zdCBzdHJ1 Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZSwKPiArCQkJCSBjb25zdCBzdHJ1Y3QgaW50 ZWxfcGxhbmVfc3RhdGUgKnBsYW5lX3N0YXRlKQo+ICt7Cj4gKwlzdHJ1Y3QgZHJtX2k5MTVfcHJp dmF0ZSAqZGV2X3ByaXYgPQo+ICsJCXRvX2k5MTUocGxhbmVfc3RhdGUtPmJhc2UucGxhbmUtPmRl dik7Cj4gKwlzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YyA9IHRvX2ludGVsX2NydGMoY3J0Y19zdGF0 ZS0+YmFzZS5jcnRjKTsKPiArCWVudW0gcGlwZSBwaXBlID0gY3J0Yy0+cGlwZTsKPiArCXN0cnVj dCBpbnRlbF9wbGFuZSAqaW50ZWxfcGxhbmUgPQo+ICsJCXRvX2ludGVsX3BsYW5lKHBsYW5lX3N0 YXRlLT5iYXNlLnBsYW5lKTsKPiArCWVudW0gcGxhbmVfaWQgcGxhbmUgPSBpbnRlbF9wbGFuZS0+ aWQ7Cj4gKwo+ICsJc3RhdGljIGNvbnN0IHUzMiBpbnB1dF9jc2NfbWF0cml4W11bNl0gPSB7Cj4g KwkJLyogQlQuNjAxIGZ1bGwgcmFuZ2UgWUNiQ3IgLT4gZnVsbCByYW5nZSBSR0IgKi8KPiArCQlb RFJNX0NPTE9SX1lDQkNSX0JUNjAxXSA9IHsKPiArCQkJMHg3QUY4NzgwMCwgMHgwLCAweDhCMjg3 ODAwLAo+ICsJCQkweDlBQzAsIDB4NzgwMCwgMHg3REQ4LAo+ICsJCX0sCk1heWJlIGVhY2ggY29t cG9uZW50IHNlcGFyYXRlbHk/IHVpbnQxNiBbXVs5XQoKQWxzbyBCWS9CVS9CViBhcmUgcHJvZ3Jh bW1lZCBpbiBiaXRzIDMxLTE2IGFjY29yZGluZyB0byBic3BlYy4gOikKU2VlbXMgdGhhdCBidWcg d2FzIGFscmVhZHkgdGhlcmUgaW4gdGhlIG9yaWdpbmFsIHN1Ym1pc3Npb24/CgpPdGhlcndpc2Ug bG9va2luZyBtdWNoIGJldHRlciEKCkFuZCBvbmNlIG1vcmUsIEkgc3RpbGwgbWlzcyBhbnkgZm9y bSBvZiBsaW1pdGVkL2Z1bGwgcmFuZ2UgaGFuZGxpbmc/Cj4gKwkJLyogQlQuNzA5IGZ1bGwgcmFu Z2UgWUNiQ3IgLT4gZnVsbCByYW5nZSBSR0IgKi8KPiArCQlbRFJNX0NPTE9SX1lDQkNSX0JUNzA5 XSA9IHsKPiArCQkJMHg3Qzk4NzgwMCwgMHgwLCAweDlFRjg3ODAwLAo+ICsJCQkweEFCRjgsIDB4 NzgwMCwgIDB4N0VEOCwKPiArCQl9LAo+ICsJfTsKPiArCWNvbnN0IHUzMiAqY3NjID0gaW5wdXRf Y3NjX21hdHJpeFtwbGFuZV9zdGF0ZS0+YmFzZS5jb2xvcl9lbmNvZGluZ107Cj4gKwo+ICsJSTkx NV9XUklURShQTEFORV9JTlBVVF9DU0NfUllfR1kocGlwZSwgcGxhbmUpLCBjc2NbMF0pOwo+ICsJ STkxNV9XUklURShQTEFORV9JTlBVVF9DU0NfQlkocGlwZSwgcGxhbmUpLCBjc2NbMV0pOwo+ICsJ STkxNV9XUklURShQTEFORV9JTlBVVF9DU0NfUlVfR1UocGlwZSwgcGxhbmUpLCBjc2NbMl0pOwo+ ICsJSTkxNV9XUklURShQTEFORV9JTlBVVF9DU0NfQlUocGlwZSwgcGxhbmUpLCBjc2NbM10pOwo+ ICsJSTkxNV9XUklURShQTEFORV9JTlBVVF9DU0NfUlZfR1YocGlwZSwgcGxhbmUpLCBjc2NbNF0p Owo+ICsJSTkxNV9XUklURShQTEFORV9JTlBVVF9DU0NfQlYocGlwZSwgcGxhbmUpLCBjc2NbNV0p Owo+ICsKPiArCUk5MTVfV1JJVEUoUExBTkVfSU5QVVRfQ1NDX1BSRU9GRl9ISShwaXBlLCBwbGFu ZSksCj4gKwkJICAgUFJFT0ZGX1lVVl9UT19SR0JfSEkpOwo+ICsJSTkxNV9XUklURShQTEFORV9J TlBVVF9DU0NfUFJFT0ZGX01FKHBpcGUsIHBsYW5lKSwKPiArCQkgICBQUkVPRkZfWVVWX1RPX1JH Ql9NRSk7Cj4gKwlJOTE1X1dSSVRFKFBMQU5FX0lOUFVUX0NTQ19QUkVPRkZfTE8ocGlwZSwgcGxh bmUpLAo+ICsJCSAgIFBSRU9GRl9ZVVZfVE9fUkdCX0xPKTsKPiArCj4gKwlJOTE1X1dSSVRFKFBM QU5FX0lOUFVUX0NTQ19QT1NUT0ZGX0hJKHBpcGUsIHBsYW5lKSwgMHgwKTsKPiArCUk5MTVfV1JJ VEUoUExBTkVfSU5QVVRfQ1NDX1BPU1RPRkZfTUUocGlwZSwgcGxhbmUpLCAweDApOwo+ICsJSTkx NV9XUklURShQTEFORV9JTlBVVF9DU0NfUE9TVE9GRl9MTyhwaXBlLCBwbGFuZSksIDB4MCk7Cj4g K30KPiArCj4gIHZvaWQgaW50ZWxfY29sb3JfaW5pdChzdHJ1Y3QgZHJtX2NydGMgKmNydGMpCj4g IHsKPiAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoY3J0Yy0+ ZGV2KTsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5j IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gaW5kZXggZmUwNDVhYi4u YmU2NTQxOSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5 LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiBAQCAtMzY2 Niw2ICszNjY2LDggQEAgdTMyIGdsa19wbGFuZV9jb2xvcl9jdGwoY29uc3Qgc3RydWN0IGludGVs X2NydGNfc3RhdGUgKmNydGNfc3RhdGUsCj4gIAlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2 X3ByaXYgPQo+ICAJCXRvX2k5MTUocGxhbmVfc3RhdGUtPmJhc2UucGxhbmUtPmRldik7Cj4gIAlj b25zdCBzdHJ1Y3QgZHJtX2ZyYW1lYnVmZmVyICpmYiA9IHBsYW5lX3N0YXRlLT5iYXNlLmZiOwo+ ICsJc3RydWN0IGludGVsX3BsYW5lICpwbGFuZSA9IHRvX2ludGVsX3BsYW5lKHBsYW5lX3N0YXRl LT5iYXNlLnBsYW5lKTsKPiArCj4gIAl1MzIgcGxhbmVfY29sb3JfY3RsID0gMDsKPiAgCj4gIAlp ZiAoSU5URUxfR0VOKGRldl9wcml2KSA8IDExKSB7Cj4gQEAgLTM2NzYsMTMgKzM2NzgsMjMgQEAg dTMyIGdsa19wbGFuZV9jb2xvcl9jdGwoY29uc3Qgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNy dGNfc3RhdGUsCj4gIAlwbGFuZV9jb2xvcl9jdGwgfD0gZ2xrX3BsYW5lX2NvbG9yX2N0bF9hbHBo YShwbGFuZV9zdGF0ZSk7Cj4gIAo+ICAJaWYgKGZiLT5mb3JtYXQtPmlzX3l1dikgewo+ICsJCWlm ICghaWNsX2lzX2hkcl9wbGFuZShwbGFuZSkpIHsKPiArCQkJaWYgKHBsYW5lX3N0YXRlLT5iYXNl LmNvbG9yX2VuY29kaW5nID09Cj4gKwkJCQkJRFJNX0NPTE9SX1lDQkNSX0JUNzA5KQo+ICsJCQkJ cGxhbmVfY29sb3JfY3RsIHw9Cj4gKwkJCQkJUExBTkVfQ09MT1JfQ1NDX01PREVfWVVWNzA5X1RP X1JHQjcwOTsKPiArCQkJZWxzZQo+ICsJCQkJcGxhbmVfY29sb3JfY3RsIHw9Cj4gKwkJCQkJUExB TkVfQ09MT1JfQ1NDX01PREVfWVVWNjAxX1RPX1JHQjcwOTsKPiAgCj4gKwkJCWlmIChwbGFuZV9z dGF0ZS0+YmFzZS5jb2xvcl9yYW5nZSA9PQo+ICsJCQkJCURSTV9DT0xPUl9ZQ0JDUl9GVUxMX1JB TkdFKQo+ICsJCQkJcGxhbmVfY29sb3JfY3RsIHw9Cj4gKwkJCQlQTEFORV9DT0xPUl9ZVVZfUkFO R0VfQ09SUkVDVElPTl9ESVNBQkxFOwo+ICsJCX0gZWxzZSB7Cj4gKwkJCWljbF9wcm9ncmFtX2lu cHV0X2NzY19jb2VmZihjcnRjX3N0YXRlLCBwbGFuZV9zdGF0ZSk7Cj4gKwkJCXBsYW5lX2NvbG9y X2N0bCB8PSBQTEFORV9DT0xPUl9JTlBVVF9DU0NfRU5BQkxFOwo+ICsJCX0KPiAgCX0KPiAgCj4g IAlyZXR1cm4gcGxhbmVfY29sb3JfY3RsOwo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9kcnYuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oCj4gaW5k ZXggZGIyNDMwOC4uYmQ5ZTk0NiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9kcnYuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oCj4gQEAg LTIyODUsNiArMjI4NSw4IEBAIGludCBpbnRlbF9wbGFuZV9hdG9taWNfY2hlY2tfd2l0aF9zdGF0 ZShjb25zdCBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqb2xkX2NydGNfCj4gIGludCBpbnRlbF9j b2xvcl9jaGVjayhzdHJ1Y3QgZHJtX2NydGMgKmNydGMsIHN0cnVjdCBkcm1fY3J0Y19zdGF0ZSAq c3RhdGUpOwo+ICB2b2lkIGludGVsX2NvbG9yX3NldF9jc2Moc3RydWN0IGRybV9jcnRjX3N0YXRl ICpjcnRjX3N0YXRlKTsKPiAgdm9pZCBpbnRlbF9jb2xvcl9sb2FkX2x1dHMoc3RydWN0IGRybV9j cnRjX3N0YXRlICpjcnRjX3N0YXRlKTsKPiArdm9pZCBpY2xfcHJvZ3JhbV9pbnB1dF9jc2NfY29l ZmYoY29uc3Qgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGUsCj4gKwkJCQkgY29u c3Qgc3RydWN0IGludGVsX3BsYW5lX3N0YXRlICpwbGFuZV9zdGF0ZSk7Cj4gIAo+ICAvKiBpbnRl bF9sc3Bjb24uYyAqLwo+ICBib29sIGxzcGNvbl9pbml0KHN0cnVjdCBpbnRlbF9kaWdpdGFsX3Bv cnQgKmludGVsX2RpZ19wb3J0KTsKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9pbnRlbC1nZngK