Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AC193C04A95 for ; Thu, 29 Sep 2022 07:03:07 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C394B84C56; Thu, 29 Sep 2022 09:03:04 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="KyrdzC3R"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 26E2E84C4D; Thu, 29 Sep 2022 09:03:03 +0200 (CEST) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 4196384C4D for ; Thu, 29 Sep 2022 09:03:00 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=rogerq@kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4634B62051; Thu, 29 Sep 2022 07:02:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DFDC4C4347C; Thu, 29 Sep 2022 07:02:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664434977; bh=ec+M5RnnGO8cjkD20mXONitHVGrvoqFl59nkBvQw1AQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=KyrdzC3RjIfzZ5DioLYRlvUhdF026YaeCngLsho5rxvHuyIsV3+HQwx6VvoiDSCdv lCj1s1nlXcA6vfpkYqcWn9iIABdPHv6htiFO05fLXle0ij+Qx34ZLT38ng1lkguOjp TGMUJ4F4CvyzO9Y+BQMEbi+4TW6jPOoEsf2tZyA6Rxw52c5fsAMK0nC+4jWwvTf+to KrfuybI4tdnprRgcF1z1k0Qrw+8AF55Lqs+nWHlpIJTxCRCZkklBEjOkfUXJgwJc59 X8uV8F9/pg8jdqVa/GKv4pF2rsf6OTAW4TKTNQAjyF8A6sxc2Inld7oWQ/awzNQWQN gNBQmKmSvzSKg== Message-ID: <33934f40-f11a-9384-e6fe-968a5a48f0bb@kernel.org> Date: Thu, 29 Sep 2022 10:02:54 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [u-boot][PATCH 1/3] scripts: Makefile.spl: Enable memory drivers to be built for SPL Content-Language: en-US To: Simon Glass Cc: Tom Rini , U-Boot Mailing List References: <20220928121149.1724-1-rogerq@kernel.org> <20220928121149.1724-2-rogerq@kernel.org> From: Roger Quadros In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi Simon, On 28/09/2022 19:27, Simon Glass wrote: > Hi Roger, > > On Wed, 28 Sept 2022 at 06:12, Roger Quadros wrote: >> >> We will need ti-gpmc driver for SPL. Allow memory drivers >> do be built for SPL. >> >> Signed-off-by: Roger Quadros >> --- >> scripts/Makefile.spl | 1 + >> 1 file changed, 1 insertion(+) > > Please can you use the existing drivers/ram directory? The ti-gpmc driver is not actually a RAM only controller. Although it can support SRAM. It is a more general purpose controller that can support different peripherals. It is similar to the drivers already existing in the divers/memory directory. I was just trying to keep the file layout similar to that in the Linux kernel. Do you still see a problem with it? > >> >> diff --git a/scripts/Makefile.spl b/scripts/Makefile.spl >> index 3bafeb4fe9..110076b22f 100644 >> --- a/scripts/Makefile.spl >> +++ b/scripts/Makefile.spl >> @@ -114,6 +114,7 @@ libs-$(CONFIG_PARTITIONS) += disk/ >> endif >> >> libs-y += drivers/ >> +libs-y += drivers/memory/ >> libs-$(CONFIG_SPL_USB_GADGET) += drivers/usb/dwc3/ >> libs-$(CONFIG_SPL_USB_GADGET) += drivers/usb/cdns3/ >> libs-y += dts/ >> -- >> 2.17.1 >> > > Regards, > Simon cheers, -roger