From: Akio Takebe Subject: Re: [PATCH] Stop enforcing -g for some of the tools. Date: Wed, 01 Nov 2006 14:33:11 +0900 Message-ID: <33C6FD77388276takebe_akio@jp.fujitsu.com> References: <20061031152600.GA26330@totally.trollied.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20061031152600.GA26330@totally.trollied.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: John Levon , xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org Hi, John I have small questions. The following option is written in $(XEN_ROOT)/Config.mk. ===================== ifneq ($(debug),y) CFLAGS += -DNDEBUG else CFLAGS += -g endif ===================== So I think tools is compiled with -g by default if your patch is applied. Am I right? >diff --git a/tools/xenstore/Makefile b/tools/xenstore/Makefile >--- a/tools/xenstore/Makefile >+++ b/tools/xenstore/Makefile >@@ -6,7 +6,7 @@ MINOR = 0 > MINOR = 0 > > PROFILE=#-pg >-BASECFLAGS=-Wall -g -Werror >+BASECFLAGS=-Werror > # Make gcc generate dependencies. > BASECFLAGS += -Wp,-MD,.$(@F).d > PROG_DEP = .*.d Why do you remove -Wall? Best Regards, Akio Takebe