From: "MaxF (Code Review)" Date: Wed, 15 Apr 2026 16:39:29 +0000 In-Reply-To: References: Reply-To: max@...2606..., arne-openvpn@...1227..., davidben@...410..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <3403b3ac0c3f7122adce2cc066b87ae69fa81609-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="tzoxgiJsbXQ="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: ssl_openssl: Fix some CRL mixups List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: flichtenheld , davidben Cc: plaisthos , openvpn-devel --tzoxgiJsbXQ= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: davidben, flichtenheld. MaxF has posted comments on this change by davidben. ( http://gerrit.openvp= n.net/c/openvpn/+/1289?usp=3Demail ) Change subject: ssl_openssl: Fix some CRL mixups ...................................................................... Patch Set 12: (2 comments) Patchset: PS12: This makes sense to me, but I don't know these functions in-depth. Just one= question about how exactly X509_STORE_CTX_set0_crls() copies the CRLs. File src/openvpn/ssl_openssl.c: http://gerrit.openvpn.net/c/openvpn/+/1289/comment/c1a234c8_f81029f6?usp=3D= email : PS12, Line 321: X509_STORE_CTX_set0_crls(ctx, session->opt->ssl_ctx->cr= ls); Does this function copy the CRLs into ctx, or a pointer to them? If it's th= e latter, does this modified X509_STORE_CTX continue to exist inside the SS= L_CTX after this callback? (What I'm getting at is, do we need to worry ab= out dangling pointers if reload_crl is called?) -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1289?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I31ac2a763209114267c35c4a9182a12d8d82f6fe Gerrit-Change-Number: 1289 Gerrit-PatchSet: 12 Gerrit-Owner: davidben Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: MaxF Gerrit-CC: openvpn-devel Gerrit-Attention: flichtenheld Gerrit-Attention: davidben Gerrit-Comment-Date: Wed, 15 Apr 2026 16:39:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No --tzoxgiJsbXQ= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is cur= rently required from: davidben, flichtenheld.

View = Change

2 comments:

  • Patchset:

    • Patch Set #12:

      This makes se= nse to me, but I don't know these functions in-depth. Just one question= about how exactly X509_STORE_CTX_set0_crls() copies the CRLs.

    • File src/openvpn/ssl_openssl.= c:

      • Pat= ch Set #12, Line 321: = X509_STORE_CTX_set0_crls(ctx, session->opt->ssl_ctx->crls);

        Does this function copy the CRLs into ctx, or a pointer to them? If= it's the latter, does this modified X509_STORE_CTX continue to exist i= nside the SSL_CTX after this callback? (What I'm getting at is, do we = need to worry about dangling pointers if reload_crl is called?)

      To view, visit change 1289. To unsubscribe, or for help writing = mail filters, visit settings.

      =
      Gerrit-MessageType: comment
      Gerrit-Project: openvpn
      Gerrit-Branch: master
      Gerrit-Change-Id: I31ac2a763209114267c35c4a918= 2a12d8d82f6fe
      Gerrit-Change-Number: 1289
      Gerrit-PatchSet: 12
      Gerrit-Owner: davidben <davidben@...410...&= gt;
      Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
      Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
      Gerrit-CC: MaxF <max@...2606...>
      Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
      Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
      Gerrit-Attention: davidben <davidben@...2975...= ...>
      Gerrit-Comment-Date: Wed, 15 Apr 2026 16:39:29= +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      = --tzoxgiJsbXQ=--