From: Juergen Gross Subject: Re: [Qemu-devel] [PATCH] xen: use qdev_unplug() insteda of g_free() in xen_pv_find_xendev() Date: Mon, 30 Jan 2017 16:58:29 +0100 Message-ID: <340fded9-a2ee-648c-63ee-6072467df6ad@suse.com> References: <20170130151409.20444-1-jgross@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cYELl-0002xp-27 for xen-devel@lists.xenproject.org; Mon, 30 Jan 2017 15:58:37 +0000 In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Peter Maydell Cc: Stefano Stabellini , QEMU Developers , Gerd Hoffmann , Anthony PERARD , xen-devel@lists.xenproject.org, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= List-Id: xen-devel@lists.xenproject.org T24gMzAvMDEvMTcgMTY6NDYsIFBldGVyIE1heWRlbGwgd3JvdGU6Cj4gT24gMzAgSmFudWFyeSAy MDE3IGF0IDE1OjE0LCBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+IHdyb3RlOgo+PiBU aGUgZXJyb3IgZXhpdHMgb2YgeGVuX3B2X2ZpbmRfeGVuZGV2KCkgZnJlZSB0aGUgbmV3IHhlbi1k ZXZpY2UgdmlhCj4+IGdfZnJlZSgpIHdoaWNoIGlzIHdyb25nLgo+Pgo+PiBBcyB0aGUgeGVuLWRl dmljZSBoYXMgYmVlbiBpbml0aWFsaXplZCBhcyBxZGV2IGl0IG11c3QgYmUgcmVtb3ZlZAo+PiB2 aWEgcWRldl91bnBsdWcoKS4KPj4KPj4gVGhpcyBidWcgaGFzIGJlZW4gaW50cm9kdWNlZCB3aXRo IGNvbW1pdCAzYTZjOTE3MmFjNTk1MWU2ZGFjMmIzZjYKPj4gKCJ4ZW46IGNyZWF0ZSBxZGV2IGZv ciBlYWNoIGJhY2tlbmQgZGV2aWNlIikuCj4+Cj4+IFJlcG9ydGVkLWJ5OiBSb2dlciBQYXUgTW9u bsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT4KPj4gVGVzdGVkLWJ5OiBSb2dlciBQYXUgTW9ubsOp IDxyb2dlci5wYXVAY2l0cml4LmNvbT4KPj4gU2lnbmVkLW9mZi1ieTogSnVlcmdlbiBHcm9zcyA8 amdyb3NzQHN1c2UuY29tPgo+PiAtLS0KPj4gIGh3L3hlbi94ZW5fYmFja2VuZC5jIHwgNCArKy0t Cj4+ICAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQo+Pgo+ PiBkaWZmIC0tZ2l0IGEvaHcveGVuL3hlbl9iYWNrZW5kLmMgYi9ody94ZW4veGVuX2JhY2tlbmQu Ywo+PiBpbmRleCBkMTE5MDA0Li4wMzA3NzJiIDEwMDY0NAo+PiAtLS0gYS9ody94ZW4veGVuX2Jh Y2tlbmQuYwo+PiArKysgYi9ody94ZW4veGVuX2JhY2tlbmQuYwo+PiBAQCAtMTQ1LDcgKzE0NSw3 IEBAIHN0YXRpYyBzdHJ1Y3QgWGVuRGV2aWNlICp4ZW5fYmVfZ2V0X3hlbmRldihjb25zdCBjaGFy ICp0eXBlLCBpbnQgZG9tLCBpbnQgZGV2LAo+PiAgICAgIHhlbmRldi0+ZXZ0Y2huZGV2ID0geGVu ZXZ0Y2huX29wZW4oTlVMTCwgMCk7Cj4+ICAgICAgaWYgKHhlbmRldi0+ZXZ0Y2huZGV2ID09IE5V TEwpIHsKPj4gICAgICAgICAgeGVuX3B2X3ByaW50ZihOVUxMLCAwLCAiY2FuJ3Qgb3BlbiBldnRj aG4gZGV2aWNlXG4iKTsKPj4gLSAgICAgICAgZ19mcmVlKHhlbmRldik7Cj4+ICsgICAgICAgIHFk ZXZfdW5wbHVnKCZ4ZW5kZXYtPnFkZXYsIE5VTEwpOwo+PiAgICAgICAgICByZXR1cm4gTlVMTDsK Pj4gICAgICB9Cj4+ICAgICAgZmNudGwoeGVuZXZ0Y2huX2ZkKHhlbmRldi0+ZXZ0Y2huZGV2KSwg Rl9TRVRGRCwgRkRfQ0xPRVhFQyk7Cj4+IEBAIC0xNTUsNyArMTU1LDcgQEAgc3RhdGljIHN0cnVj dCBYZW5EZXZpY2UgKnhlbl9iZV9nZXRfeGVuZGV2KGNvbnN0IGNoYXIgKnR5cGUsIGludCBkb20s IGludCBkZXYsCj4+ICAgICAgICAgIGlmICh4ZW5kZXYtPmdudHRhYmRldiA9PSBOVUxMKSB7Cj4+ ICAgICAgICAgICAgICB4ZW5fcHZfcHJpbnRmKE5VTEwsIDAsICJjYW4ndCBvcGVuIGdudHRhYiBk ZXZpY2VcbiIpOwo+PiAgICAgICAgICAgICAgeGVuZXZ0Y2huX2Nsb3NlKHhlbmRldi0+ZXZ0Y2hu ZGV2KTsKPj4gLSAgICAgICAgICAgIGdfZnJlZSh4ZW5kZXYpOwo+PiArICAgICAgICAgICAgcWRl dl91bnBsdWcoJnhlbmRldi0+cWRldiwgTlVMTCk7Cj4+ICAgICAgICAgICAgICByZXR1cm4gTlVM TDsKPj4gICAgICAgICAgfQo+PiAgICAgIH0gZWxzZSB7Cj4gCj4gSSB0aGluayB0aGlzIHdpbGwg bGVhayBtZW1vcnkgKGFuZCB0aGF0IHdlJ3JlIGFscmVhZHkgbGVha2luZwo+IG1lbW9yeSksIGJl Y2F1c2UgdGhlIGNvZGUgaXMgY3JlYXRpbmcgdGhlIHhlbmRldiB3aXRoCj4gICAgIHhlbmRldiA9 IGdfbWFsbG9jMChvcHMtPnNpemUpOwo+ICAgICBvYmplY3RfaW5pdGlhbGl6ZSgmeGVuZGV2LT5x ZGV2LCBvcHMtPnNpemUsIFRZUEVfWEVOQkFDS0VORCk7Cj4gCj4gVGhpcyBpcyBzYXlpbmcgIkkg b3duIGFuZCBhbSByZXNwb25zaWJsZSBmb3IgZnJlZWluZyB0aGUgbWVtb3J5Cj4gdGhhdCB0aGUg ZGV2aWNlIG9iamVjdCBsaXZlcyBpbiIuIElmIHlvdSB3YW50IHRoZSBvYmplY3Qgc3lzdGVtCj4g dG8gaGFuZGxlIGZyZWVpbmcgdGhlIG1lbW9yeSBmb3IgeW91IHdoZW4gdGhlIHJlZmVyZW5jZSBj b3VudAo+IGdvZXMgdG8gemVybywgdGhlbiB5b3UgbmVlZCB0byBjcmVhdGUgaXQgd2l0aAo+ICAg IHhlbmRldiA9IG9iamVjdF9uZXcoKQo+IHdoaWNoIHdlIGNhbid0IGRvIGhlcmUgYmVjYXVzZSB3 ZSdyZSBhbGxvY2F0aW5nIG9wcy0+c2l6ZSBieXRlcwo+IHJhdGhlciB0aGFuIGp1c3QgdGhlIHNp emUgb2YgdGhlIG9iamVjdCB0eXBlLgo+IAo+IFR3byBvcHRpb25zIEkgdGhpbms6Cj4gICgxKSBo YXZlIHlvdXIgY29kZSBkbwo+ICAgICBPQkpFQ1QoeGVuZGV2KS0+ZnJlZSA9IGdfZnJlZTsKPiAg YWZ0ZXIgdGhlIG9iamVjdF9pbml0aWFsaXplICh0byB0ZWxsIHRoZSBvYmplY3Qgc3lzdGVtIGhv dwo+IHRvIGZyZWUgdGhpcyBvYmplY3QpCj4gICgyKSBjYWxsIGJvdGggcWRldl91bnBsdWcgYW5k IGdfZnJlZQo+IAo+IEkgdGhpbmsgKDEpIGlzIGJldHRlciBiZWNhdXNlIGl0IHdpbGwgZGVmaW5p dGVseSB3b3JrIGV2ZW4KPiBpZiB0aGUgcWRldiBidXMgc3lzdGVtIGlzIGhvbGRpbmcgb24gdG8g YW4gb2JqZWN0IHJlZmVyZW5jZQo+IGFmdGVyIGl0IHJldHVybnMgZnJvbSBxZGV2X3VucGx1Zygp IGZvciBzb21lIHJlYXNvbiwgYW5kCj4gaXQgd2lsbCBhbHNvIG1lYW4gd2UgZnJlZSB0aGUgbWVt b3J5IHdoZW4gd2UgZG8gYQo+IHFkZXZfdW5wbHVnIGluIHhlbl9wdl9kZWxfeGVuZGV2KCksIHJh dGhlciB0aGFuIGxlYWtpbmcgaXQuCgpJIGFncmVlLiBJJ2xsIHNlbmQgVjIgd2l0aCAoMSkgaW5j bHVkZWQuCgo+IFNpZGUgbm90ZTogVXNpbmcgREVWSUNFKHhlbmRldikgaXMgYmV0dGVyIFFPTSBz dHlsZSB0aGFuCj4gJnhlbmRldi0+cWRldi4KCk9rYXkuIFdpbGwgY2hhbmdlLgoKVGhhbmtzIGZv ciB0aGUgdmVyeSBwcmVjaXNlIGRlc2NyaXB0aW9uLgoKCkp1ZXJnZW4KCgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0 Clhlbi1kZXZlbEBsaXN0cy54ZW4ub3JnCmh0dHBzOi8vbGlzdHMueGVuLm9yZy94ZW4tZGV2ZWwK