MIME-Version: 1.0 Sender: sebastien.raveau@...277... Date: Sun, 28 Jun 2009 18:13:33 +0200 Message-ID: <3453b4110906280913v5351fb0ev96fc9ddbbcf8b5a5@...278...> From: Sebastien Raveau Content-Type: multipart/mixed; boundary=000e0cd1d55ae52377046d6adad2 Subject: [Openvpn-devel] [PATCH] Post-initialization SELinux support for OpenVPN List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: openvpn-devel@lists.sourceforge.net --000e0cd1d55ae52377046d6adad2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Hi everybody! OpenVPN already has support for dropping privileges and confining itself to a directory *after* startup (thanks to calls like setgid, setuid and chroot) which makes for much better management than if you had to respectively start OpenVPN unprivileged and add the privileges it (only) needs during startup, or if you chroot'ed OpenVPN before startup and had to copy the necessary files in the confinement directory. The very same problem occurs with SELinux policy enforcement: one can apply a policy before startup (such as the ready-to-use one provided by http://oss.tresys.com/projects/refpolicy/browser/trunk/policy/modules/services/openvpn.te) but it is waaaay too complicated, just because many rights have to be granted to OpenVPN during its initialization... or one can apply a very simple SELinux policy to OpenVPN when the only need left is basically network I/O operations. The only downside to this is that, just like with setuid() and chroot(), OpenVPN has to call setcon() itself, which is why I am submitting this patch :-) Please note that, while this patch does indeed bring a new dependency to libselinux in OpenVPN on Linux: * the feature will of course only be added if detected by ./configure * libselinux is so common now that even /bin/ls is linked against it on most Linux systems so OpenVPN should get SELinux support quite transparently ;-) Best regards, -- Sebastien Raveau Information Warfare Consultant http://blog.sebastien.raveau.name/ --000e0cd1d55ae52377046d6adad2 Content-Type: text/x-diff; charset=US-ASCII; name="openvpn-selinux.patch" Content-Disposition: attachment; filename="openvpn-selinux.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_fwhycg3y1 ZGlmZiAtdXJOIC1YIGdlbmVyYXRlZCBvcGVudnBuLTIuMC45Lm9yaWcvY29uZmlndXJlLmFjIG9w ZW52cG4tMi4wLjkvY29uZmlndXJlLmFjCi0tLSBvcGVudnBuLTIuMC45Lm9yaWcvY29uZmlndXJl LmFjCTIwMDYtMTAtMDEgMTQ6MTg6MTUuMDAwMDAwMDAwICswMjAwCisrKyBvcGVudnBuLTIuMC45 L2NvbmZpZ3VyZS5hYwkyMDA5LTA2LTIyIDIyOjQyOjMwLjAwMDAwMDAwMCArMDIwMApAQCAtOTUs NiArOTUsMTIgQEAKICAgIFtERUJVRz0ieWVzIl0KICkKIAorQUNfQVJHX0VOQUJMRShzZWxpbnV4 LAorICAgWyAgLS1kaXNhYmxlLXNlbGludXggICAgICAgRGlzYWJsZSBTRUxpbnV4IHN1cHBvcnRd LAorICAgW1NFTElOVVg9IiRlbmFibGV2YWwiXSwKKyAgIFtTRUxJTlVYPSJ5ZXMiXQorKQorCiBB Q19BUkdfRU5BQkxFKHNtYWxsLAogICAgWyAgLS1lbmFibGUtc21hbGwgICAgICAgICAgRW5hYmxl IHNtYWxsZXIgZXhlY3V0YWJsZSBzaXplIChkaXNhYmxlIE9DQywgdXNhZ2UgbWVzc2FnZSwgYW5k IHZlcmIgNCBwYXJtIGxpc3QpXSwKICAgIFtTTUFMTD0iJGVuYWJsZXZhbCJdLApAQCAtNTY4LDYg KzU3NCwyMyBAQAogICAgZmkKIGZpCiAKK2RubAorZG5sIGNoZWNrIGZvciBTRUxpbnV4IGxpYnJh cnkgYW5kIGhlYWRlcnMKK2RubAoraWYgdGVzdCAiJFNFTElOVVgiID0gInllcyI7IHRoZW4KKyAg IEFDX0NIRUNLSU5HKFtmb3IgbGlic2VsaW51eCBMaWJyYXJ5IGFuZCBIZWFkZXIgZmlsZXNdKQor ICAgQUNfQ0hFQ0tfSEVBREVSKHNlbGludXgvc2VsaW51eC5oLAorICAgICAgW0FDX0NIRUNLX0xJ QihzZWxpbnV4LCBzZXRjb24sCisgICAgICAgICBbCisgICAgICAgICAgICBPUEVOVlBOX0FERF9M SUJTKC1sc2VsaW51eCkKKyAgICAgICAgICAgIEFDX0RFRklORShIQVZFX1NFVENPTiwgMSwgW1NF TGludXggc3VwcG9ydF0pCisgICAgICAgICBdLAorICAgICAgICAgICAgW0FDX01TR19SRVNVTFQo W1NFTGludXggbGlicmFyeSBub3QgZm91bmQuXSldCisgICAgICAgICApXSwKKyAgICAgIFtBQ19N U0dfUkVTVUxUKFtTRUxpbnV4IGhlYWRlcnMgbm90IGZvdW5kLl0pXQorICAgKQorZmkKKwogZG5s IGVuYWJsZSBtdWx0aS1jbGllbnQgbW9kZQogaWYgdGVzdCAiJE1VTFRJIiA9ICJ5ZXMiOyB0aGVu CiAgICBBQ19ERUZJTkUoRU5BQkxFX0NMSUVOVF9TRVJWRVIsIDEsIFtFbmFibGUgY2xpZW50L3Nl cnZlciBjYXBhYmlsaXR5XSkKZGlmZiAtdXJOIC1YIGdlbmVyYXRlZCBvcGVudnBuLTIuMC45Lm9y aWcvaW5pdC5jIG9wZW52cG4tMi4wLjkvaW5pdC5jCi0tLSBvcGVudnBuLTIuMC45Lm9yaWcvaW5p dC5jCTIwMDYtMDQtMDUgMDg6NDI6MzIuMDAwMDAwMDAwICswMjAwCisrKyBvcGVudnBuLTIuMC45 L2luaXQuYwkyMDA5LTA2LTIyIDIyOjQyOjMwLjAwMDAwMDAwMCArMDIwMApAQCAtNDA1LDYgKzQw NSwxNyBAQAogCXsKIAkgIG1zZyAoTV9JTkZPLCAiTk9URTogVUlEL0dJRCBkb3duZ3JhZGUgJXMi LCB3aHlfbm90KTsKIAl9CisKKyAgICAgIC8qIHNldCBTRUxpbnV4IGNvbnRleHQ7IGRvaW5nIGl0 IGFmdGVyIGNocm9vdCByZXF1aXJlcyAvcHJvYworICAgICAgICAgdG8gYmUgbW91bnRlZCBpbiB0 aGUgY2hyb290ICh3aGljaCBpcyBhbm5veWluZyBpbmRlZWQgYnV0CisgICAgICAgICBkb2luZyBp dCBiZWZvcmUgcmVxdWlyZXMgbW9yZSBjb21wbGV4IFNFTGludXggcG9saWNpZXMgKi8KKyAgICAg IGlmIChjLT5vcHRpb25zLnNlbGludXhfY29udGV4dCkKKyAgICAgICAgeworICAgICAgICAgIGlm IChub19kZWxheSkKKyAgICAgICAgICAgIGRvX3NldGNvbihjLT5vcHRpb25zLnNlbGludXhfY29u dGV4dCk7CisgICAgICAgICAgZWxzZQorICAgICAgICAgICAgbXNnIChNX0lORk8sICJOT1RFOiBz ZXRjb24gJXMiLCB3aHlfbm90KTsKKyAgICAgICAgfQogICAgIH0KIH0KIApAQCAtMTU2Myw4ICsx NTc0LDggQEAKICAgaWYgKG8tPnBpbmdfc2VuZF90aW1lb3V0ICYmICFvLT5waW5nX3JlY190aW1l b3V0KQogICAgIG1zZyAoTV9XQVJOLCAiV0FSTklORzogLS1waW5nIHNob3VsZCBub3JtYWxseSBi ZSB1c2VkIHdpdGggLS1waW5nLXJlc3RhcnQgb3IgLS1waW5nLWV4aXQiKTsKIAotICBpZiAoKG8t PnVzZXJuYW1lIHx8IG8tPmdyb3VwbmFtZSB8fCBvLT5jaHJvb3RfZGlyKSAmJiAoIW8tPnBlcnNp c3RfdHVuIHx8ICFvLT5wZXJzaXN0X2tleSkpCi0gICAgbXNnIChNX1dBUk4sICJXQVJOSU5HOiB5 b3UgYXJlIHVzaW5nIHVzZXIvZ3JvdXAvY2hyb290IHdpdGhvdXQgcGVyc2lzdC1rZXkvcGVyc2lz dC10dW4gLS0gdGhpcyBtYXkgY2F1c2UgcmVzdGFydHMgdG8gZmFpbCIpOworICBpZiAoKG8tPnVz ZXJuYW1lIHx8IG8tPmdyb3VwbmFtZSB8fCBvLT5jaHJvb3RfZGlyIHx8IG8tPnNlbGludXhfY29u dGV4dCkgJiYgKCFvLT5wZXJzaXN0X3R1biB8fCAhby0+cGVyc2lzdF9rZXkpKQorICAgIG1zZyAo TV9XQVJOLCAiV0FSTklORzogeW91IGFyZSB1c2luZyB1c2VyL2dyb3VwL2Nocm9vdC9zZXRjb24g d2l0aG91dCBwZXJzaXN0LWtleS9wZXJzaXN0LXR1biAtLSB0aGlzIG1heSBjYXVzZSByZXN0YXJ0 cyB0byBmYWlsIik7CiAKICNpZiBQMk1QCiAgIGlmIChvLT5wdWxsICYmIG8tPmlmY29uZmlnX2xv Y2FsICYmIGMtPmZpcnN0X3RpbWUpCmRpZmYgLXVyTiAtWCBnZW5lcmF0ZWQgb3BlbnZwbi0yLjAu OS5vcmlnL21pc2MuYyBvcGVudnBuLTIuMC45L21pc2MuYwotLS0gb3BlbnZwbi0yLjAuOS5vcmln L21pc2MuYwkyMDA1LTExLTA1IDA4OjA0OjIyLjAwMDAwMDAwMCArMDEwMAorKysgb3BlbnZwbi0y LjAuOS9taXNjLmMJMjAwOS0wNi0yMiAyMzowMDozNi4wMDAwMDAwMDAgKzAyMDAKQEAgLTYyLDYg KzYyLDI1IEBACiAgICAgfQogfQogCisvKiBBcHBseSBTRUxpbnV4IGNvbnRleHQgaW4gb3JkZXIg dG8gcmVzdHJpY3Qgd2hhdAorICAgT3BlblZQTiBjYW4gZG8gdG8gX29ubHlfIHdoYXQgaXQgaXMg c3VwcG9zZWQgdG8KKyAgIGRvIGFmdGVyIGluaXRpYWxpemF0aW9uIGlzIGNvbXBsZXRlIChiYXNp Y2FsbHkKKyAgIG5ldHdvcmsgSS9PIG9wZXJhdGlvbnMpICovCit2b2lkCitkb19zZXRjb24gKGNv bnN0IGNoYXIgKmNvbnRleHQpCit7CisgIGlmIChjb250ZXh0KQorICAgIHsKKyNpZmRlZiBIQVZF X1NFVENPTgorICAgICAgaWYgKC0xID09IHNldGNvbiAoY29udGV4dCkpCisgICAgICAgIG1zZyAo TV9FUlIsICJzZXRjb24gdG8gJyVzJyBmYWlsZWQ7IGlzIC9wcm9jIGFjY2Vzc2libGU/IiwgY29u dGV4dCk7CisgICAgICBtc2cgKE1fSU5GTywgInNldGNvbiB0byAnJXMnIHN1Y2NlZWRlZCIsIGNv bnRleHQpOworI2Vsc2UKKyAgICAgIG1zZyAoTV9GQVRBTCwgIlNvcnJ5IGJ1dCBJIGNhbid0IHNl dCBTRUxpbnV4IGNvbnRleHQgdG8gJyVzJyBiZWNhdXNlIHRoaXMgb3BlcmF0aW5nIHN5c3RlbSBk b2Vzbid0IGFwcGVhciB0byBzdXBwb3J0IHRoZSBzZXRjb24oKSBzeXN0ZW0gY2FsbCIsIGNvbnRl eHQpOworI2VuZGlmCisgICAgfQorfQorCiAvKiBHZXQvU2V0IFVJRCBvZiBwcm9jZXNzICovCiAK IGJvb2wKZGlmZiAtdXJOIC1YIGdlbmVyYXRlZCBvcGVudnBuLTIuMC45Lm9yaWcvb3BlbnZwbi44 IG9wZW52cG4tMi4wLjkvb3BlbnZwbi44Ci0tLSBvcGVudnBuLTIuMC45Lm9yaWcvb3BlbnZwbi44 CTIwMDUtMTEtMDMgMDI6MTY6NDMuMDAwMDAwMDAwICswMTAwCisrKyBvcGVudnBuLTIuMC45L29w ZW52cG4uOAkyMDA5LTA2LTIyIDIyOjQyOjMwLjAwMDAwMDAwMCArMDIwMApAQCAtMjMyLDYgKzIz Miw3IEBACiBbXCBcZkJcLVwtc2VydmVyXC1icmlkZ2VcZlJcIFxmSWdhdGV3YXlcIG5ldG1hc2tc IHBvb2xcLXN0YXJ0XC1JUFwgcG9vbFwtZW5kXC1JUFxmUlwgXQogW1wgXGZCXC1cLXNlcnZlclxm UlwgXGZJbmV0d29ya1wgbmV0bWFza1xmUlwgXQogW1wgXGZCXC1cLXNlcnZpY2VcZlJcIFxmSWV4 aXRcLWV2ZW50XCBbMHwxXVxmUlwgXQorW1wgXGZCXC1cLXNldGNvblxmUlwgXGZJY29udGV4dFxm UlwgXQogW1wgXGZCXC1cLXNldGVudlxmUlwgXGZJbmFtZVwgdmFsdWVcZlJcIF0KIFtcIFxmQlwt XC1zaGFwZXJcZlJcIFxmSW5cZlJcIF0KIFtcIFxmQlwtXC1zaG93XC1hZGFwdGVyc1xmUlwgXQpA QCAtMTc1OSw2ICsxNzYwLDM5IEBACiBhcmUgZXhlY3V0ZWQgYWZ0ZXIgdGhlIGNocm9vdCBvcGVy YXRpb24uCiAuXCIqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq KioqKioqKioqKioKIC5UUAorLkIgLS1zZXRjb24gY29udGV4dAorQXBwbHkgU0VMaW51eAorLkIg Y29udGV4dAorYWZ0ZXIgaW5pdGlhbGl6YXRpb24uIFRoaXMKK2Vzc2VudGlhbGx5IHByb3ZpZGVz IHRoZSBhYmlsaXR5IHRvIHJlc3RyaWN0IE9wZW5WUE4ncworcmlnaHRzIHRvIG9ubHkgbmV0d29y ayBJL08gb3BlcmF0aW9ucywgdGhhbmtzIHRvCitTRUxpbnV4LiBUaGlzIGdvZXMgZnVydGhlciB0 aGFuCisuQiAtLXVzZXIKK2FuZAorLkIgLS1jaHJvb3QKK2luIHRoYXQgdGhvc2UgdHdvLCB3aGls ZSBiZWluZyBncmVhdCBzZWN1cml0eSBmZWF0dXJlcywKK3VuZm9ydHVuYXRlbHkgZG8gbm90IHBy b3RlY3QgYWdhaW5zdCBwcml2aWxlZ2UgZXNjYWxhdGlvbgorYnkgZXhwbG9pdGF0aW9uIG9mIGEg dnVsbmVyYWJsZSBzeXN0ZW0gY2FsbC4gWW91IGNhbiBvZgorY291cnNlIGNvbWJpbmUgYWxsIHRo cmVlLCBidXQgcGxlYXNlIG5vdGUgdGhhdCBzaW5jZQorc2V0Y29uIHJlcXVpcmVzIGFjY2VzcyB0 byAvcHJvYyB5b3Ugd2lsbCBoYXZlIHRvIHByb3ZpZGUKK2l0IGluc2lkZSB0aGUgY2hyb290IGRp cmVjdG9yeSAoZS5nLiB3aXRoIG1vdW50IC0tYmluZCkuCisKK1NpbmNlIHRoZSBzZXRjb24gb3Bl cmF0aW9uIGlzIGRlbGF5ZWQgdW50aWwgYWZ0ZXIKK2luaXRpYWxpemF0aW9uLCBPcGVuVlBOIGNh biBiZSByZXN0cmljdGVkIHRvIGp1c3QKK25ldHdvcmstcmVsYXRlZCBzeXN0ZW0gY2FsbHMsIHdo ZXJlYXMgYnkgYXBwbHlpbmcgdGhlCitjb250ZXh0IGJlZm9yZSBzdGFydHVwIChzdWNoIGFzIHRo ZSBPcGVuVlBOIG9uZSBwcm92aWRlZAoraW4gdGhlIFNFTGludXggUmVmZXJlbmNlIFBvbGljaWVz KSB5b3Ugd2lsbCBoYXZlIHRvCithbGxvdyBtYW55IHRoaW5ncyByZXF1aXJlZCBvbmx5IGR1cmlu ZyBpbml0aWFsaXphdGlvbi4KKworTGlrZSB3aXRoIGNocm9vdCwgY29tcGxpY2F0aW9ucyBjYW4g cmVzdWx0IHdoZW4gc2NyaXB0cworb3IgcmVzdGFydHMgYXJlIGV4ZWN1dGVkIGFmdGVyIHRoZSBz ZXRjb24gb3BlcmF0aW9uLAord2hpY2ggaXMgd2h5IHlvdSBzaG91bGQgcmVhbGx5IGNvbnNpZGVy IHVzaW5nIHRoZQorLkIgLS1wZXJzaXN0LWtleQorYW5kCisuQiAtLXBlcnNpc3QtdHVuCitvcHRp b25zLgorLlwiKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq KioqKioqKioqCisuVFAKIC5CIC0tZGFlbW9uIFtwcm9nbmFtZV0KIEJlY29tZSBhIGRhZW1vbiBh ZnRlciBhbGwgaW5pdGlhbGl6YXRpb24gZnVuY3Rpb25zIGFyZSBjb21wbGV0ZWQuCiBUaGlzIG9w dGlvbiB3aWxsIGNhdXNlIGFsbCBtZXNzYWdlIGFuZCBlcnJvciBvdXRwdXQgdG8KZGlmZiAtdXJO IC1YIGdlbmVyYXRlZCBvcGVudnBuLTIuMC45Lm9yaWcvb3B0aW9ucy5jIG9wZW52cG4tMi4wLjkv b3B0aW9ucy5jCi0tLSBvcGVudnBuLTIuMC45Lm9yaWcvb3B0aW9ucy5jCTIwMDUtMTItMTMgMDA6 NTA6NDMuMDAwMDAwMDAwICswMTAwCisrKyBvcGVudnBuLTIuMC45L29wdGlvbnMuYwkyMDA5LTA2 LTIyIDIyOjQyOjMwLjAwMDAwMDAwMCArMDIwMApAQCAtMjIwLDYgKzIyMCw3IEBACiAgICIgICAg ICAgICAgICAgICAgICBjYXVzZWQgYnkgLS1waW5nLXJlc3RhcnQgb3IgU0lHVVNSMVxuIgogICAi LS11c2VyIHVzZXIgICAgIDogU2V0IFVJRCB0byB1c2VyIGFmdGVyIGluaXRpYWxpemF0aW9uLlxu IgogICAiLS1ncm91cCBncm91cCAgIDogU2V0IEdJRCB0byBncm91cCBhZnRlciBpbml0aWFsaXph dGlvbi5cbiIKKyAgIi0tc2V0Y29uIGNvbnRleHQ6IEFwcGx5IHRoaXMgU0VMaW51eCBjb250ZXh0 IGFmdGVyIGluaXRpYWxpemF0aW9uLlxuIgogICAiLS1jaHJvb3QgZGlyICAgIDogQ2hyb290IHRv IHRoaXMgZGlyZWN0b3J5IGFmdGVyIGluaXRpYWxpemF0aW9uLlxuIgogICAiLS1jZCBkaXIgICAg ICAgIDogQ2hhbmdlIHRvIHRoaXMgZGlyZWN0b3J5IGJlZm9yZSBpbml0aWFsaXphdGlvbi5cbiIK ICAgIi0tZGFlbW9uIFtuYW1lXSA6IEJlY29tZSBhIGRhZW1vbiBhZnRlciBpbml0aWFsaXphdGlv bi5cbiIKQEAgLTEwMTYsNiArMTAxNyw3IEBACiAgIFNIT1dfU1RSIChncm91cG5hbWUpOwogICBT SE9XX1NUUiAoY2hyb290X2Rpcik7CiAgIFNIT1dfU1RSIChjZF9kaXIpOworICBTSE9XX1NUUiAo c2VsaW51eF9jb250ZXh0KTsKICAgU0hPV19TVFIgKHdyaXRlcGlkKTsKICAgU0hPV19TVFIgKHVw X3NjcmlwdCk7CiAgIFNIT1dfU1RSIChkb3duX3NjcmlwdCk7CkBAIC0yOTE5LDYgKzI5MjEsMTIg QEAKIAl9CiAgICAgICBvcHRpb25zLT5jZF9kaXIgPSBwWzFdOwogICAgIH0KKyAgZWxzZSBpZiAo c3RyZXEgKHBbMF0sICJzZXRjb24iKSAmJiBwWzFdKQorICAgIHsKKyAgICAgICsraTsKKyAgICAg IFZFUklGWV9QRVJNSVNTSU9OIChPUFRfUF9HRU5FUkFMKTsKKyAgICAgIG9wdGlvbnMtPnNlbGlu dXhfY29udGV4dCA9IHBbMV07CisgICAgfQogICBlbHNlIGlmIChzdHJlcSAocFswXSwgIndyaXRl cGlkIikgJiYgcFsxXSkKICAgICB7CiAgICAgICArK2k7CmRpZmYgLXVyTiAtWCBnZW5lcmF0ZWQg b3BlbnZwbi0yLjAuOS5vcmlnL29wdGlvbnMuaCBvcGVudnBuLTIuMC45L29wdGlvbnMuaAotLS0g b3BlbnZwbi0yLjAuOS5vcmlnL29wdGlvbnMuaAkyMDA1LTExLTAxIDEyOjA2OjExLjAwMDAwMDAw MCArMDEwMAorKysgb3BlbnZwbi0yLjAuOS9vcHRpb25zLmgJMjAwOS0wNi0yMiAyMjo0MjozMC4w MDAwMDAwMDAgKzAyMDAKQEAgLTE5Miw2ICsxOTIsNyBAQAogICBjb25zdCBjaGFyICpncm91cG5h bWU7CiAgIGNvbnN0IGNoYXIgKmNocm9vdF9kaXI7CiAgIGNvbnN0IGNoYXIgKmNkX2RpcjsKKyAg Y29uc3QgY2hhciAqc2VsaW51eF9jb250ZXh0OwogICBjb25zdCBjaGFyICp3cml0ZXBpZDsKICAg Y29uc3QgY2hhciAqdXBfc2NyaXB0OwogICBjb25zdCBjaGFyICpkb3duX3NjcmlwdDsK --000e0cd1d55ae52377046d6adad2--