Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A023CC433EF for ; Mon, 17 Jan 2022 17:51:34 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C367A8128D; Mon, 17 Jan 2022 18:51:31 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=akkea.ca Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=akkea.ca header.i=@akkea.ca header.b="GeXtyAcG"; dkim=pass (1024-bit key) header.d=akkea.ca header.i=@akkea.ca header.b="ANVjB1OR"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 0BC11834B1; Mon, 17 Jan 2022 18:51:30 +0100 (CET) Received: from node.akkea.ca (li1434-30.members.linode.com [45.33.107.30]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 17AFF811AC for ; Mon, 17 Jan 2022 18:51:27 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=akkea.ca Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=angus@akkea.ca Received: from localhost (localhost [127.0.0.1]) by node.akkea.ca (Postfix) with ESMTP id 973F14E2006; Mon, 17 Jan 2022 17:51:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akkea.ca; s=mail; t=1642441885; bh=OnPaWenF6jq4pAMlT5dWagQ7DvOMXi7RIwwnMsIGxRM=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=GeXtyAcGfTqku4k9S5khTzT9uNfar11L28/dbR2AUPLb4TFIA99DpN6BfMqeS6Tiu 8M08rsPV/0N+kHvasjmZdJg8Y3I3fEYMNJUEmk6cRPL1ZwzfsP795He9gJ9+D7OPHr +Wj7BgiYZ3UDmtuv0GPFI1yxYyJnvOkirL3/iwkQ= Received: from node.akkea.ca ([127.0.0.1]) by localhost (mail.akkea.ca [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id engMhGvcvZjo; Mon, 17 Jan 2022 17:51:24 +0000 (UTC) Received: from www.akkea.ca (li1434-30.members.linode.com [45.33.107.30]) by node.akkea.ca (Postfix) with ESMTPSA id 9A7B04E2003; Mon, 17 Jan 2022 17:51:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akkea.ca; s=mail; t=1642441884; bh=OnPaWenF6jq4pAMlT5dWagQ7DvOMXi7RIwwnMsIGxRM=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=ANVjB1ORcSUki9HIImQFwAFNoR7tlRk8DLTgMPDC1Mc+NQD/i4DDNqljFB3WEQ9wj u4ZxAGA/bv2biyCiQHbbT8zQM/ZEBm87SZi8oEHbF08JcqSb3RZoMB3ahc43f5OXnw PYdSZbWktj7KlSO/Nnn+bvZBMLJ6sr79yPJa42DY= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 17 Jan 2022 09:51:24 -0800 From: Angus Ainslie To: Tom Rini Cc: "NXP i.MX U-Boot Team" , u-boot@lists.denx.de, Stefano Babic , Fabio Estevam , Peng Fan , Marcel Ziswiler , Teresa Remmet , Adam Ford , Tim Harvey , Jagan Teki , Ilko Iliev , kernel@puri.sm Subject: Re: [PATCH 02/13] arm: dts: add the Purism devicetree files In-Reply-To: <20220117165932.GL2631111@bill-the-cat> References: <20220117150735.218886-1-angus@akkea.ca> <20220117150735.218886-3-angus@akkea.ca> <20220117165932.GL2631111@bill-the-cat> Message-ID: <3498b84cf21f803c0466927fdb83d9be@akkea.ca> X-Sender: angus@akkea.ca User-Agent: Roundcube Webmail/1.3.6 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Tom, On 2022-01-17 08:59, Tom Rini wrote: > On Mon, Jan 17, 2022 at 07:07:24AM -0800, Angus Ainslie wrote: > >> Initial commit of Librem5 devicetree files >> >> Signed-off-by: Angus Ainslie > > Please note what kernel release the not -u-boot.dtsi files are a copy > from, as they need to be copies and not modified, thanks. There's an issue with adding the devicetree from the 5.16 kernel. I get a compilation error due to a :missing .h in the devicetree files: In file included from arch/arm/dts/imx8mq-librem5-r3.dtsi:11, from arch/arm/dts/.imx8mq-librem5.dtb.pre.tmp:6: arch/arm/dts/imx8mq-librem5.dtsi:13:10: fatal error: dt-bindings/rfkill/rfkill.h: No such file or directory 13 | #include "dt-bindings/rfkill/rfkill.h" | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Should that get added to the u-boot source as well or should I modify the dts to remove this ? For the kernel we also have 4 different dts files for the differences in PCB versions. For u-boot we don't need the differentiation as it deals with things like camera rotation and prox sensor sensitivity. There's 2 ways to solve the this I think. 1) just use the latest librem5 dts file which is made up of 3 different dts(i) files. 2) have a defconfig for each of the different PCB versions. Do you have a preference ? Thanks Angus