Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B5C4C433DB for ; Fri, 26 Feb 2021 07:41:59 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F329364ED3 for ; Fri, 26 Feb 2021 07:41:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F329364ED3 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.90101.170429 (Exim 4.92) (envelope-from ) id 1lFXkj-0006D6-As; Fri, 26 Feb 2021 07:41:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 90101.170429; Fri, 26 Feb 2021 07:41:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lFXkj-0006Cz-7q; Fri, 26 Feb 2021 07:41:33 +0000 Received: by outflank-mailman (input) for mailman id 90101; Fri, 26 Feb 2021 07:41:32 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lFXki-0006Cu-Ac for xen-devel@lists.xenproject.org; Fri, 26 Feb 2021 07:41:32 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 2237a4f4-cbf6-44db-85f0-f634d1b520c0; Fri, 26 Feb 2021 07:41:30 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 27559ADDD; Fri, 26 Feb 2021 07:41:29 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2237a4f4-cbf6-44db-85f0-f634d1b520c0 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614325289; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AyWuNdA7FXC5/tU0kRxD8yU7VkIW5TdtlUXQHM6JuME=; b=Mhde/J2MunZV90byjEEqb7635Sbb7JrcMRSVMKABcJb/89vqDMdrGI621v8TDWTE/3Bg2W SmQWjljlG9g2/wKj3eCFM53sDP9qX7+ym6NVuWyQv94dejPdMQIZA23jUyeZh+6gft86ar dyJXd0nhfV0v3I3DKR3d20dsPh5JfYg= Subject: Re: [PATCH for-next 2/6] xen/common: Guard iommu symbols with CONFIG_HAS_PASSTHROUGH To: Connor Davis Cc: Bobby Eshleman , Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <444658f690c81b9e93c2c709fa1032c049646763.1614265718.git.connojdavis@gmail.com> <02f32a31-1c23-46af-54a7-7d44b5ffb613@suse.com> <20210226025402.ryuxpicaqujmfxbu@thewall> From: Jan Beulich Message-ID: <34bb915a-be60-1cc7-c802-e0491b6741df@suse.com> Date: Fri, 26 Feb 2021 08:41:25 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210226025402.ryuxpicaqujmfxbu@thewall> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 26.02.2021 03:54, Connor Davis wrote: > On Thu, Feb 25, 2021 at 04:45:15PM +0100, Jan Beulich wrote: >> On 25.02.2021 16:24, Connor Davis wrote: >>> --- a/xen/common/domain.c >>> +++ b/xen/common/domain.c >>> @@ -501,7 +501,9 @@ static int sanitise_domain_config(struct xen_domctl_createdomain *config) >>> return -EINVAL; >>> } >>> >>> +#ifdef CONFIG_HAS_PASSTHROUGH >>> if ( !iommu_enabled ) >>> +#endif >>> { >>> dprintk(XENLOG_INFO, "IOMMU requested but not available\n"); >>> return -EINVAL; >> >> Where possible - to avoid such #ifdef-ary - the symbol instead should >> get #define-d to a sensible value ("false" in this case) in the header. >> The other cases here may indeed need to remain as you have them. >> > Do you prefer the #define in the same function near the if or > somwhere near the top of the file? Neither, if I understand you correctly. It should be in the same header where the extern declaration lives, for the whole code base to consume. Jan