From: Marek Vasut Date: Thu, 1 Oct 2020 01:02:57 +0200 Subject: [PATCH v3] i2c: rcar_i2c: Fix i2c read/write errors In-Reply-To: <20200930122412.31156-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20200930122412.31156-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Message-ID: <352ec012-e323-d944-437e-1c78b7de1e19@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 9/30/20 2:24 PM, Lad Prabhakar wrote: > commit 7c8f821e ("i2c: rcar_i2c: Set the slave address from > rcar_i2c_xfer") blindly called rcar_i2c_set_addr() with read argument > always set to 1 during xfer which introduced read/write errors, whereas > earlier rcar_i2c_read_common() called rcar_i2c_set_addr() with read set to > 1 and rcar_i2c_write_common() called rcar_i2c_set_addr() with read set 0. It would be good to explain in the commit message why the previous code was correct. > Fixes: 7c8f821e ("i2c: rcar_i2c: Set the slave address from rcar_i2c_xfer") > Signed-off-by: Lad Prabhakar Reviewed-by: Marek Vasut [...]