From: Dave Gordon Subject: Re: [PATCH 3/3] drm/i915/guc: general tidying up (submission) Date: Wed, 14 Sep 2016 18:00:45 +0100 Message-ID: <35472b67-9044-a772-88e5-18eb7d9b6468@intel.com> References: <1473711577-11454-1-git-send-email-david.s.gordon@intel.com> <1473711577-11454-4-git-send-email-david.s.gordon@intel.com> <88875836-d9e4-72b2-9875-8da444d1fee8@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id C367289F31 for ; Wed, 14 Sep 2016 17:00:52 +0000 (UTC) In-Reply-To: <88875836-d9e4-72b2-9875-8da444d1fee8@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Tvrtko Ursulin , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gMTQvMDkvMTYgMTY6MjIsIFR2cnRrbyBVcnN1bGluIHdyb3RlOgo+Cj4gT24gMTIvMDkvMjAx NiAyMToxOSwgRGF2ZSBHb3Jkb24gd3JvdGU6Cj4+IFJlbmFtaW5nIHRvIG1vcmUgY29uc2lzdGVu dCBzY2hlbWUsIGFuZCB1cGRhdGluZyBjb21tZW50cywgbW9zdGx5Cj4+IGFib3V0IGk5MTVfZ3Vj X3dxX3Jlc2VydmUoKSwgYWthIGk5MTVfZ3VjX3dxX2NoZWNrX3NwYWNlKCkuCj4+Cj4+IFNpZ25l ZC1vZmYtYnk6IERhdmUgR29yZG9uIDxkYXZpZC5zLmdvcmRvbkBpbnRlbC5jb20+Cj4+IC0tLQo+ PiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ3VjX3N1Ym1pc3Npb24uYyB8IDYzCj4+ICsr KysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLQo+PiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2d1Yy5oICAgICAgICAgICB8ICAyICstCj4+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfbHJjLmMgICAgICAgICAgIHwgIDIgKy0KPj4gICAzIGZpbGVzIGNoYW5nZWQsIDM0IGluc2Vy dGlvbnMoKyksIDMzIGRlbGV0aW9ucygtKQo+PgoKW3NuaXBdCgo+PiAgIGludCBpOTE1X2d1Y19z dWJtaXNzaW9uX2luaXQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+PiAgIHsK Pj4gKyAgICBjb25zdCBzaXplX3QgY3R4c2l6ZSA9IHNpemVvZihzdHJ1Y3QgZ3VjX2NvbnRleHRf ZGVzYyk7Cj4+ICsgICAgY29uc3Qgc2l6ZV90IHBvb2xzaXplID0gR1VDX01BWF9HUFVfQ09OVEVY VFMgKiBjdHhzaXplOwo+PiArICAgIGNvbnN0IHNpemVfdCBnZW1zaXplID0gcm91bmRfdXAocG9v bHNpemUsIFBBR0VfU0laRSk7Cj4+ICAgICAgIHN0cnVjdCBpbnRlbF9ndWMgKmd1YyA9ICZkZXZf cHJpdi0+Z3VjOwo+PiAgICAgICBzdHJ1Y3QgaTkxNV92bWEgKnZtYTsKPj4gLSAgICB1MzIgc2l6 ZTsKPj4gICAgICAgICAvKiBXaXBlIGJpdG1hcCAmIGRlbGV0ZSBjbGllbnQgaW4gY2FzZSBvZiBy ZWluaXRpYWxpc2F0aW9uICovCj4+ICAgICAgIGJpdG1hcF9jbGVhcihndWMtPmRvb3JiZWxsX2Jp dG1hcCwgMCwgR1VDX01BWF9ET09SQkVMTFMpOwo+PiBAQCAtOTg1LDE1ICs5ODcsMTQgQEAgaW50 IGk5MTVfZ3VjX3N1Ym1pc3Npb25faW5pdChzdHJ1Y3QKPj4gZHJtX2k5MTVfcHJpdmF0ZSAqZGV2 X3ByaXYpCj4+ICAgICAgIGlmIChndWMtPmN0eF9wb29sX3ZtYSkKPj4gICAgICAgICAgIHJldHVy biAwOyAvKiBhbHJlYWR5IGFsbG9jYXRlZCAqLwo+PiAgIC0gICAgc2l6ZSA9IFBBR0VfQUxJR04o R1VDX01BWF9HUFVfQ09OVEVYVFMqc2l6ZW9mKHN0cnVjdAo+PiBndWNfY29udGV4dF9kZXNjKSk7 Cj4+IC0gICAgdm1hID0gZ3VjX2FsbG9jYXRlX3ZtYShndWMsIHNpemUpOwo+PiArICAgIHZtYSA9 IGd1Y19hbGxvY2F0ZV92bWEoZ3VjLCBnZW1zaXplKTsKPgo+IFBBR0VfQUxJR04gbG9zdCAtIGxv d2VyIGxheWVycyBkbyB0aGF0IGZvciB1cz8gSSBkb24ndCBoYXZlIGVhc3kgYWNjZXNzCj4gdG8g dGhlIHRyZWUgYXQgdGhlIG1vbWVudCB0byBjaGVjayBhbmQgSSBraW5kIG9mIGNhbid0IHJlbWVt YmVyIHJpZ2h0IG5vdy4KClBBR0VfQUxJR04gaGVyZSBpcyByZXBsYWNlZCBieSB1c2luZyByb3Vu ZF91cCguLi4sIFBBR0VfU0laRSkgYXQgdGhlIApwb2ludCB3aGVyZSB0aGUgY29uc3RhbnQgaXMg ZGVmaW5lZCBhIGZldyBsaW5lcyBhYm92ZS4gSSB0aGluayAKcm91bmRfdXAoKSBpcyBjbGVhcmVy LCBiZWNhdXNlICJhbGlnbiIgY291bGQgZXF1YWxseSB3ZWxsIG1lYW4gcm91bmQgCmRvd24uIEFu eXdheSAiYWxpZ24iICh1cCBvciBkb3duKSBpcyBzb21ldGhpbmcgeW91IGRvIHRvIGFkZHJlc3Nl cyBvciAKb2Zmc2V0cywgbm90IHNpemVzLgoKLkRhdmUuCgo+PiAgICAgICBpZiAoSVNfRVJSKHZt YSkpCj4+ICAgICAgICAgICByZXR1cm4gUFRSX0VSUih2bWEpOwo+PiAgICAgICAgIGd1Yy0+Y3R4 X3Bvb2xfdm1hID0gdm1hOwo+PiAgICAgICBpZGFfaW5pdCgmZ3VjLT5jdHhfaWRzKTsKPj4gLSAg ICBndWNfY3JlYXRlX2xvZyhndWMpOwo+PiAtICAgIGd1Y19jcmVhdGVfYWRzKGd1Yyk7Cj4+ICsg ICAgZ3VjX2xvZ19jcmVhdGUoZ3VjKTsKPj4gKyAgICBndWNfYWRkb25fY3JlYXRlKGd1Yyk7Cj4+ ICAgICAgICAgcmV0dXJuIDA7Cj4+ICAgfQo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfZ3VjLmgKPj4gYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ndWMuaAo+ PiBpbmRleCA0Njc4NDU5Li5iMWJhODY5IDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9ndWMuaAo+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ndWMu aAo+PiBAQCAtMTU5LDcgKzE1OSw3IEBAIGV4dGVybiBpbnQgaW50ZWxfZ3VjX3Jlc3VtZShzdHJ1 Y3QgZHJtX2RldmljZSAqZGV2KTsKPj4gICAvKiBpOTE1X2d1Y19zdWJtaXNzaW9uLmMgKi8KPj4g ICBpbnQgaTkxNV9ndWNfc3VibWlzc2lvbl9pbml0KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpk ZXZfcHJpdik7Cj4+ICAgaW50IGk5MTVfZ3VjX3N1Ym1pc3Npb25fZW5hYmxlKHN0cnVjdCBkcm1f aTkxNV9wcml2YXRlICpkZXZfcHJpdik7Cj4+IC1pbnQgaTkxNV9ndWNfd3FfY2hlY2tfc3BhY2Uo c3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpycSk7Cj4+ICtpbnQgaTkxNV9ndWNfd3FfcmVz ZXJ2ZShzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKnJxKTsKPj4gICB2b2lkIGk5MTVfZ3Vj X3N1Ym1pc3Npb25fZGlzYWJsZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpOwo+ PiAgIHZvaWQgaTkxNV9ndWNfc3VibWlzc2lvbl9maW5pKHN0cnVjdCBkcm1faTkxNV9wcml2YXRl ICpkZXZfcHJpdik7Cj4+ICAgZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2xyYy5jCj4+IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMKPj4gaW5kZXggMTZk N2NkZC4uMjUxMTQzMzYgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2xyYy5jCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jCj4+IEBAIC02 MjcsNyArNjI3LDcgQEAgaW50IGludGVsX2xvZ2ljYWxfcmluZ19hbGxvY19yZXF1ZXN0X2V4dHJh cyhzdHJ1Y3QKPj4gZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKnJlcXVlc3QKPj4gICAgICAgICAgICAq IGdvaW5nIGFueSBmdXJ0aGVyLCBhcyB0aGUgaTkxNV9hZGRfcmVxdWVzdCgpIGNhbGwKPj4gICAg ICAgICAgICAqIGxhdGVyIG9uIG11c3RuJ3QgZmFpbCAuLi4KPj4gICAgICAgICAgICAqLwo+PiAt ICAgICAgICByZXQgPSBpOTE1X2d1Y193cV9jaGVja19zcGFjZShyZXF1ZXN0KTsKPj4gKyAgICAg ICAgcmV0ID0gaTkxNV9ndWNfd3FfcmVzZXJ2ZShyZXF1ZXN0KTsKPj4gICAgICAgICAgIGlmIChy ZXQpCj4+ICAgICAgICAgICAgICAgcmV0dXJuIHJldDsKPj4gICAgICAgfQo+Cj4gTmFtZSBjaGFu Z2VzIG1ha2Ugc2Vuc2UuIEp1c3QgdGhlIFBBR0VfQUxJR04gcXVlc3Rpb24gYWJvdmUuCj4KPiBS ZWdhcmRzLAo+Cj4gVHZydGtvCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9p bnRlbC1nZngK