Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A900C43219 for ; Sun, 28 Apr 2019 20:54:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3582F20679 for ; Sun, 28 Apr 2019 20:54:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="arRbFOl/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726416AbfD1UyL (ORCPT ); Sun, 28 Apr 2019 16:54:11 -0400 Received: from mail-pf1-f193.google.com ([209.85.210.193]:38263 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725982AbfD1UyL (ORCPT ); Sun, 28 Apr 2019 16:54:11 -0400 Received: by mail-pf1-f193.google.com with SMTP id 10so4315168pfo.5 for ; Sun, 28 Apr 2019 13:54:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Ezcc5HcyBqdVKCGP+C4RyFMXy0sWYJgSqW41D1fMfLc=; b=arRbFOl/eLbVDAnldIy5o4zliZE62Yv9r1vGMWuDbHCRhxazcXbreKEI1N6e5FBdGV YTnHO2ArUgEMcs/fTGfLlhtcrLeO2cPCwr85jhWKx4UpYuKWmf3J4Akdt1HpyhouNEtM TJaxMVyFw7v8IKfJ0lXDiIyNc0KTS3pn8h6oKur4G32f5Wy3uiOQ94fday+mfDwLyFrF nST8TQewXk33AxmLDoGsFSHGpTRA3FctoijPPi71jK6jHj14eOtUMfdI5E1ytF+NA+c0 kokQA9M7pgJN0jm8TNkAtlbyipx0T81l1Gk8iqwKSMX3ydqvhdrS5HkhA0ZAKnvooXQs RVJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Ezcc5HcyBqdVKCGP+C4RyFMXy0sWYJgSqW41D1fMfLc=; b=TUME8g10jPmBP1OOwWrEGvAx0JbrI7Iq6kkEQzG5uNrxB/iTawSPp/yrCbuzION8bX uUnsG6mZOCWDrngljF++aZDdk+2lT1yHpdS8ijoNAHnoar2kFogoIV0jTD7VaKdzKa/h 1AyXnq1cYsLbIe7fLmTjIrlrq/G/4cdchdKgBqXccLVV+5y8pm9d8JuBgFcmclzHRdB+ Fgy6QVF+9rolqPftEhDNWoaFte6slRmUiHoio6NMyqwZEb2li6+SoSclP0XH+zfKocBw FvHcaxLIEBNteWbEtSecIa58pAlHXUm2/bnD9t1ytgjZHJkr4cUpGHogMQXbTviozVLI XCMg== X-Gm-Message-State: APjAAAW36U91MAaoTBEyNbJlLKcQ5EJaCO0HbI003ThhUvTWrrqxpm/3 jU4oa15tM/U1hGxQoGU1u1M= X-Google-Smtp-Source: APXvYqyyWUceUCJt+PuymOD+9zrtrZxRlEXN4jTWpB6tXD8IeUhgVXu+wh9UaAzQcppARfjEmC2KlA== X-Received: by 2002:a63:ed10:: with SMTP id d16mr38383713pgi.75.1556484851108; Sun, 28 Apr 2019 13:54:11 -0700 (PDT) Received: from ?IPv6:2601:282:800:fd80:9941:e792:9d93:10f8? ([2601:282:800:fd80:9941:e792:9d93:10f8]) by smtp.googlemail.com with ESMTPSA id k68sm3927204pfb.146.2019.04.28.13.54.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 28 Apr 2019 13:54:10 -0700 (PDT) Subject: Re: [PATCH v2 net-next 0/7] ipv4 ipv6: Move location of pcpu route cache and exceptions To: Alexei Starovoitov , Eric Dumazet Cc: David Ahern , "David S. Miller" , Network Development , Ido Schimmel References: <20190428022734.21965-1-dsahern@kernel.org> <5db90ce0-d24a-4317-5d68-5169d496609a@gmail.com> From: David Ahern Message-ID: <357bf152-c693-d1b8-ce9b-710730682ea8@gmail.com> Date: Sun, 28 Apr 2019 14:54:08 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 4/28/19 11:53 AM, Alexei Starovoitov wrote: > Adding tests as we go along would immensely help too. > Unfortunately afaik there is no test infra to use for it. pcpu routes are the predominant ones used for traffic. We have a number of existing tests in selftests - fib_tests.sh - that exercise the code paths touched by this set. That includes their entire life cycle - from FIB entry create, to running traffic or 'ip route get' to cleanup. For the exception code paths selftests has pmtu.sh which covers creation of entries, updates and deletes. Both of those cover IPv4 and IPv6. I have a vrf test suite which covers functional tests under a lot of permutations (ie., sysctls, APIs, remote traffic, local traffic, negative tests, ...) as well as some runtime tests (e.g., active and passive socket with device kills). All of these are run using namespaces which are created and destroyed 100's of times during a run which covers cleanup of resources (eg, netdev refcnts). While the tests were started for VRF they cover non-VRF tests too as 1 namespace uses VRF and other does not. I run this suite with a performance focused kernel config and one with rculock debugging and kmemleak enabled. I am currently re-working the script into something suitable for selftests. I might get it out this dev cycle, if not the beginning of the next. I am also reworking a lot of the above to handle nexthop objects in addition to its own standalone set of functional tests.