Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7EFDCC00140 for ; Tue, 9 Aug 2022 03:27:18 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9A71F848CA; Tue, 9 Aug 2022 05:27:15 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="P2nGAE0X"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9383684980; Tue, 9 Aug 2022 05:27:14 +0200 (CEST) Received: from mail-qv1-xf2e.google.com (mail-qv1-xf2e.google.com [IPv6:2607:f8b0:4864:20::f2e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id DF993845F0 for ; Tue, 9 Aug 2022 05:27:11 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=f.fainelli@gmail.com Received: by mail-qv1-xf2e.google.com with SMTP id mk9so7708913qvb.11 for ; Mon, 08 Aug 2022 20:27:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=jzLf5fDyIVV4hwKb/Nh1O2WCCa1TSE4c8M18HS8yMRk=; b=P2nGAE0XrKEdBHcYS7ih1iqwJ+0Gn0PBs1nxiYExJlUI0mAtLT2w8PtzIdQjP4l0S0 LXdB0u/LgMrw3nUrLKn3w6uJn4+FuvkaT+aq1+k6ZpzrHzmEk3g+41Hb0codgcravk0o unpUvC7A5yYzqDCa251voKtCZg3NfQmpHc/AdzRIMXjGFygnBT5qCtvMS3SxFNd9xJjz H6ftbpbkjxosOglbl0Nhrh1mwVZUAIkPcC1aG5Y97O7I03/apE/47xuBDqySSqurnRaN 14nlgTBiUC/7czu0/0uojJ1K7D4pnQTW03BI38SJPB7RmKuwgqrIhXIgUFuPNU/4kiwO UaFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=jzLf5fDyIVV4hwKb/Nh1O2WCCa1TSE4c8M18HS8yMRk=; b=GDZfMe6FYp56i1l+x09yGyA5mGDPuV9PPDe6ua7sk1/sVemlEB2sJpei1230jX/kNF +1mXT4b+oTrBmcr635YhxIViWNsMnjoeWPncP6HaiSC+FJ2yN11n14EvysURtjCJu/ya AzzvgF4GXfOoF/8oR7P6gI4g8FoUlAmI0bjNBvE3J6EJ6//wKPYXdIwFRaEwHgBTtfhB kSj+JPwL9AaKUMFQ8F11NwwgTNRcKqTjqAxXfZQOoTeoAnGgpUEGdKdS8pijvX/ER2aK etwxiwy5IuIJquuWFmL86pYLxnGrU+/ZTaD3/rBEmMKaNk8lnk5OxvhAtvVzvx3EDwWz UVMg== X-Gm-Message-State: ACgBeo0lv2irUmHYerpVwUsgvldqju9eQ/xvP6btTm4+/D7zWPa4ltpD I59rf/f2s/GyslhrFztd9+0= X-Google-Smtp-Source: AA6agR6dJL5R/krp7L5lzUE0Vu7XmFYg0ga7n2QtL2JO6OkyjYyO1wc8JuozvRZFuBA6jqQlwuSdMQ== X-Received: by 2002:a05:6214:2388:b0:47b:53e5:7dc2 with SMTP id fw8-20020a056214238800b0047b53e57dc2mr5361462qvb.66.1660015630677; Mon, 08 Aug 2022 20:27:10 -0700 (PDT) Received: from [192.168.1.3] (ip72-194-116-95.oc.oc.cox.net. [72.194.116.95]) by smtp.gmail.com with ESMTPSA id w13-20020ac843cd000000b00342f844e30fsm3494148qtn.31.2022.08.08.20.27.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Aug 2022 20:27:10 -0700 (PDT) Message-ID: <3588c56d-8af6-b7ed-3eee-cdd0a883e56b@gmail.com> Date: Mon, 8 Aug 2022 20:27:07 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.1.1 Subject: Re: [PATCH 3/4] arm: bcmbca: add bcm6813 SoC support Content-Language: en-US To: William Zhang , U-Boot Mailing List Cc: kursad.oney@broadcom.com, dan.beygelman@broadcom.com, joel.peshkin@broadcom.com, philippe.reynes@softathome.com, rafal@milecki.pl, anand.gore@broadcom.com, Andre Przywara , Christian Hewitt , Fabio Estevam , Marek Vasut , Samuel Holland , Simon Glass , Tom Rini , Tomer Yacoby , "Ying-Chun Liu (PaulLiu)" References: <20220806013403.1344-1-william.zhang@broadcom.com> <20220805183208.3.Ied4f916adc644f754f8c78e574b6295cec250d52@changeid> From: Florian Fainelli In-Reply-To: <20220805183208.3.Ied4f916adc644f754f8c78e574b6295cec250d52@changeid> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 8/5/2022 6:34 PM, William Zhang wrote: > BCM6813 is a Broadcom B53 based PON and WLAN AP router SoC. It is part > of the BCA (Broadband Carrier Access origin) chipset family so it's > added under ARCH_BCMBCA platform. This initial support includes a > bare-bone implementation and dts with CPU subsystem, memory and ARM > PL011 uart. > > This SoC is supported in the linux-next git repository so the dts and > dtsi files are copied from linux. > > The u-boot image can be loaded from flash or network to the entry point > address in the memory and boot from there to the console. > > Signed-off-by: William Zhang > --- > > MAINTAINERS | 1 + > arch/arm/dts/Makefile | 2 + > arch/arm/dts/bcm6813.dtsi | 128 +++++++++++++++++++++++ > arch/arm/dts/bcm96813.dts | 30 ++++++ > arch/arm/mach-bcmbca/Kconfig | 8 ++ > arch/arm/mach-bcmbca/Makefile | 1 + > arch/arm/mach-bcmbca/bcm6813/Kconfig | 17 +++ > arch/arm/mach-bcmbca/bcm6813/Makefile | 5 + > arch/arm/mach-bcmbca/bcm6813/mmu_table.c | 32 ++++++ OK, so after seeing the same mmu_table.c 4 times, maybe we could share a common implementation that is configurable enough, even if there may not be any need for configuration other than the DRAM size. Reviewed-by: Florian Fainelli -- Florian