Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBE44C001B0 for ; Tue, 15 Aug 2023 15:42:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 204318D000F; Tue, 15 Aug 2023 11:42:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1B44B8D0001; Tue, 15 Aug 2023 11:42:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 07C488D000F; Tue, 15 Aug 2023 11:42:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id EE2498D0001 for ; Tue, 15 Aug 2023 11:42:00 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id ACF7CC0534 for ; Tue, 15 Aug 2023 15:42:00 +0000 (UTC) X-FDA: 81126754800.03.E270D9E Received: from mail-yw1-f178.google.com (mail-yw1-f178.google.com [209.85.128.178]) by imf07.hostedemail.com (Postfix) with ESMTP id BB34440005 for ; Tue, 15 Aug 2023 15:41:58 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b="v/t1rSu7"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf07.hostedemail.com: domain of hughd@google.com designates 209.85.128.178 as permitted sender) smtp.mailfrom=hughd@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692114118; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=P7TsLh4UpmerFxSf2LHp//sOCj39QtIaP8NhFu7Ity0=; b=4qdlyGs9O3skLSNpHSh+7Tw7Zln/Uten5oFFUsDSZ2hVJhAzfLVj0jwlHiF8fePJq1XD/w KSeqUh/DhGTjqPWYCAN/v54/enCXXk+RpgU2bTXToXnXKcLE5BZxUZCa7L6CVAy800TAYc 3UI6LP/PgRTYFmWx/Xq1dKTQf7oimRU= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b="v/t1rSu7"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf07.hostedemail.com: domain of hughd@google.com designates 209.85.128.178 as permitted sender) smtp.mailfrom=hughd@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692114118; a=rsa-sha256; cv=none; b=ZEPcgR9CDjP37Bzatu60v0POzslw/QunIUhfNt25R9sr8KjfSZtbmoyV03/86VZM3pilja ogZTwI33SO9lKHo/hMCByyetvkUXn16MZLRZxbB+PZZoDOBDZvrGSulVRbDOhEX/RtrIP+ A6RmtMbjMhm4ZHNS4T5zqBf+fNP28NU= Received: by mail-yw1-f178.google.com with SMTP id 00721157ae682-586a3159588so78107997b3.0 for ; Tue, 15 Aug 2023 08:41:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1692114118; x=1692718918; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=P7TsLh4UpmerFxSf2LHp//sOCj39QtIaP8NhFu7Ity0=; b=v/t1rSu7IOqD7zsEvHxRPZ8PsCIFzAnrAyhA1GeAnqzR3gqcLYYTCisHr6LsT22vfP 4laXof+eVPcmpLgSaUurUglySIUk5wTKrOXJIVrfFuzCfybCzb0/0AVfQMVJ0iJIRG4H 0geKl/MMV99hPY+b1UkztXinVcOvwL2sVflQuURKZUXygILqXy0hylwT5O5AGgmvPpyb srYr1if/5tuZjeqAnbfWF3gwfEMlVFJI+jpZVbFzcg3JYBWEdRGg/oIVxBn0/AdWjomv dLXCkhljXHfLN7Qp8CgGrb1wPb2fkkHuSPRQ+VOFXR8Uhg34HjYmVoNDAYs3GRvk+rOp M2IA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692114118; x=1692718918; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=P7TsLh4UpmerFxSf2LHp//sOCj39QtIaP8NhFu7Ity0=; b=NHtXAJ7w/8usbHd//9GpGQ17Z529YEmSMvNquS+h5vQNBfvh98+IY0ka7jN8ISeAEj wd2fqCTvdPTogMlxaCOBs1qEzHg5StWIfr1lUxJvXP2r/4pRes67Bv/ti+tqOr+k4wpy 1NssJGsBf+QuvTqef6efUc35wRxhFJobPZ4qCfZK5DaUYCR+OQNntNTZq3NO2bJsvmm2 ea4nGt0v9kFGYXFQZHA+rf73gbu75quYhPXQ8v0tP45l+2ZcFmfknyPART8uewqOuU+h fbIGBVzWdgaJF1OsEBk2JRoiSAsPhIRObOccIxCdiumC1pQ6CvhJCF4Q0t1peMN2KK+N cIig== X-Gm-Message-State: AOJu0YyTjSb97mNDKgabLvZ1hQhzNFyQB3NcFNEVdyIzcYzGlSM7bbje p8yoHLiJFcw5mJy+UR5LeNd2TA== X-Google-Smtp-Source: AGHT+IFym1gqMNFckrS6y/rCULvNhW2b/lORvGgm0DCRSg/pwTXV+un25GqW0LvhUjQm8jbcdgknTw== X-Received: by 2002:a0d:cc92:0:b0:589:a4c7:ee40 with SMTP id o140-20020a0dcc92000000b00589a4c7ee40mr2727997ywd.2.1692114117698; Tue, 15 Aug 2023 08:41:57 -0700 (PDT) Received: from ripple.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id x206-20020a814ad7000000b005707fb5110bsm3475226ywa.58.2023.08.15.08.41.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Aug 2023 08:41:57 -0700 (PDT) Date: Tue, 15 Aug 2023 08:41:45 -0700 (PDT) From: Hugh Dickins X-X-Sender: hugh@ripple.attlocal.net To: David Hildenbrand cc: Hugh Dickins , Jann Horn , Andrew Morton , Mike Kravetz , Mike Rapoport , "Kirill A. Shutemov" , Matthew Wilcox , Suren Baghdasaryan , Qi Zheng , Yang Shi , Mel Gorman , Peter Xu , Peter Zijlstra , Will Deacon , Yu Zhao , Alistair Popple , Ralph Campbell , Ira Weiny , Steven Price , SeongJae Park , Lorenzo Stoakes , Huang Ying , Naoya Horiguchi , Christophe Leroy , Zack Rusin , Jason Gunthorpe , Axel Rasmussen , Anshuman Khandual , Pasha Tatashin , Miaohe Lin , Minchan Kim , Christoph Hellwig , Song Liu , Thomas Hellstrom , Russell King , "David S. Miller" , Michael Ellerman , "Aneesh Kumar K.V" , Heiko Carstens , Christian Borntraeger , Claudio Imbrenda , Alexander Gordeev , Gerald Schaefer , Vasily Gorbik , Vishal Moola , Vlastimil Babka , Zi Yan , Linux ARM , sparclinux@vger.kernel.org, linuxppc-dev , linux-s390 , kernel list , Linux-MM Subject: Re: [BUG] Re: [PATCH v3 10/13] mm/khugepaged: collapse_pte_mapped_thp() with mmap_read_lock() In-Reply-To: <76e6b2ad-4e1e-2ad3-95df-00b4d33ec9d2@redhat.com> Message-ID: <35d52c74-9ba9-211e-a4f-ade6ed318e76@google.com> References: <7cd843a9-aa80-14f-5eb2-33427363c20@google.com> <76e6b2ad-4e1e-2ad3-95df-00b4d33ec9d2@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: BB34440005 X-Stat-Signature: kr6f54g9z19xeukhjm518m6x5g48kpw9 X-Rspam-User: X-HE-Tag: 1692114118-854503 X-HE-Meta: U2FsdGVkX19i2BbyL3rutrcy3wlVrJqYZutyTmYJZKD9Hbe22kpzPV7aYNTrsaLwrHYbAMfwjZ5RAoQTOcJjuzNMslJvCpTW+/QwCZXfExhodw0do6oI4B3KyAsbcEiYXdjhG3hZrQxJo25zLMLojN72LG4ueEc7wOUm49e9I7kiktpPgLvsrZBpxtk0iGG3nLIKiGmGcxbUywlKYbPYaYT+mYT+X6VgK/0L3fF+kcMHJVFl+GJUXlTqGR84j4V0/y7pnXs9RFlfjiKDJB5fvnyjcF10vvkdDFvrjU/Pq6iOI8yDBSjA5O4Lo5HdfWFPyT0cj3IbDO7MfyG2aCQkepN3qUCm3lezzJID0n1auptqzHhFY98P/vgkoKIXngFPYrmREjNoXcI8RmDlFMx2ADOgWhSH9Fu90NSuDfFY89yxs38JzOvcMUvmymawZnx8VQnEuKGUVqC9pNPUNp7lMm9KCUmM1BLEExUKzTlLA0ittngdwWU3hMHqaeImz/Ygdm56m//ANeQhNA3JdsjVN6t8XKGwZu6x3ic3J9WGZZDXrXrWLYNJwHsIwPB56soNbtMARxQjPzTeOzIO08sGQCE8t7YdX3ECd4R7yHGF4Lt7cc8Q+NGBCu4QoEkOSTV0bFEnve5NighS1nH/sQslfdJTI/fFZZrTPcMFvSmPc7vRk5KbduoYbRuVYlfVNxvan6IHYpLQW06wyC56hu5VOYDlXtB4WVs9IBlWz43RYAdNe3Memx72PElc3EEtSwO+bUIxBsumcCqu1/9g7ec/aHADWAd+Qpg5hgz4Ak+MD1YXKbhH484OQfPwM3ZvC06D3OutxowO7P8zXq9L0UsRvdDwXIh8YnGxN74hqayUuCS5q4zKzADOEWOmvt9Guh4VtHxjtVyUq3w/C7bdzAMp7NfkxBhphJor6+2x4Rc3owXuVPoEcWpsb0IjFWJVaycMc4NLP9GVq4aAdgNL25t 0tC7Yh9+ cdyuNXMGaa6kaahWpu0G0yTIJAeRkwXqvSYuYu6KMl0EhJI4hjnrS9USCSypkV9pveJHWrw5YS/l/X7sZZ+kziozTJYkbydNv0sjM1ljJuG6SPB4BS4XNMS8YT/ZDcIGMOzDRXps6HHlXPus1mMAHxSdDtVTNSzAMbmjxRpcSyyLO3GHZon0V3UFc6uyACS0BPv8TqK6kxRRbJ/zv8GXI8spuhV711OuM+WJhF3f+buPtj7wlkdvDm0T6KV3XD9J88r5Zi7Xntiot/phpFsicBIuw4OPQ5EasuNTQFPhIzvw1CA8fV4e5JFyZLyOz8DVCZzIn0hDcGv/cOV8PZwkzIWmKK8pvxquckptJyuBEi7A/1VsxNFA/5wUNr9g8naLjvwCLpnXHi7pf5BqXxXfgH5IIjAQwdP4udmspK78SBVj9ZLUdZjAj6Ysj9CxysQHIJfZIrH5N6Y8cml14B355qLXtZXU7gFK+Ro/qpboNNuahJ9nUEMR6jOHVNVlgH5YnfmA8ykJ7oRI/jP7c3p3b2Dj3GVHhoRrdPSoiTZRIwK04YmpyA0TfR5dPLg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 15 Aug 2023, David Hildenbrand wrote: > On 15.08.23 08:34, Hugh Dickins wrote: > > On Mon, 14 Aug 2023, Jann Horn wrote: > >> > >> /* step 4: remove page table */ > >> + if (strcmp(current->comm, "DELAYME") == 0) { > >> + pr_warn("%s: BEGIN DELAY INJECTION\n", __func__); > >> + mdelay(5000); > >> + pr_warn("%s: END DELAY INJECTION\n", __func__); > >> + } > >> > >> /* Huge page lock is still held, so page table must remain empty > >> */ > >> pml = pmd_lock(mm, pmd); > >> > >> > >> And then run the attached reproducer against mm/mm-everything. You > >> should get this in dmesg: > >> > >> [ 206.578096] BUG: Bad rss-counter state mm:000000000942ebea > >> type:MM_ANONPAGES val:1 > > > > Thanks a lot, Jann. I haven't thought about it at all yet; and just > > tried to reproduce, but haven't yet got the "BUG: Bad rss-counter": > > just see "Invalid argument" on the UFFDIO_COPY ioctl. > > Will investigate tomorrow. > > Maybe you're missing a fixup: > > https://lkml.kernel.org/r/20230810192128.1855570-1-axelrasmussen@google.com > > When the src address is not page aligned, UFFDIO_COPY in mm-unstable would > erroneously fail. You got it, many thanks David: I had assumed that my next-20230808 tree would be up-to-date enough, but it wasn't. Reproduced now. Hugh