Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1kX4K7-0005ru-VU for mharc-qemu-trivial@gnu.org; Mon, 26 Oct 2020 11:22:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38286) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kX4K6-0005ow-5m for qemu-trivial@nongnu.org; Mon, 26 Oct 2020 11:22:14 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:42475) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kX4K3-00078N-SX for qemu-trivial@nongnu.org; Mon, 26 Oct 2020 11:22:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603725730; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=W0tIkUgGZjhQcfEolhVA9FgVQGoAdQAnzjG+9hFhz2s=; b=M+c/bV/Nyy3r6qs2Q8XouAjJswaiUN/DNU68bR5FdKzLBZvYrrc5gTdmaLfj4y5jtsMtNn yNDGBScyVJezI7XS3xLgWitbSYddxZMU2UWRPAG9TfsXF0cdgbR3i0NsvzmL58QbqGetev +3CL89WGvypd2L8mfikEYB3i4yX11Fs= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-271-hvbR2lNDOmO89bLpeV8g6g-1; Mon, 26 Oct 2020 11:22:05 -0400 X-MC-Unique: hvbR2lNDOmO89bLpeV8g6g-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4996818CBC47; Mon, 26 Oct 2020 15:22:03 +0000 (UTC) Received: from [10.10.120.57] (ovpn-120-57.rdu2.redhat.com [10.10.120.57]) by smtp.corp.redhat.com (Postfix) with ESMTP id 410947D4E6; Mon, 26 Oct 2020 15:22:00 +0000 (UTC) Subject: Re: [PATCH] CHANGELOG: remove disused file To: Thomas Huth , qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, pbonzini@redhat.com, Eric Blake References: <20201022162843.1841780-1-jsnow@redhat.com> <576a881d-2c64-3e40-31b7-43680a1988f8@redhat.com> <22839fc4-a1b9-0510-ff19-3a713fd8a187@redhat.com> <88ac9998-51fb-0cca-8b7a-a2204ee0f9b2@redhat.com> From: John Snow Message-ID: <35df91c4-49e5-bc9e-e153-a27b7f443ffd@redhat.com> Date: Mon, 26 Oct 2020 11:21:59 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <88ac9998-51fb-0cca-8b7a-a2204ee0f9b2@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jsnow@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/26 02:39:09 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-2.167, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Oct 2020 15:22:14 -0000 On 10/23/20 2:51 PM, Thomas Huth wrote: > On 23/10/2020 18.34, John Snow wrote: >> On 10/23/20 1:43 AM, Thomas Huth wrote: >>> On 22/10/2020 18.28, John Snow wrote: >>>> There's no reason to keep this here; the versions described are >>>> ancient. Everything here is still mirrored on >>>> https://wiki.qemu.org/ChangeLog/old if anyone is curious; otherwise, use >>>> the git history. >>>> >>>> Signed-off-by: John Snow >>>> --- >>>>   Changelog | 580 ------------------------------------------------------ >>>>   1 file changed, 580 deletions(-) >>>>   delete mode 100644 Changelog >>>> >>>> diff --git a/Changelog b/Changelog >>>> deleted file mode 100644 >>>> index f7e178ccc01..00000000000 >>>> --- a/Changelog >>>> +++ /dev/null >>>> @@ -1,580 +0,0 @@ >>>> -This file documents changes for QEMU releases 0.12 and earlier. >>>> -For changelog information for later releases, see >>>> -https://wiki.qemu.org/ChangeLog or look at the git history for >>>> -more detailed information. >>> >>> I agree with removing the old log. But should we maybe leave a pointer to >>> https://wiki.qemu.org/ChangeLog / the git history here to let people know >>> how to see the changelogs? >>> >>>   Thomas >>> >> >> Maybe in README.rst, just below "Bug Reporting" and above "Contact" ? >> >> >> Changelog >> ========= >> >> For version history and release notes, please visit >> ``_ or look at the git history for more >> detailed information. > > Ok, but IIRC the "ChangeLog" file is a standard file in GNU coding > conventions, so it might be worth to keep the information in this file ... > of course we are not bound to the GNU conventions in QEMU, but users still > might expect to find the information in here... > > Thomas > My point in removing it is just getting rid of the runaround. If we don't have the changelog information in CHANGELOG, why have the file and pretend like we do? Moving it into README.rst makes it visible on github and gitlab to people stopping by for the first time. --js