Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 32AADC6FD1F for ; Tue, 2 Apr 2024 15:47:05 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.700209.1092976 (Exim 4.92) (envelope-from ) id 1rrgLe-0005qd-Tk; Tue, 02 Apr 2024 15:46:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 700209.1092976; Tue, 02 Apr 2024 15:46:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rrgLe-0005qW-R6; Tue, 02 Apr 2024 15:46:54 +0000 Received: by outflank-mailman (input) for mailman id 700209; Tue, 02 Apr 2024 15:46:53 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rrgLd-0005qP-3D for xen-devel@lists.xenproject.org; Tue, 02 Apr 2024 15:46:53 +0000 Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [2a00:1450:4864:20::32b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3950fd7a-f108-11ee-afe5-a90da7624cb6; Tue, 02 Apr 2024 17:46:52 +0200 (CEST) Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-415523d9824so34582285e9.3 for ; Tue, 02 Apr 2024 08:46:52 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id g18-20020a05600c4ed200b0041495d17992sm18348202wmq.34.2024.04.02.08.46.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Apr 2024 08:46:51 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3950fd7a-f108-11ee-afe5-a90da7624cb6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1712072811; x=1712677611; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Hb9FHbLzj93PJKPlOi0wLq8nP32v+TwHZABSP2UcDcM=; b=EryP2KZtTr4Yi0PRs1HcxK7yqRmwheyZBXqVE+5ZTHWuT983E4+4Do7qmftLVhcERU 0KFScqLyZ96xMikluAYVrAO8bzCdqFniTmS3HL0hpMdO+A8yRRplcMwbmjVmea4MtI7S 2H0YxGCYvGvbpu/+yFKdDXGZWR5Y9QLLBtTw5vSGouHvSBwf96w/N8rrACnIsPO01CSO quh9V3KVTG0pKob+87XmUScAz8LXlGlfp1hwr38UX8eCdlSj9dBSzQP9L4nMyWEFGTBz nU0L0dKmcNimv17UvKCwSxN+vlNUDk+numlSnvVO0sAuFoV/7J8oZqezhvDQaJqSVIcC KkXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712072811; x=1712677611; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Hb9FHbLzj93PJKPlOi0wLq8nP32v+TwHZABSP2UcDcM=; b=sf8OG+i1iCReSR+9Im4zaDXP2Wm7kEgm6/c3DBBX2J7OnCpcnQRymo7eyDvmJ/TVYP Ly4W8yXekhW7WSEnhatMd5D+2wZB5bZMIrl8EGbmab4Zlz2iFwjkQiofLqPT+ctWbZyk 2CdfbqLDq0xbBQJFbK8eEfRqHL6xKRqODFGQqdQHdw2W4nUESJaEm+mGkdaTqImAvVkb o8BL2p+da7jfJ+bKD6a4gXfebCyGhElc8ti8PbW0iuYX8R5C9uiCK9Qayglk1qwMPkcz kVa0XVUfW6d8xoXlH6ACO5UIGwQd+6IfYYvTFx/q4oI5cd1cOoLrmETlQLGV6yRPxES4 QzbQ== X-Forwarded-Encrypted: i=1; AJvYcCX7KMyMTQKoimKSZKgi3Bv514oR3H7TQZFda5qENvIM6pgSJE6h/Qbuy2lfHjoipc8yz/7Kf+IHUOLn4cYM6jy19V7cd0g5VKbfkBApJZU= X-Gm-Message-State: AOJu0YylybbBN9T9b+NHDJSyABTZyXEdhbHWNU9hA0KDqS5QAlxAVOWA LA18gmul+A1SII0i39tIjYqH5xiABV5Ton0S4NhQY2GWnAP/XwiDQJr1d0VD3w== X-Google-Smtp-Source: AGHT+IHKaT3BbnN2Ai17O3v5VOdwD5zrqjjJD+uo6OAZfnl6nTewrIAtL+mAxMXUt4kgk0qtZljHLw== X-Received: by 2002:a05:600c:230f:b0:413:ee4a:c9a7 with SMTP id 15-20020a05600c230f00b00413ee4ac9a7mr2019512wmo.20.1712072811490; Tue, 02 Apr 2024 08:46:51 -0700 (PDT) Message-ID: <35fc596e-8134-4471-83d4-40b01f5821bf@suse.com> Date: Tue, 2 Apr 2024 17:46:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] x86: Address MISRA Rule 13.6 Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini , Roberto Bagnara , "consulting @ bugseng . com" , Xen-devel References: <20240402154339.2448435-1-andrew.cooper3@citrix.com> From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <20240402154339.2448435-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 02.04.2024 17:43, Andrew Cooper wrote: > MISRA Rule 13.6 doesn't like having an expression in a sizeof() which > potentially has side effects. > > Address several violations by pulling the expression out into a local > variable. > > No functional change. > > Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich with one caveat: > --- a/xen/arch/x86/irq.c > +++ b/xen/arch/x86/irq.c > @@ -1150,8 +1150,9 @@ static void cf_check irq_guest_eoi_timer_fn(void *data) > { > struct domain *d = action->guest[i]; > unsigned int pirq = domain_irq_to_pirq(d, irq); > + struct pirq *pirq_info = pirq_info(d, pirq); Misra won't like the var's name matching the macro's. Can we go with just "info"? Jan