From: David Howells Date: Wed, 13 May 2020 23:16:12 +0000 Subject: Re: [PATCH] keys: Make the KEY_NEED_* perms an enum rather than a mask Message-Id: <3611715.1589411772@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit List-Id: References: <158932282880.2885325.2688622278854566047.stgit@warthog.procyon.org.uk> In-Reply-To: To: Paul Moore Cc: dhowells@redhat.com, Stephen Smalley , Jarkko Sakkinen , Casey Schaufler , keyrings@vger.kernel.org, selinux@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Paul Moore wrote: > > + case KEY_NEED_VIEW: perm = KEY__VIEW; break; > > + case KEY_NEED_READ: perm = KEY__READ; break; > > + case KEY_NEED_WRITE: perm = KEY__WRITE; break; > > + case KEY_NEED_SEARCH: perm = KEY__SEARCH; break; > > + case KEY_NEED_LINK: perm = KEY__LINK; break; > > + case KEY_NEED_SETATTR: perm = KEY__SETATTR; break; > > Please don't put the case statements all on one line, use the more > traditional multi-line format. For example: > > case KEY_NEED_SETATTR: > perm = KEY__SETATTR; > break; Tabulation was invented something like 6000 years ago for just this kind of purpose;-) It's less readable your way, but whatever... David