From: "d12fk (Code Review)"
Date: Wed, 9 Jul 2025 12:44:36 +0000
In-Reply-To:
References:
Reply-To: heiko@...515..., arne-openvpn@...1227...,
openvpn-devel@lists.sourceforge.net, frank@...2641...
Message-ID: <3659ea8c7de6880fce9f10cafac3d5299097f424-EmailReviewComments-HTML@...2715...>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="S6mkpzI0nOQ="; charset=UTF-8
Subject: [Openvpn-devel] [M] Change in openvpn[master]: move macOS
dns-updown common code into functions
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Cc: flichtenheld , plaisthos , openvpn-devel
--S6mkpzI0nOQ=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: flichtenheld, plaisthos.
d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/ope=
nvpn/+/1074?usp=3Demail )
Change subject: move macOS dns-updown common code into functions
......................................................................
Patch Set 3:
(1 comment)
File distro/dns-scripts/macos-dns-updown.sh:
http://gerrit.openvpn.net/c/openvpn/+/1074/comment/aa674cbb_a590cc31 :
PS3, Line 242: local addresses=3D"$(addresses_string $n)"
> addresses seems to be unused?
Yeah, it will get used in #1075, slipped through. Think it's no biggie, as =
both will be applied anyway.
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1074?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Id6f70237c7205063b001528a40391678b0d093ac
Gerrit-Change-Number: 1074
Gerrit-PatchSet: 3
Gerrit-Owner: d12fk
Gerrit-Reviewer: flichtenheld
Gerrit-Reviewer: plaisthos
Gerrit-CC: openvpn-devel
Gerrit-Attention: plaisthos
Gerrit-Attention: flichtenheld
Gerrit-Comment-Date: Wed, 09 Jul 2025 12:44:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld
Gerrit-MessageType: comment
--S6mkpzI0nOQ=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: flichtenheld, plaisthos.
View =
Change
1 comment:
Yeah, it will get used in #1075, slipped through=
. Think it's no biggie, as both will be applied anyway.
=
li>To view, visit change 1074. To unsubscribe, or for help writing mail=
filters, visit settings=
.
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Id6f70237c7205063b001528a403=
91678b0d093ac
Gerrit-Change-Number: 1074
Gerrit-PatchSet: 3
Gerrit-Owner: d12fk <heiko@...515...> =
div>
Gerrit-Reviewer: flichtenheld <frank@...2716...=
1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...=
.1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...=
ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...=
..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...=
41...>
Gerrit-Comment-Date: Wed, 09 Jul 2025 12:44:36=
+0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld <frank@...1186...=
.2641...>
Gerrit-MessageType: comment
--S6mkpzI0nOQ=--