Received: by 2002:a05:6512:204:0:0:0:0 with SMTP id a4csp13939lfo; Sat, 5 Mar 2022 01:28:35 -0800 (PST) X-Google-Smtp-Source: ABdhPJz6Naqrz0WP4YebaNAVzTnc6g9mNjvgocJMIrJb1ICiO/qxSI67AotovDP2kUB2pbYOCt2F X-Received: by 2002:a37:4c3:0:b0:649:714a:54b5 with SMTP id 186-20020a3704c3000000b00649714a54b5mr1524302qke.386.1646472515385; Sat, 05 Mar 2022 01:28:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646472515; cv=none; d=google.com; s=arc-20160816; b=sNFgci872rIePW0djUSZg2kHpReyk7DcafdR8rgVGcuKHnVkBJON/g2soO+V2eUBL4 kTf75u7btixvdyOV/PX1RkboHkdZ9J5Lve/p38ClQzqFsqiwrIhTZLIW1VRptlhMJ6p1 wK4YUVuVzPiZ6qMVixkLdQTF912u6zXk+gobeJSx/EXzINCp20RgPSwEnNn+Clg6O2X9 0rVnrpT50eivVtokoMTzHQy6c7lp2r9Kg0/5L6/KKG0W6yx7RRIl+vCZMfYvlGZIUhv/ SObWpRKLkBhDIB60wGsAepa0SntICAGkNKaTJjA/ak2jGV/MtuNyLfJ/xj2HPOUPLkQN qnow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:to:subject:dkim-signature; bh=5v+lxzzzYjXAWwcj6FNe/edp16R/z7uYzjkD8sfpFjQ=; b=XK/NGCd0DoUj3UgWC1wfvGF06+1UxwqeMNaGc95A4aGiX7sJvpFJwjzXS4qPhZItwg mGoEFqPMh2jsGpfIakez7Mg2KkEhiFhc4ZUKmg2X2yxc80NY3FbB0o/tDJ0jQ/GckMR2 LmrIbz2fZd/uasdj4EB72ES9LdlxBeEp9ycCuC9ivEl1HsJISxJAoG9SaUHKKE0j/b0V AqTz6iBILMv0W+YgXCdAsLjr4E/pst5oXVNHc4Vx2v6TzPBl87RnFNYwlBWblKX7v4US MkklADP6h3Cd9Go1Rhna2tKQ1jXsa4wCSkn7t6zasmwgfZAURd8tw5QBMJX2yq1IThfP WMKw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b=Bm7w2vWy; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id i188-20020a3754c5000000b00648c9b47704si2076268qkb.275.2022.03.05.01.28.35 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 05 Mar 2022 01:28:35 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b=Bm7w2vWy; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:58274 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nQQiI-0002AY-Qn for alex.bennee@linaro.org; Sat, 05 Mar 2022 04:28:34 -0500 Received: from eggs.gnu.org ([209.51.188.92]:40628) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nQQiD-0002AG-QX for qemu-devel@nongnu.org; Sat, 05 Mar 2022 04:28:29 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:50066) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nQQiA-0001cA-Cm for qemu-devel@nongnu.org; Sat, 05 Mar 2022 04:28:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646472504; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5v+lxzzzYjXAWwcj6FNe/edp16R/z7uYzjkD8sfpFjQ=; b=Bm7w2vWydJSP5fRjwbJB/agMKI+I4+MhyIy7RLp88Fc3kSL6mVt8JARqXaK7js+DN9Qpd/ xnh14jav9di+NOoIqr6JDeK0mEiTuP+JGBvCKtSy6gpCh+0E6SOPcOM5y/5r4n23Bi7jnK elGclRltyppV8ujrqYILT2GIlU8U/hM= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-648-HHVMYfmVOVGZjIcC8JauWA-1; Sat, 05 Mar 2022 04:28:23 -0500 X-MC-Unique: HHVMYfmVOVGZjIcC8JauWA-1 Received: by mail-wm1-f72.google.com with SMTP id f24-20020a1c6a18000000b00388874b17a8so2078872wmc.3 for ; Sat, 05 Mar 2022 01:28:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:reply-to:subject:to:cc:references:from :message-id:date:user-agent:mime-version:in-reply-to :content-transfer-encoding:content-language; bh=5v+lxzzzYjXAWwcj6FNe/edp16R/z7uYzjkD8sfpFjQ=; b=BIhV7K7DYun1dtZJOgKXTB0NVgdatvVIX/JJdMUGLIw5cwrlEWMl+o4vpYIfelvUMX r8Fu+91ds2mpdVSzjH0rgcCEjlVPRPjSWN0GtopJAF1m7d5NEOoa6M7l44+E63+GbLn8 lRELU408a1e397A4u7fxziHElXVQXuFg4dX8GnRATZYm/J8kYZwYMM0dK99ZKz3s6r8c ycrP82XJoNUdkX9up9ZMl5NxNHYPzXTH1gpAr9S1U+0Ef9GZa78YW8hn1FYvd3Vk7WcT RsA0Df/+TNkimQ0I7puCyXe+okwqZQVtzZDUih4HUN3wR2yG4y68hqhI5CZZo5feto/9 L5ew== X-Gm-Message-State: AOAM533IKH9744xVIY8abRhiM0s+j1vhlP/HwrXWUHzdb7wfYPDeAjQW T2GTb5j8fz9qCdP3p4uP2WBBwcD1tP5OxXpyULZhzkKPm/+6GydVslFCQSWJ86KSZwGx3zvDFQF 5/PjmiPm8ivduf13N7c79zn8+PWRNcVAmhozxJh0UoWkz3F9fYMxoLpB26puAodBeqKpIVg== X-Received: by 2002:a05:6000:2a2:b0:1f0:4c22:9380 with SMTP id l2-20020a05600002a200b001f04c229380mr1819099wry.139.1646472502065; Sat, 05 Mar 2022 01:28:22 -0800 (PST) X-Received: by 2002:a05:6000:2a2:b0:1f0:4c22:9380 with SMTP id l2-20020a05600002a200b001f04c229380mr1819076wry.139.1646472501614; Sat, 05 Mar 2022 01:28:21 -0800 (PST) Received: from ?IPv6:2a01:e0a:59e:9d80:527b:9dff:feef:3874? ([2a01:e0a:59e:9d80:527b:9dff:feef:3874]) by smtp.gmail.com with ESMTPSA id n5-20020a05600c3b8500b00380fc02ff76sm7760908wms.15.2022.03.05.01.28.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 05 Mar 2022 01:28:20 -0800 (PST) Subject: Re: [PATCH v2] hw/arm/virt: Fix gic-version=max when CONFIG_ARM_GIC_TCG is unset To: Peter Maydell References: <20220304174559.55645-1-eric.auger@redhat.com> From: Eric Auger Message-ID: <366332d6-c44b-9bd2-1aa4-ea3b40205ff1@redhat.com> Date: Sat, 5 Mar 2022 10:28:19 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eric.auger@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Received-SPF: pass client-ip=170.10.133.124; envelope-from=eric.auger@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: eric.auger@redhat.com Cc: qemu-devel@nongnu.org, drjones@redhat.com, qemu-arm@nongnu.org, f4bug@amsat.org, eric.auger.pro@gmail.com Errors-To: qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-devel" X-TUID: W0UavIS+njrs On 3/4/22 7:36 PM, Peter Maydell wrote: > On Fri, 4 Mar 2022 at 17:46, Eric Auger wrote: >> In TCG mode, if gic-version=max we always select GICv3 even if >> CONFIG_ARM_GIC_TCG is unset. We shall rather select GICv2. >> This also brings the benefit of fixing qos tests errors for tests >> using gic-version=max with CONFIG_ARM_GIC_TCG unset. >> >> Signed-off-by: Eric Auger >> Reviewed-by: Andrew Jones >> Fixes: a8a5546798c3 ("hw/intc/arm_gicv3: Introduce CONFIG_ARM_GIC_TCG Kconfig selector") >> >> --- >> >> v1 -> v2: >> - added Drew's R-b >> - dropped PATCH 2/2 for the time being (requires more discussions) >> --- >> hw/arm/virt.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/hw/arm/virt.c b/hw/arm/virt.c >> index 46bf7ceddf..f29779c951 100644 >> --- a/hw/arm/virt.c >> +++ b/hw/arm/virt.c >> @@ -1852,7 +1852,11 @@ static void finalize_gic_version(VirtMachineState *vms) >> vms->gic_version = VIRT_GIC_VERSION_2; >> break; >> case VIRT_GIC_VERSION_MAX: >> +#ifdef CONFIG_ARM_GIC_TCG >> vms->gic_version = VIRT_GIC_VERSION_3; >> +#else >> + vms->gic_version = VIRT_GIC_VERSION_2; >> +#endif >> break; >> case VIRT_GIC_VERSION_HOST: >> error_report("gic-version=host requires KVM"); > This doesn't look right, because the correct condition for > "should 'max' be 2 or 3" is "do we have a GICv2 or a GICv3 > compiled in", which is nothing to do with "is the GIC a TCG > GIC or the KVM GIC". Indeed at this point in the code we > know we're dealing with TCG, so the right response to > "we don't have a TCG GIC" is "give up entirely". > > I think fundamentally CONFIG_ARM_GIC_TCG is either misnamed > or selecting the wrong files to compile. Yes CONFIG_ARM_GIC_TCG is misnamed and as far as I understand selects GICV3 TCG specific files. So I will respin and change the name of the config. Thanks Eric > > thanks > -- PMM >