From: "flichtenheld (Code Review)"
Date: Wed, 1 Apr 2026 10:38:16 +0000
In-Reply-To:
References:
Reply-To: frank@...2641..., arne-openvpn@...1227...,
openvpn-devel@lists.sourceforge.net
Message-ID: <3666538b19b8c47cf89330b605f7bc46ee96bb1d-EmailReviewComments-HTML@...2715...>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="ZR01Y3WffpY="; charset=UTF-8
Subject: [Openvpn-devel] [M] Change in openvpn[master]: OpenSSL 4.0: Make
X509 objects const
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
To: plaisthos
Cc: openvpn-devel
--ZR01Y3WffpY=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: plaisthos.
flichtenheld has posted comments on this change by plaisthos. ( http://gerr=
it.openvpn.net/c/openvpn/+/1596?usp=3Demail )
Change subject: OpenSSL 4.0: Make X509 objects const
......................................................................
Patch Set 3: Code-Review-1
(2 comments)
Patchset:
PS3:
Fails on FreeBSD 13, which is OpenSSL 1.1 I think?
File src/openvpn/ssl_openssl.c:
http://gerrit.openvpn.net/c/openvpn/+/1596/comment/d8bde3bf_e9695bb4?usp=3D=
email :
PS3, Line 1913: * but not adjusted the other functions=
to take a, and other
missing word after "a"?
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1596?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings?usp=3Demail
Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Iea1d13c160599f134587c6f1c2f4a90e7f5e3991
Gerrit-Change-Number: 1596
Gerrit-PatchSet: 3
Gerrit-Owner: plaisthos
Gerrit-Reviewer: flichtenheld
Gerrit-CC: openvpn-devel
Gerrit-Attention: plaisthos
Gerrit-Comment-Date: Wed, 01 Apr 2026 10:38:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
--ZR01Y3WffpY=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is cur=
rently required from: plaisthos.
Patch set 3:Code-Review -1=
V=
iew Change
2 comments:
missin=
g word after "a"?
To view, visit change 1596. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Iea1d13c160599f134587c6f1c2f=
4a90e7f5e3991
Gerrit-Change-Number: 1596
Gerrit-PatchSet: 3
Gerrit-Owner: plaisthos <arne-openvpn@...1711...=
27...>
Gerrit-Reviewer: flichtenheld <frank@...2716...=
1...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...=
ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...=
..1227...>
Gerrit-Comment-Date: Wed, 01 Apr 2026 10:38:16=
+0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
=
--ZR01Y3WffpY=--