Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 60EB83D71 for ; Thu, 10 Aug 2023 09:44:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1691660666; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lf+g7H8c+D8XIdvK87t5LbaETche7IdF7H8+sxCRQxo=; b=e2jlKN1Wib8eVdDn7s9VzJg/5KvnLETHAlAL5GsFp8nGZxUHYHt8dl9oVH9a2cUGC3WqLg a4hK64v72j1HKsahYaf1478eEQ6KtYJLBoVrztnTrRClbXdgshDIjqxSQkTtEOZfbMjk5m CHNFec8rx2BQ9VJdor4MRQ7AZv0WZ2Y= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-302-MbNvD1iRMdejvWuwm_gWbw-1; Thu, 10 Aug 2023 05:44:24 -0400 X-MC-Unique: MbNvD1iRMdejvWuwm_gWbw-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-3fe232ba9e5so4367085e9.2 for ; Thu, 10 Aug 2023 02:44:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691660663; x=1692265463; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:reply-to:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lf+g7H8c+D8XIdvK87t5LbaETche7IdF7H8+sxCRQxo=; b=iSS+iZn5kzdrU4r0AydUGAHArbG4BVlv5N3G/tsp2jYNumV3bI7yWYI/b07BPsJaDf EAbrTrGSVliJBbiQM7Mzei7pBY9JH/m84baS5ixt6KTXQWGatgJ5EFKYvTI3cCnpcgT/ IfyVsEoWd4Sq2dUqIyaSDQ5ZIGSdy5nYgrCqHvMLtLGn22dy22Fi5KJ4Ynqq4RnJyOE2 EBa2azjDuMyApjWbbm0dEY54hK0c5+byNTI5SiFkaMSCRWfPooxAZ28NpZuL3tHqNXc5 p7liH3wEbE2LKiL5FXuiAg5ykMZeVA5aarsShSU7b2TElOrLSEPXowU0lfG7r3igg2Is yTOA== X-Gm-Message-State: AOJu0YxFEeCJa9OEpGniCy7+S/m2iW+4T1RkfHsnpLFHkrsNqoacggCC f3xn9jtoS7Sl/xB/dW7IKE2czbFSmAhtJiro11VoGv4c7Q7N7uBngePqcOXXqTXZoIyabZ1IhRX yAUqMNA9u7IBFzaeN X-Received: by 2002:a05:600c:213:b0:3fa:934c:8356 with SMTP id 19-20020a05600c021300b003fa934c8356mr1511176wmi.10.1691660663604; Thu, 10 Aug 2023 02:44:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHETQi0vth3YGZzAHlU+FHSXk47nzzZTe9HU1FXKIvTwI+udFnJZFW42tqkZkyIGRj6hC56qA== X-Received: by 2002:a05:600c:213:b0:3fa:934c:8356 with SMTP id 19-20020a05600c021300b003fa934c8356mr1511152wmi.10.1691660663318; Thu, 10 Aug 2023 02:44:23 -0700 (PDT) Received: from ?IPV6:2a01:e0a:59e:9d80:527b:9dff:feef:3874? ([2a01:e0a:59e:9d80:527b:9dff:feef:3874]) by smtp.gmail.com with ESMTPSA id y24-20020a05600c365800b003fe2b081661sm4429254wmq.30.2023.08.10.02.44.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Aug 2023 02:44:22 -0700 (PDT) Message-ID: <367481f1-e1ee-9a2d-8822-2653c73ec746@redhat.com> Date: Thu, 10 Aug 2023 11:44:20 +0200 Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Reply-To: eric.auger@redhat.com Subject: Re: [PATCH v3 25/27] KVM: arm64: nv: Expose FGT to nested guests To: Marc Zyngier , kvmarm@lists.linux.dev, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Catalin Marinas , Mark Brown , Mark Rutland , Will Deacon , Alexandru Elisei , Andre Przywara , Chase Conklin , Ganapatrao Kulkarni , Darren Hart , Miguel Luis , James Morse , Suzuki K Poulose , Oliver Upton , Zenghui Yu References: <20230808114711.2013842-1-maz@kernel.org> <20230808114711.2013842-26-maz@kernel.org> From: Eric Auger In-Reply-To: <20230808114711.2013842-26-maz@kernel.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 8/8/23 13:47, Marc Zyngier wrote: > Now that we have FGT support, expose the feature to NV guests. > > Signed-off-by: Marc Zyngier > --- > arch/arm64/kvm/nested.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/kvm/nested.c b/arch/arm64/kvm/nested.c > index 7f80f385d9e8..3facd8918ae3 100644 > --- a/arch/arm64/kvm/nested.c > +++ b/arch/arm64/kvm/nested.c > @@ -71,8 +71,9 @@ void access_nested_id_reg(struct kvm_vcpu *v, struct sys_reg_params *p, > break; > > case SYS_ID_AA64MMFR0_EL1: > - /* Hide ECV, FGT, ExS, Secure Memory */ > - val &= ~(GENMASK_ULL(63, 43) | > + /* Hide ECV, ExS, Secure Memory */ > + val &= ~(NV_FTR(MMFR0, ECV) | > + NV_FTR(MMFR0, EXS) | > NV_FTR(MMFR0, TGRAN4_2) | > NV_FTR(MMFR0, TGRAN16_2) | > NV_FTR(MMFR0, TGRAN64_2) | Reviewed-by: Eric Auger Eric