From: "plaisthos (Code Review)" Date: Tue, 18 Jun 2024 11:56:44 +0000 In-Reply-To: References: Reply-To: arne-openvpn@...1227..., selva.nair@...277..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <36850b4a3e4d616d38d9fa9e9f105147350429b6-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="W8+gVaVfMVU="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: Static-challenge concatentation option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: selvanair Cc: flichtenheld , openvpn-devel --W8+gVaVfMVU= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, selvanair. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c= /openvpn/+/665?usp=3Demail ) Change subject: Static-challenge concatentation option ...................................................................... Patch Set 1: (1 comment) File doc/man-sections/client-options.rst: http://gerrit.openvpn.net/c/openvpn/+/665/comment/87a2fe54_bda4864d : PS1, Line 552: :code: `0` is the default. I am not a big fan of this option but I will not block it. But I rather wou= ld see "scrv1" (as default) and "concat" as option for the configuration op= tion rather than 0/1. The internal code can still use the flag but I feel 0= /1 as option is rather clumsy. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/665?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I59a90446bfe73d8856516025a58a6f62cc98ab0d Gerrit-Change-Number: 665 Gerrit-PatchSet: 1 Gerrit-Owner: selvanair Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: flichtenheld Gerrit-Attention: selvanair Gerrit-Comment-Date: Tue, 18 Jun 2024 11:56:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment --W8+gVaVfMVU= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld, selvanair.

View C= hange

1 comment:

    <= li style=3D"margin: 0; padding: 0;">

    File doc/man-sections/client-options= .rst:

    • Patch Set #1,= Line 552: :code: `0`= is the default.

      I am not a big fan of this option but I will not block it. But I= rather would see "scrv1" (as default) and "concat" as = option for the configuration option rather than 0/1. The internal code can = still use the flag but I feel 0/1 as option is rather clumsy.

    =

To view, visit change 665. To unsubscribe, or for help writing mail= filters, visit settings= .

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I59a90446bfe73d8856516025a58= a6f62cc98ab0d
Gerrit-Change-Number: 665
Gerrit-PatchSet: 1
Gerrit-Owner: selvanair <selva.nair@...1354...= ..>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Attention: selvanair <selva.nair@...493...= 277...>
Gerrit-Comment-Date: Tue, 18 Jun 2024 11:56:44= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
--W8+gVaVfMVU=--