References: <20180925124819.4005-1-arne@...1227...> From: tincanteksup Message-ID: <369c7ae5-42d3-88c6-b028-3466b1933777@...277...> Date: Tue, 25 Sep 2018 15:49:01 +0100 MIME-Version: 1.0 In-Reply-To: <20180925124819.4005-1-arne@...1227...> Content-Language: en-GB Subject: Re: [Openvpn-devel] [PATCH] Add message explaining early TLS client hello failure List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit To: openvpn-devel@lists.sourceforge.net Grammar check by tincantech (my new role) On 25/09/18 13:48, Arne Schwabe wrote: > In my tests an OpenSSL 1.1.1 server does not accept TLS 1.0 only clients > anymore. Unfortunately, Debian 8 still has OpenVPN 2.3.4, which is > TLS 1.0 only without setting tls-version-min. > > We currently log only > OpenSSL: error:14209102:SSL routines:tls_early_post_process_client_hello:unsupported protocol > which indicates the right technical error but is not very helpful to a > person without deep knowledge in SSL/TLS and OpenVPN's TLS version > history. > > This commit adds a hopefully helpful message and also tells users how > to fix the old Debian 8 clients. > --- > src/openvpn/crypto_openssl.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/src/openvpn/crypto_openssl.c b/src/openvpn/crypto_openssl.c > index 9ec2048d..3360bb19 100644 > --- a/src/openvpn/crypto_openssl.c > +++ b/src/openvpn/crypto_openssl.c > @@ -199,7 +199,15 @@ crypto_print_openssl_errors(const unsigned int flags) > "in common with the client. Your --tls-cipher setting might be " > "too restrictive."); > } > - > + else if (ERR_GET_REASON(err) == SSL_R_UNSUPPORTED_PROTOCOL) > + { > + msg(D_CRYPT_ERRORS, "TLS error: Unsupported protocol. This typically " > + "indicates that client and server have no common TLS version enabled. " > + "This can be caused mismatched tls-version-min and tls-version-max options " This can be caused *by* > + "on client and server. " this could be removed as it is implicit anyway. > + "If your client is 2.3.6 or older consider adding tls-version 1.1" older":space::space:"consider ... missing :space: at EOL. > + "to the the configuration to use TLS 1.1+ instead of TLS 1.0 only"); > + } > msg(flags, "OpenSSL: %s", ERR_error_string(err, NULL)); > } > } >