Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3C452C77B61 for ; Thu, 13 Apr 2023 05:16:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KBJX+O6wPhatoQERB2sAMnVjAk4oa4Ie0URC3cWs/+A=; b=AC9Rwvp/V07HEY 69CiAvZMMmhtfHxv0/IGZ447M14eUaNISvMflRtTnuI4bQ4ig64DLOTuGQ1rCUBZ9jvoNhEedz9g6 aLA7jLR0752x4rZhzPSDJue0ZLon/HUD/xz/OjeWi4eUJXFTA3UvIiY/Yljcfai+1sucomZl+9B8E 9olMe4gGflad6cn5+P+2+yeucRJP7vmXR3DpsbPheAXojEwg0HnPXCvKgzzTvdRe0a0pPbmCjsn27 pMcOLlqo/M9VNcT8SL4nlNo98zj+5WbBHEvP5+QNvAcu7YRBitZeNOEwVjN38jCnwsSFPvI4QkNuz J9IN42+R6LEtodrNGqoA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pmpJL-0052uy-2w; Thu, 13 Apr 2023 05:15:55 +0000 Received: from lelv0143.ext.ti.com ([198.47.23.248]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pmpJI-0052tu-2z for linux-arm-kernel@lists.infradead.org; Thu, 13 Apr 2023 05:15:54 +0000 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 33D5FfAe057595; Thu, 13 Apr 2023 00:15:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1681362941; bh=JXn0CUcuMWb4wkleuP5EkTzadTX5cRASyBFA/zDBBgU=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=BNm7Oygn58bWXT7zTzOToBxUXtaToq4EP/a/tH4fKcnkbayEJXTS24gpuo1imzXpP nXMfYACz2rElsq77xnlEv0/w4Ws4upFVmkreCRuQvW9T4iXUWBAMbV9v8B2E5G8Kl9 U/9xxBQXJgrAU+B+ROhk8nJI4vnZb+Ttqy2REr5s= Received: from DFLE110.ent.ti.com (dfle110.ent.ti.com [10.64.6.31]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 33D5FfBd109985 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 13 Apr 2023 00:15:41 -0500 Received: from DFLE109.ent.ti.com (10.64.6.30) by DFLE110.ent.ti.com (10.64.6.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16; Thu, 13 Apr 2023 00:15:40 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DFLE109.ent.ti.com (10.64.6.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16 via Frontend Transport; Thu, 13 Apr 2023 00:15:40 -0500 Received: from [172.24.145.109] (ileaxei01-snat.itg.ti.com [10.180.69.5]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 33D5Fbrg028761; Thu, 13 Apr 2023 00:15:37 -0500 Message-ID: <36fc3872-96ba-e503-cfff-754036e561e1@ti.com> Date: Thu, 13 Apr 2023 10:45:36 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH] arm64: dts: ti: k3-j721s2-main: fix msmc node Content-Language: en-US To: Nishanth Menon CC: , , , , , , , , , References: <20230412173609.1307837-1-u-kumar1@ti.com> <20230412195656.a53nalvjuhelniz4@populace> From: Udit Kumar In-Reply-To: <20230412195656.a53nalvjuhelniz4@populace> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230412_221553_116177_FE33ABFA X-CRM114-Status: GOOD ( 17.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Nishanth, On 13/04/23 01:26, Nishanth Menon wrote: > On 23:06-20230412, Udit Kumar wrote: >> On J721S2 SOC, l3cache-sram size is configured as zero by >> system firmware. >> Also top 64K of msmc_ram (0x703F_0000 to 0x703F_FFFF) is used by system >> firmware tifs-sram. >> >> This patch removes l3cache-sram node and update range for tifs-sram. >> >> Fixes: b8545f9d3a54 ("arm64: dts: ti: Add initial support for J721S2 SoC") >> >> Signed-off-by: Udit Kumar >> --- >> arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi | 7 ++----- >> 1 file changed, 2 insertions(+), 5 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi >> index 2dd7865f7654..cbc784f915a9 100644 >> --- a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi >> +++ b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi >> @@ -17,13 +17,10 @@ atf-sram@0 { >> reg = <0x0 0x20000>; >> }; >> >> - tifs-sram@1f0000 { >> - reg = <0x1f0000 0x10000>; >> + tifs-sram@3f0000 { >> + reg = <0x3f0000 0x10000>; >> }; >> >> - l3cache-sram@200000 { >> - reg = <0x200000 0x200000>; >> - }; >> }; >> >> gic500: interrupt-controller@1800000 { >> -- >> 2.34.1 >> > Are you saying that j721s2 is incapable of l3 cache? say some level 1 > errata? No > or is it because, the chip is really capable of l3 cache and we are > really setting it to 0? > > https://git.ti.com/cgit/k3-image-gen/k3-image-gen/tree/soc/j721s2/evm/board-cfg.c#n71 This is because, l3 cache size is set to zero. > unless the chip has an errata, you are supposed to fix it up based on > configuration by using the API and this patch is a NAK > https://software-dl.ti.com/tisci/esd/latest/2_tisci_msgs/general/core.html#tisci-query-msmc ok _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel