Message-ID: <370b8058-0015-56e1-8760-916e48982d3d@...2181...> Date: Tue, 19 Jul 2022 00:54:21 +0200 MIME-Version: 1.0 Content-Language: en-US References: <20220624083809.23487-1-a@...2181...> <20220624083809.23487-13-a@...2181...> From: Antonio Quartulli In-Reply-To: Subject: Re: [Openvpn-devel] [PATCH 12/25] dco: check that pulled options are compatible List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit To: Gert Doering Cc: openvpn-devel@lists.sourceforge.net Hi, On 14/07/2022 22:14, Gert Doering wrote: > Hi, > > On Fri, Jun 24, 2022 at 10:37:56AM +0200, Antonio Quartulli wrote: >> diff --git a/src/openvpn/init.c b/src/openvpn/init.c >> index b0a4b252..091cbd24 100644 >> --- a/src/openvpn/init.c >> +++ b/src/openvpn/init.c >> @@ -2219,6 +2219,19 @@ do_deferred_p2p_ncp(struct context *c) >> return true; >> } >> >> + >> +static bool >> +check_dco_pull_options(struct options *o) >> +{ > > Nitpicking a bit - the "other" DCO option check functions are in dco.c > (not yet, but in the patches leading up to this), so why is this one in > init.c? good point. will move it to dco.c and send v2 Cheers, > > gert -- Antonio Quartulli