From: "cron2 (Code Review)" Date: Wed, 23 Jul 2025 06:19:18 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641..., antonio@...2726... Message-ID: <37189d6506e7962e5b04d8744250096ffdc9f5fb-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="0gMbRiSjlec="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: dco: only pass struct context to init function List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: plaisthos , flichtenheld , openvpn-devel --0gMbRiSjlec= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, ordex, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/ope= nvpn/+/1094?usp=3Demail ) Change subject: dco: only pass struct context to init function ...................................................................... Patch Set 2: Code-Review-2 (1 comment) Patchset: PS2: `dco.h` has ``` static inline bool ovpn_dco_init(int mode, dco_context_t *dco, const char *dev_node) { return true; } ``` which also needs to be adjusted... -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1094?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I673a17f8c5dec66cc6c28c1ed44780a7a63927d7 Gerrit-Change-Number: 1094 Gerrit-PatchSet: 2 Gerrit-Owner: ordex Gerrit-Reviewer: cron2 Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-Attention: ordex Gerrit-Comment-Date: Wed, 23 Jul 2025 06:19:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment --0gMbRiSjlec= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld, ordex, plaisthos. <= /p>

Patch set 2:Code-Review -2=

V= iew Change

1 comment:

  • Patchset:

    • Patch Set #2:

      `dco.h` has

      ```
      static inline bool
      ovp= n_dco_init(int mode, dco_context_t *dco, const char *dev_node)
      {
      = return true;
      }
      ```

      which also needs to be adjusted...

= To view, visit change 1094. To unsubscribe, or for help writing mail filters, v= isit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I673a17f8c5dec66cc6c28c1ed44= 780a7a63927d7
Gerrit-Change-Number: 1094
Gerrit-PatchSet: 2
Gerrit-Owner: ordex <antonio@...2726...>=
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Attention: ordex <antonio@...2726...= >
Gerrit-Comment-Date: Wed, 23 Jul 2025 06:19:18= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
--0gMbRiSjlec=--