Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 49103C38142 for ; Fri, 27 Jan 2023 15:50:50 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 7CCCB856B9; Fri, 27 Jan 2023 16:50:47 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=baylibre-com.20210112.gappssmtp.com header.i=@baylibre-com.20210112.gappssmtp.com header.b="pBmwoDhg"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 5D497856E9; Fri, 27 Jan 2023 16:50:45 +0100 (CET) Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 73C1E85693 for ; Fri, 27 Jan 2023 16:50:42 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=souajih@baylibre.com Received: by mail-wr1-x433.google.com with SMTP id m14so4889876wrg.13 for ; Fri, 27 Jan 2023 07:50:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=fNaAL75VIarS8fN3L+yjQmJzZDQ0n25XdTl0bXXW4N4=; b=pBmwoDhgKxe0Xjo7upLGfQE84nPgatUjZoKQMNYUfIQY2IxJmYQ0uRqRXib/Dqulo/ OTGuwaN1wseDgtIaQ7yTFf7W9LSdGj6YSZs7xz/spyLTbwL5vsZD7xYdh2Sr1MYxUtTJ 5Dfd+OtyLdTbWddykztzggOjddo8Jo+wVP4uqcgKJoLu9ZxGT2u6jzP5kWMNewUdO+2z HFL3esL86m8FGB+xd8bk/gU4gk3K8U8gFo472lToi0yZj9yiGZUtpUh/03X1fll2ShNL vPkA+TnaPcrz3T2nM5ycegKUeR7KiXl38wMVia24Oql3sh9hQzmPu2kdD0Kg09b36jWL 3QQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fNaAL75VIarS8fN3L+yjQmJzZDQ0n25XdTl0bXXW4N4=; b=HLJ50w6Wb0pky5SohLgUBKgGRVlVV4XRuB2457tY3ovjm+z4CEcjhcW8MT8jvo0dJk 8JugEG/uugQaQd1E15XiluBb62WGVXhCuhk/iOTWipCyyyy3ey6Cl/cyDfcZBlxRlzfE MjqDLXzOpD7AD/v37+v5CE0J5Xn2GwEI8u7AEoNZ/mOwEe5FaTZ07yB6DyHBzyJ52g5V PYS4y4MAtazs/FvoHwJvoZ0QHTQoYFtSE9PvoqshrTI/qZfofy5nFX9gyFHPq+u08yIF 3IfIi5txjxW2uoIX54veU2vTHyoSyaWk7tQ5lCjY0Lm1eE5vrj+0bWudvMWrJXqTrfUu s5tg== X-Gm-Message-State: AO0yUKUYz+4JtQ7Sq2BFGL40swdtK6TaMxM4g+psMlwINzUu3Ibzg0wm rPT9UAw+UjUdCuyEzDLdUa+kUA== X-Google-Smtp-Source: AK7set91mUfSxGkMpeMYbibKqBGHPBp1T8VcRAw1ymUS2IaKuzuYry3izDt9GeswZYEbIHEtEjxhBQ== X-Received: by 2002:adf:e410:0:b0:2bf:d512:a943 with SMTP id g16-20020adfe410000000b002bfd512a943mr2076205wrm.58.1674834641820; Fri, 27 Jan 2023 07:50:41 -0800 (PST) Received: from [10.2.3.222] (lfbn-nic-1-295-18.w90-116.abo.wanadoo.fr. [90.116.132.18]) by smtp.gmail.com with ESMTPSA id y17-20020adffa51000000b002238ea5750csm5316165wrr.72.2023.01.27.07.50.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Jan 2023 07:50:41 -0800 (PST) Message-ID: <372eb7d2-b126-ed76-52b0-7e04bfaa90fc@baylibre.com> Date: Fri, 27 Jan 2023 16:50:40 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v2 06/17] android: boot: move to andr_image_data structure Content-Language: en-US To: Simon Glass Cc: u-boot@lists.denx.de, sean.anderson@seco.com, r.stratiienko@gmail.com, mkorpershoek@baylibre.com, glaroque@baylibre.com, khilman@baylibre.com References: <20230126160506.1026643-1-souajih@baylibre.com> <20230126160506.1026643-7-souajih@baylibre.com> From: Safae Ouajih In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 27/01/2023 01:54, Simon Glass wrote: > Hi Safae, > > On Thu, 26 Jan 2023 at 09:05, Safae Ouajih wrote: >> Move from andr_boot_img_hdr_v0 to andr_image_data >> structure to prepare for boot image header >> version 3 and 4. >> >> Signed-off-by: Safae Ouajih >> --- >> boot/image-android.c | 127 ++++++++++++++++++++++++------------------- >> cmd/abootimg.c | 31 ++++++----- >> include/image.h | 2 + >> 3 files changed, 89 insertions(+), 71 deletions(-) >> > Do you need the #ifdef CONFIG_CMD_ABOOTIMG? We try to avoid adding those. > > Regards, > Simon Hi Simon, This is needed to avoid warnings such as "unused function warnings" when CONFIG_CMD_ABOOTIMG is not defined. Best regards, --safae