From: Michael Trimarchi Subject: Re: [PATCH] VFS: make file->f_pos access atomic on 32bit arch Date: Tue, 16 Sep 2008 16:01:39 +0000 (GMT) Message-ID: <377425.67419.qm@web26204.mail.ukl.yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE To: 7eggert@gmx.de, Hisashi Hifumi , akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Return-path: Received: from web26204.mail.ukl.yahoo.com ([217.12.10.241]:46280 "HELO web26204.mail.ukl.yahoo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1754325AbYIPQBk convert rfc822-to-8bit (ORCPT ); Tue, 16 Sep 2008 12:01:40 -0400 Sender: linux-fsdevel-owner@vger.kernel.org List-ID: hi, ----- Messaggio originale ----- > Da: Bodo Eggert <7eggert@gmx.de> > A: Hisashi Hifumi ; akpm@linux-foundati= on.org; linux-kernel@vger.kernel.org; linux-fsdevel@vger.kernel.org > Inviato: Marted=EC 16 settembre 2008, 17:32:08 > Oggetto: Re: [PATCH] VFS: make file->f_pos access atomic on 32bit arc= h >=20 > Hisashi Hifumi wrote: >=20 > > Protecting file->f_pos with a lock adds some overhead but I think w= e should > > fix this. > > I used seqlock to serialize the access to file->f_pos. This approac= h is > > similar to inode->i_size synchronization. > >=20 > > Comments? >=20 > > + if (offset !=3D file_pos_read(file)) > > + file_pos_write(file, offset); >=20 > Maybe file_pos_write should do this check? >=20 I agree :) Regards Michael > -- > To unsubscribe from this list: send the line "unsubscribe linux-kerne= l" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ __________________________________________________ Do You Yahoo!? Poco spazio e tanto spam? Yahoo! Mail ti protegge dallo spam e ti da ta= nto spazio gratuito per i tuoi file e i messaggi=20 http://mail.yahoo.it=20 -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html