Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0C786CD6E4A for ; Thu, 4 Jun 2026 11:51:43 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wV6bl-0001Kj-GV; Thu, 04 Jun 2026 07:51:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wV6bk-0001KT-6J for qemu-arm@nongnu.org; Thu, 04 Jun 2026 07:51:32 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wV6bi-0007fE-Ez for qemu-arm@nongnu.org; Thu, 04 Jun 2026 07:51:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780573889; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PdmReCAJNUtqEix/n4fG+YTi+9S85Iwj4f30F/ixVIU=; b=T3tjZ+fxUDgyR3dUGULS401f3su8MySv0mCAQClZNhwyqy5YIJhOTvQcihM8Po/Sjq59sq NhB0u3hd3Zrhk2a6t5ImzD2QmAV1tCyssX/ssQdtOmyxUkTEnqc6K2j9v8E/w4rsGO7omS 1Gdv1mb1kuvj805syjL7N6k8ACsk/AU= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-558-B55e2wqbNli5LWynxOaaYQ-1; Thu, 04 Jun 2026 07:51:26 -0400 X-MC-Unique: B55e2wqbNli5LWynxOaaYQ-1 X-Mimecast-MFC-AGG-ID: B55e2wqbNli5LWynxOaaYQ_1780573885 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-490afe64f26so2853075e9.0 for ; Thu, 04 Jun 2026 04:51:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780573885; x=1781178685; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:reply-to:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PdmReCAJNUtqEix/n4fG+YTi+9S85Iwj4f30F/ixVIU=; b=qCIb9eibbq2zHoKkyDjgAYJoINSHaCJz6BqzhVReyr+4q3gSaNMnHQ6U4tH6QfLLAA wyp2PQ0Ptf1MrUuzBVanQsKqUiMQxt/RnLQRJJdKoHgWiVwdF9OJmcu8Waywix76ve7x IG76wWbwMVzfzUQZBo2LSHUT/aSFY3KI1ib4E6+vzobI9PbEYPG4OOIDpamR1rvhEZV/ 2jk18u6xqG8UA+I503eV479jbrf70Jw6iLemnPf1kVEElimWoLvV7gvN16FCyH6DvvXC 2wHKGkkzIwZptfKWoXRESnDjlmUjcAJCK0Zf581N5BcVQlKcNeib3KfCKrZZLP4Z8MT/ 9WCw== X-Forwarded-Encrypted: i=1; AFNElJ8VJ6fe7NLZLsfuypRmD+1YbQlsqz9Caw8f/drZ8/OfFCEtj5QK1rOyK7f/6ED2ax3UEtjlrpC5XQ==@nongnu.org X-Gm-Message-State: AOJu0Yxlc4nMax5NyDF1z2QSOOBMCnfJUWcUeT2lhBYwn8kEg8J3ITmt yHN6Eo+HOK5GBsV5elf+lfkYkcR0x9+L69eR4RPH1Vq9v6LDJTqPfLTDDkxRAdLQRnoAHKFXmxW DZ1eC0RGyEcryoYEh/8WGBZyo/M7D+e8KecV0IVeEaC85rB8GEUCWkQ== X-Gm-Gg: Acq92OHwBqYH+k+gjQyl1boK8I//vg0DToDOy58/M4Z2WzYdtGKXNqrlDM8imf/0EVN 2cBRmZ4T47TqPWD9yPanSj1oU8WafP0ztlwHP50gNJ/ZxAurGDnIzkayXRw1Nm6vZ7EydJNYtW5 Q+r/OKg1/YM55hU0OLbrZnR6ZpN36sND/JJDwgZEwxGBfJcGpud4aGcli+RI7J2Fgb5RHQM5npW DyWyhzzP84YxPDyHuh7XI4km7p76OhLxf479h1fUuCZXLYLkvb0JM03L+Bl/uKrGzC8iq5cg22l MPhRBOBLDayuc2KF2olwDv36iTSkT6ePVLxRm8mx9VfA7hRlly040ojnp8FljfkUjpB9edb0wpe 8WTsNsRxJJYscJWNnt136Ym2MAq5dxAo65ujzuwK55XU+26zo7UPLo8S48LmN95iGRkXQzm7fw7 J6nVVm X-Received: by 2002:a05:600c:34d3:b0:490:b26c:64ad with SMTP id 5b1f17b1804b1-490bc4cf867mr52346475e9.5.1780573884794; Thu, 04 Jun 2026 04:51:24 -0700 (PDT) X-Received: by 2002:a05:600c:34d3:b0:490:b26c:64ad with SMTP id 5b1f17b1804b1-490bc4cf867mr52345905e9.5.1780573884409; Thu, 04 Jun 2026 04:51:24 -0700 (PDT) Received: from ?IPV6:2a01:e0a:f0e:9070:527b:9dff:feef:3874? ([2a01:e0a:f0e:9070:527b:9dff:feef:3874]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-490b7a273e3sm102509065e9.0.2026.06.04.04.51.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Jun 2026 04:51:23 -0700 (PDT) Message-ID: <379a6953-e0a6-4c82-8446-ecdd24e19401@redhat.com> Date: Thu, 4 Jun 2026 13:51:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 23/31] hw/arm/tegra241-cmdqv: Read and propagate Tegra241 CMDQV errors To: Shameer Kolothum , qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, clg@redhat.com, alex@shazbot.org, nicolinc@nvidia.com, nathanc@nvidia.com, mochs@nvidia.com, jan@nvidia.com, jgg@nvidia.com, zhenzhong.duan@intel.com, kjaju@nvidia.com, phrdina@redhat.com References: <20260601114221.457995-1-skolothumtho@nvidia.com> <20260601114221.457995-24-skolothumtho@nvidia.com> From: Eric Auger In-Reply-To: <20260601114221.457995-24-skolothumtho@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: zgnkO0b6jtTRSwCA9DT8UrKV8omvfnJnuMsYov6A6A4_1780573885 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=eric.auger@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: eric.auger@redhat.com Errors-To: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org Sender: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org On 6/1/26 1:42 PM, Shameer Kolothum wrote: > Install an event handler on the CMDQV vEVENTQ fd to read and propagate > host received CMDQV errors to the guest. > > The handler runs in QEMU's main loop, using a non-blocking fd registered > via qemu_set_fd_handler(). > > Reviewed-by: Nicolin Chen > Signed-off-by: Shameer Kolothum Reviewed-by: Eric Auger Eric > --- > hw/arm/tegra241-cmdqv.c | 63 +++++++++++++++++++++++++++++++++++++++++ > hw/arm/trace-events | 1 + > 2 files changed, 64 insertions(+) > > diff --git a/hw/arm/tegra241-cmdqv.c b/hw/arm/tegra241-cmdqv.c > index cdd4fa4f1a..d8b36164a1 100644 > --- a/hw/arm/tegra241-cmdqv.c > +++ b/hw/arm/tegra241-cmdqv.c > @@ -14,6 +14,7 @@ > > #include "hw/arm/smmuv3.h" > #include "hw/arm/smmuv3-common.h" > +#include "hw/core/irq.h" > #include "smmuv3-accel.h" > #include "tegra241-cmdqv.h" > #include "trace.h" > @@ -751,6 +752,51 @@ out: > trace_tegra241_cmdqv_write_mmio(offset, value, size); > } > > +static void tegra241_cmdqv_event_read(void *opaque) > +{ > + Tegra241CMDQV *cmdqv = opaque; > + IOMMUFDVeventq *veventq = cmdqv->veventq; > + struct { > + struct iommufd_vevent_header hdr; > + struct iommu_vevent_tegra241_cmdqv vevent; > + } buf; > + Error *local_err = NULL; > + > + if (!smmuv3_accel_event_read_validate(veventq, > + IOMMU_VEVENTQ_TYPE_TEGRA241_CMDQV, > + &buf, sizeof(buf), &local_err)) { > + warn_report_err_once(local_err); > + return; > + } > + > + if (buf.vevent.lvcmdq_err_map[0] || buf.vevent.lvcmdq_err_map[1]) { > + cmdqv->vintf_cmdq_err_map[0] = > + extract64(buf.vevent.lvcmdq_err_map[0], 0, 32); > + cmdqv->vintf_cmdq_err_map[1] = > + extract64(buf.vevent.lvcmdq_err_map[0], 32, 32); > + cmdqv->vintf_cmdq_err_map[2] = > + extract64(buf.vevent.lvcmdq_err_map[1], 0, 32); > + cmdqv->vintf_cmdq_err_map[3] = > + extract64(buf.vevent.lvcmdq_err_map[1], 32, 32); > + /* > + * CMDQV_CMDQ_ERR_MAP and VINTF0_LVCMDQ_ERR_MAP are distinct > + * registers (different MMIO offsets). With only VINTF0 exposed > + * they carry the same data, so mirror. > + */ > + for (int i = 0; i < 4; i++) { > + cmdqv->cmdq_err_map[i] = cmdqv->vintf_cmdq_err_map[i]; > + } > + /* Set the VINTF0 bit in VI_ERR_MAP_0 (only VINTF0 is exposed). */ > + cmdqv->vi_err_map[0] |= BIT(0); > + if (!(cmdqv->vi_int_mask[0] & BIT(0))) { > + qemu_irq_pulse(cmdqv->irq); > + } > + trace_tegra241_cmdqv_err_map( > + cmdqv->vintf_cmdq_err_map[3], cmdqv->vintf_cmdq_err_map[2], > + cmdqv->vintf_cmdq_err_map[1], cmdqv->vintf_cmdq_err_map[0]); > + } > +} > + > static void tegra241_cmdqv_free_viommu(SMMUv3State *s) > { > SMMUv3AccelState *accel = s->s_accel; > @@ -762,6 +808,7 @@ static void tegra241_cmdqv_free_viommu(SMMUv3State *s) > return; > } > if (veventq) { > + qemu_set_fd_handler(veventq->veventq_fd, NULL, NULL, NULL); > close(veventq->veventq_fd); > iommufd_backend_free_id(viommu->iommufd, veventq->veventq_id); > g_free(veventq); > @@ -777,6 +824,7 @@ tegra241_cmdqv_alloc_viommu(SMMUv3State *s, HostIOMMUDeviceIOMMUFD *idev, > Tegra241CMDQV *cmdqv = s->s_accel->cmdqv; > uint32_t viommu_id, veventq_id, veventq_fd; > IOMMUFDVeventq *veventq; > + int flags; > > if (!iommufd_backend_alloc_viommu(idev->iommufd, idev->devid, > IOMMU_VIOMMU_TYPE_TEGRA241_CMDQV, > @@ -795,14 +843,29 @@ tegra241_cmdqv_alloc_viommu(SMMUv3State *s, HostIOMMUDeviceIOMMUFD *idev, > goto free_viommu; > } > > + flags = fcntl(veventq_fd, F_GETFL); > + if (flags < 0) { > + error_setg(errp, "Failed to get flags for vEVENTQ fd"); > + goto free_veventq; > + } > + if (fcntl(veventq_fd, F_SETFL, O_NONBLOCK | flags) < 0) { > + error_setg(errp, "Failed to set O_NONBLOCK on vEVENTQ fd"); > + goto free_veventq; > + } > + > veventq = g_new(IOMMUFDVeventq, 1); > veventq->veventq_id = veventq_id; > veventq->veventq_fd = veventq_fd; > cmdqv->veventq = veventq; > > + /* Set up event handler for veventq fd */ > + qemu_set_fd_handler(veventq_fd, tegra241_cmdqv_event_read, NULL, cmdqv); > *out_viommu_id = viommu_id; > return true; > > +free_veventq: > + close(veventq_fd); > + iommufd_backend_free_id(idev->iommufd, veventq_id); > free_viommu: > iommufd_backend_free_id(idev->iommufd, viommu_id); > return false; > diff --git a/hw/arm/trace-events b/hw/arm/trace-events > index d76f408d8a..115f1add9d 100644 > --- a/hw/arm/trace-events > +++ b/hw/arm/trace-events > @@ -75,6 +75,7 @@ smmuv3_accel_install_ste(uint32_t vsid, const char * type, uint32_t hwpt_id) "vS > # tegra241-cmdqv > tegra241_cmdqv_read_mmio(uint64_t offset, uint64_t val, unsigned size) "offset: 0x%"PRIx64" val: 0x%"PRIx64" size: 0x%x" > tegra241_cmdqv_write_mmio(uint64_t offset, uint64_t val, unsigned size) "offset: 0x%"PRIx64" val: 0x%"PRIx64" size: 0x%x" > +tegra241_cmdqv_err_map(uint32_t map3, uint32_t map2, uint32_t map1, uint32_t map0) "hw irq received. error (hex) maps: %04X:%04X:%04X:%04X" > tegra241_cmdqv_read_vcmdq_page0(int index, const char *aperture, uint64_t offset0, uint64_t val) "vcmdq[%d] %s page0 offset0: 0x%"PRIx64" val: 0x%"PRIx64 > tegra241_cmdqv_read_vcmdq_page1(int index, const char *aperture, uint64_t offset0, uint64_t val) "vcmdq[%d] %s page1 offset0: 0x%"PRIx64" val: 0x%"PRIx64 > tegra241_cmdqv_write_vcmdq_page0(int index, const char *aperture, uint64_t offset0, uint64_t val) "vcmdq[%d] %s page0 offset0: 0x%"PRIx64" val: 0x%"PRIx64