Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4C482C4332F for ; Wed, 4 Jan 2023 17:52:15 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E0C6685515; Wed, 4 Jan 2023 18:52:12 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="WLxI6AE4"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id C101A85589; Wed, 4 Jan 2023 18:52:11 +0100 (CET) Received: from mail-qv1-xf2f.google.com (mail-qv1-xf2f.google.com [IPv6:2607:f8b0:4864:20::f2f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A034285515 for ; Wed, 4 Jan 2023 18:52:08 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=seanga2@gmail.com Received: by mail-qv1-xf2f.google.com with SMTP id t13so18021166qvp.9 for ; Wed, 04 Jan 2023 09:52:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ZZ2KnqZEAtL/emAXL9Mp5/tdML8kiAKPyH+J8eL+9aE=; b=WLxI6AE4No1JCfSKNd0wbon6Ej8S9r0Db3XdkRJdjuFHXUcAm54NWsbHR+D0hN0GSC NqHGX4OvBnobko4FzqOcT+ofmOrayD4Ywx/LgZuZBFIMAUZEW5q4Dj9vm5fUde9ndl/T OitXe4Kr5XTnTl8Sq5CD8gv8AICBvSCerc1Z9YTypcMi1pWPpb3/xKB25Su7NKe495eR UlMWu23V8Q8MxrdHT+FwaWlbZGexykj1KGIXMzJFp2q3S9o6DVJxzyF3USMNshueICot vzcMXxWWlowXhO/6uTFNwQ1GL6/QKzSxLUQ/YzqhcgbXf1yr/bwRjZxSND2BgiPaUdi3 Uuqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZZ2KnqZEAtL/emAXL9Mp5/tdML8kiAKPyH+J8eL+9aE=; b=nFwBL9DBJYLA84C8vOEepfT02nU6R5xARq4xb88olUdl+aSCc4PYizSFl74knUTZws GFZfPo0DbCn2TNvP+Y9jHVeHhK9c4qY3DlHzxLlHH2ft+cV91dCxBgAMtxsl5SAeAkiE sdQXUh2J+zIVzzNUDHE6ffPtHzBB3Yy/IA4Z6KUv18fugNcO1v8Jh+KTBohOBSgiz0s5 lxzXaiXu0OhLpDh6qPG2Mq/AjkSbKZPEIGTFpZczgfkQqfk1ln2vgNOLAmMnLldQFYV8 2LleA/BPNPKEbb36KWBzpxrZ4tcHEnyr0HFhexee5Jl1fhTJ872B3khd6bj53TmkjvnM Xy6g== X-Gm-Message-State: AFqh2kpkV4UxkKo8hhXc2+wofkYMwzM5oY1MwIBVxqNetFAx/LXQ5ZV3 V6ZR+B9N4+2t+aXQkU42vjs= X-Google-Smtp-Source: AMrXdXtybYZPbwhYcAV/wygSozGGgtXWy/8FD7q28E8WLkeNGsO7cB8Ka5ZNwV57SxKWpI3/Th1RKw== X-Received: by 2002:a05:6214:178b:b0:531:9d25:aadf with SMTP id ct11-20020a056214178b00b005319d25aadfmr34211428qvb.17.1672854727484; Wed, 04 Jan 2023 09:52:07 -0800 (PST) Received: from [192.168.1.201] (pool-173-73-95-180.washdc.fios.verizon.net. [173.73.95.180]) by smtp.gmail.com with ESMTPSA id s13-20020a05620a0bcd00b006e16dcf99c8sm24533052qki.71.2023.01.04.09.52.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Jan 2023 09:52:07 -0800 (PST) Message-ID: <37b174ce-e827-f659-ad46-e655056b03b9@gmail.com> Date: Wed, 4 Jan 2023 12:52:05 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v5 04/19] clk: at91: pmc: export clock setup to pmc Content-Language: en-US To: Sergiu Moga , eugen.hristev@microchip.com, durai.manickamkr@microchip.com, sandeep.sheriker@microchip.com, greg@embeddedgreg.com, nicolas.ferre@microchip.com, ludovic.desroches@microchip.com, lukma@denx.de, marex@denx.de, michael@walle.cc, hs@denx.de, claudiu.beznea@microchip.com, balamanikandan.gunasundar@microchip.com, michael@amarulasolutions.com, dario.binacchi@amarulasolutions.com, cristian.birsan@microchip.com, peng.fan@nxp.com, mihai.sain@microchip.com, weijie.gao@mediatek.com, sumit.garg@linaro.org, jim.t90615@gmail.com, michal.simek@amd.com, sjg@chromium.org, j-keerthy@ti.com, ashok.reddy.soma@xilinx.com Cc: u-boot@lists.denx.de References: <20221222105357.105457-1-sergiu.moga@microchip.com> <20221222105357.105457-5-sergiu.moga@microchip.com> From: Sean Anderson In-Reply-To: <20221222105357.105457-5-sergiu.moga@microchip.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 12/22/22 05:53, Sergiu Moga wrote: > From: Claudiu Beznea > > Clock setup was intended for setting clocks at boot time on SAMA7G5, > e.g. for root clocks like PLLs, that were used to feed IPs needed alive > in u-boot (e.g. Ethernet clock feed by a PLL). Export this functionality > to all at91 clocks as it may be necessary on other SoCs. > > Signed-off-by: Claudiu Beznea > Signed-off-by: Sergiu Moga > --- > > > > v1 -> v2: > - Additional patch, this was not here in v1 > > > v2 -> v5: > - No change > > > > drivers/clk/at91/pmc.c | 42 +++++++++++++++++++++++++++++++++ > drivers/clk/at91/pmc.h | 16 +++++++++++++ > drivers/clk/at91/sama7g5.c | 48 +++++--------------------------------- > 3 files changed, 64 insertions(+), 42 deletions(-) > > diff --git a/drivers/clk/at91/pmc.c b/drivers/clk/at91/pmc.c > index 270892517a..87d2069d89 100644 > --- a/drivers/clk/at91/pmc.c > +++ b/drivers/clk/at91/pmc.c > @@ -120,3 +120,45 @@ int at91_clk_mux_index_to_val(const u32 *table, u32 num_parents, u32 index) > > return table[index]; > } > + > +int at91_clk_setup(const struct pmc_clk_setup *setup, int size) > +{ > + struct clk *c, *parent; > + int i, ret; > + > + if (!size) > + return 0; > + > + if (!setup) > + return -EINVAL; > + > + for (i = 0; i < size; i++) { > + ret = clk_get_by_id(setup[i].cid, &c); > + if (ret) > + return ret; > + > + if (setup[i].pid) { > + ret = clk_get_by_id(setup[i].pid, &parent); > + if (ret) > + return ret; > + > + ret = clk_set_parent(c, parent); > + if (ret) > + return ret; > + > + if (setup[i].prate) { > + ret = clk_set_rate(parent, setup[i].prate); > + if (ret < 0) > + return ret; > + } > + } > + > + if (setup[i].rate) { > + ret = clk_set_rate(c, setup[i].rate); > + if (ret < 0) > + return ret; > + } > + } > + > + return 0; > +} > diff --git a/drivers/clk/at91/pmc.h b/drivers/clk/at91/pmc.h > index 17793b8802..ff464522aa 100644 > --- a/drivers/clk/at91/pmc.h > +++ b/drivers/clk/at91/pmc.h > @@ -77,6 +77,20 @@ struct clk_usbck_layout { > u32 usbdiv_mask; > }; > > +/** > + * Clock setup description > + * @cid: clock id corresponding to clock subsystem > + * @pid: parent clock id corresponding to clock subsystem > + * @rate: clock rate > + * @prate: parent rate > + */ > +struct pmc_clk_setup { > + unsigned int cid; > + unsigned int pid; > + unsigned long rate; > + unsigned long prate; > +}; > + > extern const struct clk_programmable_layout at91rm9200_programmable_layout; > extern const struct clk_programmable_layout at91sam9g45_programmable_layout; > extern const struct clk_programmable_layout at91sam9x5_programmable_layout; > @@ -160,4 +174,6 @@ void pmc_write(void __iomem *base, unsigned int off, unsigned int val); > void pmc_update_bits(void __iomem *base, unsigned int off, unsigned int mask, > unsigned int bits); > > +int at91_clk_setup(const struct pmc_clk_setup *setup, int size); > + > #endif > diff --git a/drivers/clk/at91/sama7g5.c b/drivers/clk/at91/sama7g5.c > index d1ec3c82b5..8bd9c14156 100644 > --- a/drivers/clk/at91/sama7g5.c > +++ b/drivers/clk/at91/sama7g5.c > @@ -1070,19 +1070,8 @@ static const struct { > }, > }; > > -/** > - * Clock setup description > - * @cid: clock id corresponding to clock subsystem > - * @pid: parent clock id corresponding to clock subsystem > - * @rate: clock rate > - * @prate: parent rate > - */ > -static const struct pmc_clk_setup { > - unsigned int cid; > - unsigned int pid; > - unsigned long rate; > - unsigned long prate; > -} sama7g5_clk_setup[] = { > +/* Clock setup description */ > +static const struct pmc_clk_setup sama7g5_clk_setup[] = { > { > .cid = AT91_TO_CLK_ID(PMC_TYPE_CORE, ID_PLL_ETH_FRAC), > .rate = 625000000, > @@ -1119,7 +1108,7 @@ static int sama7g5_clk_probe(struct udevice *dev) > unsigned int *muxallocs[SAMA7G5_MAX_MUX_ALLOCS]; > const char *p[10]; > unsigned int cm[10], m[10], *tmpclkmux, *tmpmux; > - struct clk clk, *c, *parent; > + struct clk clk, *c; > bool main_osc_bypass; > int ret, muxallocindex = 0, clkmuxallocindex = 0, i, j; > > @@ -1353,34 +1342,9 @@ static int sama7g5_clk_probe(struct udevice *dev) > } > > /* Setup clocks. */ > - for (i = 0; i < ARRAY_SIZE(sama7g5_clk_setup); i++) { > - ret = clk_get_by_id(sama7g5_clk_setup[i].cid, &c); > - if (ret) > - goto fail; > - > - if (sama7g5_clk_setup[i].pid) { > - ret = clk_get_by_id(sama7g5_clk_setup[i].pid, &parent); > - if (ret) > - goto fail; > - > - ret = clk_set_parent(c, parent); > - if (ret) > - goto fail; > - > - if (sama7g5_clk_setup[i].prate) { > - ret = clk_set_rate(parent, > - sama7g5_clk_setup[i].prate); > - if (ret < 0) > - goto fail; > - } > - } > - > - if (sama7g5_clk_setup[i].rate) { > - ret = clk_set_rate(c, sama7g5_clk_setup[i].rate); > - if (ret < 0) > - goto fail; > - } > - } > + ret = at91_clk_setup(sama7g5_clk_setup, ARRAY_SIZE(sama7g5_clk_setup)); > + if (ret) > + goto fail; > > return 0; > Reviewed-by: Sean Anderson