From: "mattock (Code Review)" Date: Wed, 22 Jan 2025 15:20:06 +0000 In-Reply-To: References: Reply-To: samuli@...515..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641..., gert@...1296... Message-ID: <37b2cb3ec1ee8e353e8ee638107d64b1515954b8-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="7BiYtujuqGg="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: Add lwip support to t_server_null List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: cron2 , flichtenheld , plaisthos , openvpn-devel --7BiYtujuqGg= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: cron2, flichtenheld, plaisthos. mattock has posted comments on this change. ( http://gerrit.openvpn.net/c/o= penvpn/+/811?usp=3Demail ) Change subject: Add lwip support to t_server_null ...................................................................... Patch Set 9: (2 comments) File tests/t_server_null_client.sh: http://gerrit.openvpn.net/c/openvpn/+/811/comment/20dab47b_dd38af2d : PS8, Line 138: server_pid=3D$(cat "$i.pid" 2> /dev/null) > this looks like an unrelated change... [=E2=80=A6] Yes, that seems to be the case. I recall the extra "tr" was required on one= of the BSDs which added whitespace before or after "wc -w" output. Why it = worked before (or maybe it did not?) I do not know. The latter part was probably just me fixing a small inconsistency when I sa= w it. Both can be split into a separate, trivial patch if we want. http://gerrit.openvpn.net/c/openvpn/+/811/comment/c6b7e77a_aaf98854 : PS8, Line 173: $RUN_SUDO rm -f ./*.ips > running `sudo rm -f` gives me the creeps, tbh, though I see no obvious wa= y this could explode (today [=E2=80=A6] I believe you're correct. If RUN_SUDO was needed for some corner-case I wou= ld probably have added a comment explaining that. I removed RUN_SUDO and ran the code through Buildbot and manually on FreeBS= D 14 and NetBSD 10. It still behaved as one would expect. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/811?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ie63f302402f469c3aa48ac146ca6b8c029f0d250 Gerrit-Change-Number: 811 Gerrit-PatchSet: 9 Gerrit-Owner: mattock Gerrit-Reviewer: cron2 Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: cron2 Gerrit-Attention: flichtenheld Gerrit-Comment-Date: Wed, 22 Jan 2025 15:20:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: cron2 Gerrit-MessageType: comment --7BiYtujuqGg= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: cron2, flichtenheld, plaisthos. <= /p>

View C= hange

2 comments:

    =
  • File tests/t_server_null_client.sh:=

    • Patch Set #8, Line= 138: server_pi= d=3D$(cat "$i.pid" 2> /dev/null)

      this lo= oks like an unrelated change... [=E2=80=A6]

      Yes, that seems to be the case.= I recall the extra "tr" was required on one of the BSDs which ad= ded whitespace before or after "wc -w" output. Why it worked befo= re (or maybe it did not?) I do not know.

      The latter part was probably just me fixing a s= mall inconsistency when I saw it.

      Both can be split into a separate, trivial patch if we= want.

    • Patch Set #8, Line 173: $RUN_SUDO rm -f ./*.ips

      runn= ing `sudo rm -f` gives me the creeps, tbh, though I see no obvious way this= could explode (today [=E2=80=A6]

      I believe you're correct. If RUN_SUDO= was needed for some corner-case I would probably have added a comment expl= aining that.

      = I removed RUN_SUDO and ran the code through Buildbot and manually on FreeBS= D 14 and NetBSD 10. It still behaved as one would expect.

To view, visit change 811. To unsubscribe, or for help writing mail fil= ters, visit settings.

<= meta itemprop=3D"name" content=3D"View Change"/>
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ie63f302402f469c3aa48ac146ca= 6b8c029f0d250
Gerrit-Change-Number: 811
Gerrit-PatchSet: 9
Gerrit-Owner: mattock <samuli@...515...>=
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: cron2 <gert@...1296...>= ;
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Comment-Date: Wed, 22 Jan 2025 15:20:06= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: cron2 <gert@...1296...= >
Gerrit-MessageType: comment
--7BiYtujuqGg=--