From: Maarten Lankhorst Subject: Re: [PATCH v2 1/8] drm/i915: Fix unsigned overflow when calculating total data rate Date: Fri, 19 Oct 2018 14:58:07 +0200 Message-ID: <37dfab3f-b4ec-aee0-d103-0b2498026307@linux.intel.com> References: <20181018115134.9061-1-maarten.lankhorst@linux.intel.com> <20181018115134.9061-2-maarten.lankhorst@linux.intel.com> <20181018145313.GJ9144@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id AD2156E356 for ; Fri, 19 Oct 2018 12:58:10 +0000 (UTC) In-Reply-To: <20181018145313.GJ9144@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T3AgMTgtMTAtMTggb20gMTY6NTMgc2NocmVlZiBWaWxsZSBTeXJqw6Rsw6Q6Cj4gT24gVGh1LCBP Y3QgMTgsIDIwMTggYXQgMDE6NTE6MjdQTSArMDIwMCwgTWFhcnRlbiBMYW5raG9yc3Qgd3JvdGU6 Cj4+IE9uIGdlbjExLCB3ZSBjYW4gZGVmaW5pdGVseSBzbWFzaCB0aGUgMzItYml0cyBiYXJyaWVy IHdpdGgganVzdCBhCj4+IHdoZW4gd2UgZW5hYmxlIGFsbCBwbGFuZXMgaW4gdGhlIG5leHQgcGF0 Y2guCj4+Cj4+IFNpZ25lZC1vZmYtYnk6IE1hYXJ0ZW4gTGFua2hvcnN0IDxtYWFydGVuLmxhbmto b3JzdEBsaW51eC5pbnRlbC5jb20+Cj4gSSBndWVzcyB0aGUgcGVyLXBsYW5lIGRhdGEgcmF0ZSBp cyBzdGlsbCA8MzJiaXQgKGJlY2F1c2UgaXQgZG9lc24ndAo+IGFjY291bnQgZm9yIHRoZSByZWZy ZXNoIHJhdGUpLiBCdXQgbWFraW5nIGV2ZXJ5dGhpbmcgNjRiaXQgc2VlbXMgc2FmZXN0LgpXaXRo IHRoZSBjdXJyZW50IGxpbWl0cywgd2UncmUgYWxyZWFkeSBhd2Z1bGx5IGNsb3NlIGlmIHdlIGV2 ZXIgZW5kIHVwIHdpdGggMTYgYml0cyBwZXIgY29tcG9uZW50IGZvcm1hdHMuCj4gUmV2aWV3ZWQt Ynk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4KPiBO b3cgd2UgY291bGQgYWxzbyBpbXByb3ZlIHRoZSBwZXItcGxhbmUgZGF0YSByYXRlIHRvIGluY2x1 ZGUgdGhlCj4gcmVmcmVzaCByYXRlIGFuZCBnZXQgcmlkIG9mIGluYWNjdXJhdGUgZHJtX21vZGVf dnJlZnJlc2goKSBpbiB0aGVyZS4KWWVhaCB3b3VsZCBiZSBuaWNlLiA6KQo+PiAtLS0KPj4gIGRy aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMgfCA0NyArKysrKysrKysrKysrKystLS0tLS0t LS0tLS0tLS0tLS0KPj4gIDEgZmlsZSBjaGFuZ2VkLCAyMiBpbnNlcnRpb25zKCspLCAyNSBkZWxl dGlvbnMoLSkKPj4KPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Bt LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wbS5jCj4+IGluZGV4IDY3YTRkMDczNTI5 MS4uM2IxMzZmZGZkMjRmIDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9wbS5jCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMKPj4gQEAgLTM3 ODQsNyArMzc4NCw3IEBAIGJvb2wgaW50ZWxfY2FuX2VuYWJsZV9zYWd2KHN0cnVjdCBkcm1fYXRv bWljX3N0YXRlICpzdGF0ZSkKPj4gIAo+PiAgc3RhdGljIHUxNiBpbnRlbF9nZXRfZGRiX3NpemUo c3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+PiAgCQkJICAgICAgY29uc3Qgc3Ry dWN0IGludGVsX2NydGNfc3RhdGUgKmNzdGF0ZSwKPj4gLQkJCSAgICAgIGNvbnN0IHVuc2lnbmVk IGludCB0b3RhbF9kYXRhX3JhdGUsCj4+ICsJCQkgICAgICBjb25zdCB1NjQgdG90YWxfZGF0YV9y YXRlLAo+PiAgCQkJICAgICAgY29uc3QgaW50IG51bV9hY3RpdmUsCj4+ICAJCQkgICAgICBzdHJ1 Y3Qgc2tsX2RkYl9hbGxvY2F0aW9uICpkZGIpCj4+ICB7Cj4+IEBAIC0zNzk4LDEyICszNzk4LDEy IEBAIHN0YXRpYyB1MTYgaW50ZWxfZ2V0X2RkYl9zaXplKHN0cnVjdCBkcm1faTkxNV9wcml2YXRl ICpkZXZfcHJpdiwKPj4gIAkJcmV0dXJuIGRkYl9zaXplIC0gNDsgLyogNCBibG9ja3MgZm9yIGJ5 cGFzcyBwYXRoIGFsbG9jYXRpb24gKi8KPj4gIAo+PiAgCWFkanVzdGVkX21vZGUgPSAmY3N0YXRl LT5iYXNlLmFkanVzdGVkX21vZGU7Cj4+IC0JdG90YWxfZGF0YV9idyA9ICh1NjQpdG90YWxfZGF0 YV9yYXRlICogZHJtX21vZGVfdnJlZnJlc2goYWRqdXN0ZWRfbW9kZSk7Cj4+ICsJdG90YWxfZGF0 YV9idyA9IHRvdGFsX2RhdGFfcmF0ZSAqIGRybV9tb2RlX3ZyZWZyZXNoKGFkanVzdGVkX21vZGUp Owo+PiAgCj4+ICAJLyoKPj4gIAkgKiAxMkdCL3MgaXMgbWF4aW11bSBCVyBzdXBwb3J0ZWQgYnkg c2luZ2xlIERCdWYgc2xpY2UuCj4+ICAJICovCj4+IC0JaWYgKHRvdGFsX2RhdGFfYncgPj0gR0Jw cygxMikgfHwgbnVtX2FjdGl2ZSA+IDEpIHsKPj4gKwlpZiAobnVtX2FjdGl2ZSA+IDEgfHwgdG90 YWxfZGF0YV9idyA+PSBHQnBzKDEyKSkgewo+PiAgCQlkZGItPmVuYWJsZWRfc2xpY2VzID0gMjsK Pj4gIAl9IGVsc2Ugewo+PiAgCQlkZGItPmVuYWJsZWRfc2xpY2VzID0gMTsKPj4gQEAgLTM4MTYs NyArMzgxNiw3IEBAIHN0YXRpYyB1MTYgaW50ZWxfZ2V0X2RkYl9zaXplKHN0cnVjdCBkcm1faTkx NV9wcml2YXRlICpkZXZfcHJpdiwKPj4gIHN0YXRpYyB2b2lkCj4+ICBza2xfZGRiX2dldF9waXBl X2FsbG9jYXRpb25fbGltaXRzKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4+ICAJCQkJICAgY29u c3Qgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNzdGF0ZSwKPj4gLQkJCQkgICBjb25zdCB1bnNp Z25lZCBpbnQgdG90YWxfZGF0YV9yYXRlLAo+PiArCQkJCSAgIGNvbnN0IHU2NCB0b3RhbF9kYXRh X3JhdGUsCj4+ICAJCQkJICAgc3RydWN0IHNrbF9kZGJfYWxsb2NhdGlvbiAqZGRiLAo+PiAgCQkJ CSAgIHN0cnVjdCBza2xfZGRiX2VudHJ5ICphbGxvYywgLyogb3V0ICovCj4+ICAJCQkJICAgaW50 ICpudW1fYWN0aXZlIC8qIG91dCAqLykKPj4gQEAgLTQxMzksNyArNDEzOSw3IEBAIGludCBza2xf Y2hlY2tfcGlwZV9tYXhfcGl4ZWxfcmF0ZShzdHJ1Y3QgaW50ZWxfY3J0YyAqaW50ZWxfY3J0YywK Pj4gIAlyZXR1cm4gMDsKPj4gIH0KPj4gIAo+PiAtc3RhdGljIHVuc2lnbmVkIGludAo+PiArc3Rh dGljIHU2NAo+PiAgc2tsX3BsYW5lX3JlbGF0aXZlX2RhdGFfcmF0ZShjb25zdCBzdHJ1Y3QgaW50 ZWxfY3J0Y19zdGF0ZSAqY3N0YXRlLAo+PiAgCQkJICAgICBjb25zdCBzdHJ1Y3QgZHJtX3BsYW5l X3N0YXRlICpwc3RhdGUsCj4+ICAJCQkgICAgIGNvbnN0IGludCBwbGFuZSkKPj4gQEAgLTQxNTEs NiArNDE1MSw3IEBAIHNrbF9wbGFuZV9yZWxhdGl2ZV9kYXRhX3JhdGUoY29uc3Qgc3RydWN0IGlu dGVsX2NydGNfc3RhdGUgKmNzdGF0ZSwKPj4gIAlzdHJ1Y3QgZHJtX2ZyYW1lYnVmZmVyICpmYjsK Pj4gIAl1MzIgZm9ybWF0Owo+PiAgCXVpbnRfZml4ZWRfMTZfMTZfdCBkb3duX3NjYWxlX2Ftb3Vu dDsKPj4gKwl1NjQgcmF0ZTsKPj4gIAo+PiAgCWlmICghaW50ZWxfcHN0YXRlLT5iYXNlLnZpc2li bGUpCj4+ICAJCXJldHVybiAwOwo+PiBAQCAtNDE3NywyOCArNDE3OCwyNiBAQCBza2xfcGxhbmVf cmVsYXRpdmVfZGF0YV9yYXRlKGNvbnN0IHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjc3RhdGUs Cj4+ICAJCWhlaWdodCAvPSAyOwo+PiAgCX0KPj4gIAo+PiAtCWRhdGFfcmF0ZSA9IHdpZHRoICog aGVpZ2h0ICogZmItPmZvcm1hdC0+Y3BwW3BsYW5lXTsKPj4gKwlkYXRhX3JhdGUgPSB3aWR0aCAq IGhlaWdodDsKPj4gIAo+PiAgCWRvd25fc2NhbGVfYW1vdW50ID0gc2tsX3BsYW5lX2Rvd25zY2Fs ZV9hbW91bnQoY3N0YXRlLCBpbnRlbF9wc3RhdGUpOwo+PiAgCj4+IC0JcmV0dXJuIG11bF9yb3Vu ZF91cF91MzJfZml4ZWQxNihkYXRhX3JhdGUsIGRvd25fc2NhbGVfYW1vdW50KTsKPj4gKwlyYXRl ID0gbXVsX3JvdW5kX3VwX3UzMl9maXhlZDE2KGRhdGFfcmF0ZSwgZG93bl9zY2FsZV9hbW91bnQp Owo+PiArCj4+ICsJcmF0ZSAqPSBmYi0+Zm9ybWF0LT5jcHBbcGxhbmVdOwo+PiArCXJldHVybiBy YXRlOwo+PiAgfQo+PiAgCj4+IC0vKgo+PiAtICogV2UgZG9uJ3Qgb3ZlcmZsb3cgMzIgYml0cy4g V29yc3QgY2FzZSBpcyAzIHBsYW5lcyBlbmFibGVkLCBlYWNoIGZldGNoaW5nCj4+IC0gKiBhIDgx OTJ4NDA5NkAzMmJwcCBmcmFtZWJ1ZmZlcjoKPj4gLSAqICAgMyAqIDQwOTYgKiA4MTkyICAqIDQg PCAyXjMyCj4+IC0gKi8KPj4gLXN0YXRpYyB1bnNpZ25lZCBpbnQKPj4gK3N0YXRpYyB1NjQKPj4g IHNrbF9nZXRfdG90YWxfcmVsYXRpdmVfZGF0YV9yYXRlKHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRl ICppbnRlbF9jc3RhdGUsCj4+IC0JCQkJIHVuc2lnbmVkIGludCAqcGxhbmVfZGF0YV9yYXRlLAo+ PiAtCQkJCSB1bnNpZ25lZCBpbnQgKnV2X3BsYW5lX2RhdGFfcmF0ZSkKPj4gKwkJCQkgdTY0ICpw bGFuZV9kYXRhX3JhdGUsCj4+ICsJCQkJIHU2NCAqdXZfcGxhbmVfZGF0YV9yYXRlKQo+PiAgewo+ PiAgCXN0cnVjdCBkcm1fY3J0Y19zdGF0ZSAqY3N0YXRlID0gJmludGVsX2NzdGF0ZS0+YmFzZTsK Pj4gIAlzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqc3RhdGUgPSBjc3RhdGUtPnN0YXRlOwo+PiAg CXN0cnVjdCBkcm1fcGxhbmUgKnBsYW5lOwo+PiAgCWNvbnN0IHN0cnVjdCBkcm1fcGxhbmVfc3Rh dGUgKnBzdGF0ZTsKPj4gLQl1bnNpZ25lZCBpbnQgdG90YWxfZGF0YV9yYXRlID0gMDsKPj4gKwl1 NjQgdG90YWxfZGF0YV9yYXRlID0gMDsKPj4gIAo+PiAgCWlmIChXQVJOX09OKCFzdGF0ZSkpCj4+ ICAJCXJldHVybiAwOwo+PiBAQCAtNDIwNiw3ICs0MjA1LDcgQEAgc2tsX2dldF90b3RhbF9yZWxh dGl2ZV9kYXRhX3JhdGUoc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmludGVsX2NzdGF0ZSwKPj4g IAkvKiBDYWxjdWxhdGUgYW5kIGNhY2hlIGRhdGEgcmF0ZSBmb3IgZWFjaCBwbGFuZSAqLwo+PiAg CWRybV9hdG9taWNfY3J0Y19zdGF0ZV9mb3JfZWFjaF9wbGFuZV9zdGF0ZShwbGFuZSwgcHN0YXRl LCBjc3RhdGUpIHsKPj4gIAkJZW51bSBwbGFuZV9pZCBwbGFuZV9pZCA9IHRvX2ludGVsX3BsYW5l KHBsYW5lKS0+aWQ7Cj4+IC0JCXVuc2lnbmVkIGludCByYXRlOwo+PiArCQl1NjQgcmF0ZTsKPj4g IAo+PiAgCQkvKiBwYWNrZWQveSAqLwo+PiAgCQlyYXRlID0gc2tsX3BsYW5lX3JlbGF0aXZlX2Rh dGFfcmF0ZShpbnRlbF9jc3RhdGUsCj4+IEBAIC00MzI1LDExICs0MzI0LDExIEBAIHNrbF9hbGxv Y2F0ZV9waXBlX2RkYihzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqY3N0YXRlLAo+PiAgCXVpbnQx Nl90IGFsbG9jX3NpemUsIHN0YXJ0Owo+PiAgCXVpbnQxNl90IG1pbmltdW1bSTkxNV9NQVhfUExB TkVTXSA9IHt9Owo+PiAgCXVpbnQxNl90IHV2X21pbmltdW1bSTkxNV9NQVhfUExBTkVTXSA9IHt9 Owo+PiAtCXVuc2lnbmVkIGludCB0b3RhbF9kYXRhX3JhdGU7Cj4+ICsJdTY0IHRvdGFsX2RhdGFf cmF0ZTsKPj4gIAllbnVtIHBsYW5lX2lkIHBsYW5lX2lkOwo+PiAgCWludCBudW1fYWN0aXZlOwo+ PiAtCXVuc2lnbmVkIGludCBwbGFuZV9kYXRhX3JhdGVbSTkxNV9NQVhfUExBTkVTXSA9IHt9Owo+ PiAtCXVuc2lnbmVkIGludCB1dl9wbGFuZV9kYXRhX3JhdGVbSTkxNV9NQVhfUExBTkVTXSA9IHt9 Owo+PiArCXU2NCBwbGFuZV9kYXRhX3JhdGVbSTkxNV9NQVhfUExBTkVTXSA9IHt9Owo+PiArCXU2 NCB1dl9wbGFuZV9kYXRhX3JhdGVbSTkxNV9NQVhfUExBTkVTXSA9IHt9Owo+PiAgCXVpbnQxNl90 IHRvdGFsX21pbl9ibG9ja3MgPSAwOwo+PiAgCj4+ICAJLyogQ2xlYXIgdGhlIHBhcnRpdGlvbmlu ZyBmb3IgZGlzYWJsZWQgcGxhbmVzLiAqLwo+PiBAQCAtNDM4OCw3ICs0Mzg3LDcgQEAgc2tsX2Fs bG9jYXRlX3BpcGVfZGRiKHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjc3RhdGUsCj4+ICAKPj4g IAlzdGFydCA9IGFsbG9jLT5zdGFydDsKPj4gIAlmb3JfZWFjaF9wbGFuZV9pZF9vbl9jcnRjKGlu dGVsX2NydGMsIHBsYW5lX2lkKSB7Cj4+IC0JCXVuc2lnbmVkIGludCBkYXRhX3JhdGUsIHV2X2Rh dGFfcmF0ZTsKPj4gKwkJdTY0IGRhdGFfcmF0ZSwgdXZfZGF0YV9yYXRlOwo+PiAgCQl1aW50MTZf dCBwbGFuZV9ibG9ja3MsIHV2X3BsYW5lX2Jsb2NrczsKPj4gIAo+PiAgCQlpZiAocGxhbmVfaWQg PT0gUExBTkVfQ1VSU09SKQo+PiBAQCAtNDQwMiw4ICs0NDAxLDcgQEAgc2tsX2FsbG9jYXRlX3Bp cGVfZGRiKHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjc3RhdGUsCj4+ICAJCSAqIHJlc3VsdCBp cyA8IGF2YWlsYWJsZSBhcyBkYXRhX3JhdGUgLyB0b3RhbF9kYXRhX3JhdGUgPCAxCj4+ICAJCSAq Lwo+PiAgCQlwbGFuZV9ibG9ja3MgPSBtaW5pbXVtW3BsYW5lX2lkXTsKPj4gLQkJcGxhbmVfYmxv Y2tzICs9IGRpdl91NjQoKHVpbnQ2NF90KWFsbG9jX3NpemUgKiBkYXRhX3JhdGUsCj4+IC0JCQkJ CXRvdGFsX2RhdGFfcmF0ZSk7Cj4+ICsJCXBsYW5lX2Jsb2NrcyArPSBhbGxvY19zaXplICogZGF0 YV9yYXRlIC8gdG90YWxfZGF0YV9yYXRlOwo+PiAgCj4+ICAJCS8qIExlYXZlIGRpc2FibGVkIHBs YW5lcyBhdCAoMCwwKSAqLwo+PiAgCQlpZiAoZGF0YV9yYXRlKSB7Cj4+IEBAIC00NDE3LDggKzQ0 MTUsNyBAQCBza2xfYWxsb2NhdGVfcGlwZV9kZGIoc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNz dGF0ZSwKPj4gIAkJdXZfZGF0YV9yYXRlID0gdXZfcGxhbmVfZGF0YV9yYXRlW3BsYW5lX2lkXTsK Pj4gIAo+PiAgCQl1dl9wbGFuZV9ibG9ja3MgPSB1dl9taW5pbXVtW3BsYW5lX2lkXTsKPj4gLQkJ dXZfcGxhbmVfYmxvY2tzICs9IGRpdl91NjQoKHVpbnQ2NF90KWFsbG9jX3NpemUgKiB1dl9kYXRh X3JhdGUsCj4+IC0JCQkJCSAgIHRvdGFsX2RhdGFfcmF0ZSk7Cj4+ICsJCXV2X3BsYW5lX2Jsb2Nr cyArPSBhbGxvY19zaXplICogdXZfZGF0YV9yYXRlIC8gdG90YWxfZGF0YV9yYXRlOwo+PiAgCj4+ ICAJCWlmICh1dl9kYXRhX3JhdGUpIHsKPj4gIAkJCWRkYi0+dXZfcGxhbmVbcGlwZV1bcGxhbmVf aWRdLnN0YXJ0ID0gc3RhcnQ7Cj4+IC0tIAo+PiAyLjE5LjEKPj4KPj4gX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlz dAo+PiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4+IGh0dHBzOi8vbGlzdHMuZnJl ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4CgoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJ bnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==