From: Neil Armstrong Date: Mon, 20 Apr 2020 15:49:01 +0200 Subject: [PATCH] usb: dwc3-meson-g12a: add power-on/off of the PHYs In-Reply-To: <06638a20-abe1-6991-8dc9-b24f50d59bfd@denx.de> References: <20200420134601.19863-1-narmstrong@baylibre.com> <06638a20-abe1-6991-8dc9-b24f50d59bfd@denx.de> Message-ID: <38fc9ea1-2ea4-bb83-55de-b3c12356c4eb@baylibre.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 20/04/2020 15:47, Marek Vasut wrote: > On 4/20/20 3:46 PM, Neil Armstrong wrote: >> Power on/off the PHYs to enable power to the USB ports, fixing USB support >> on Khadas VIM3/VIM3L boards. >> >> Signed-off-by: Neil Armstrong >> --- >> drivers/usb/dwc3/dwc3-meson-g12a.c | 16 ++++++++++++++++ >> 1 file changed, 16 insertions(+) >> >> diff --git a/drivers/usb/dwc3/dwc3-meson-g12a.c b/drivers/usb/dwc3/dwc3-meson-g12a.c >> index d4453f8784..8f4a2f3f82 100644 >> --- a/drivers/usb/dwc3/dwc3-meson-g12a.c >> +++ b/drivers/usb/dwc3/dwc3-meson-g12a.c >> @@ -408,6 +408,15 @@ static int dwc3_meson_g12a_probe(struct udevice *dev) >> goto err_phy_init; >> } >> >> + for (i = 0 ; i < PHY_COUNT ; ++i) { > > Doesn't checkpatch complain about this extra space before semicolon ? Nop, even in --strict > >> + if (!priv->phys[i].dev) >> + continue; >> + >> + ret = generic_phy_power_on(&priv->phys[i]); > > Do we really need to turn on all the PHYs ? > Yes Neil