From: "flichtenheld (Code Review)" Date: Thu, 15 Jan 2026 17:44:22 +0000 In-Reply-To: References: Reply-To: frank@...2641..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, steffan@...1856..., max@...2606... Message-ID: <394453ae9ebf6b37b1a55572902356b3708bce00-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="7fzqtGSD0zo="; charset=UTF-8 Subject: [Openvpn-devel] [XL] Change in openvpn[master]: Add support for Mbed TLS 4 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: MaxF Cc: syzzer , plaisthos , openvpn-devel --7fzqtGSD0zo= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: MaxF, plaisthos, syzzer. flichtenheld has posted comments on this change by MaxF. ( http://gerrit.op= envpn.net/c/openvpn/+/1441?usp=3Demail ) Change subject: Add support for Mbed TLS 4 ...................................................................... Patch Set 5: (1 comment) Patchset: PS5: > The reason for the first error is what it says on the tin: Mbed TLS 4 jus= t doesn't have a function t [=E2=80=A6] Good questions regarding --dh. Not sure what is the best solution. Maybe so= mething to discuss in an IRC meeting? Fix for the second failure should be trivial pre-processor fix. Just do not= emit this code when it is unused. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1441?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ib251d546d993b96ed3bd8cb9111bcc627cdb0fae Gerrit-Change-Number: 1441 Gerrit-PatchSet: 5 Gerrit-Owner: MaxF Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-CC: syzzer Gerrit-Attention: syzzer Gerrit-Attention: plaisthos Gerrit-Attention: MaxF Gerrit-Comment-Date: Thu, 15 Jan 2026 17:44:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld Comment-In-Reply-To: MaxF --7fzqtGSD0zo= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is cur= rently required from: MaxF, plaisthos, syzzer.

View = Change

1 comment:

    =
  • Patchset:

    • Patch Set #5:

      The = reason for the first error is what it says on the tin: Mbed TLS 4 just does= n't have a function t [=E2=80=A6]

      Good questions regar= ding --dh. Not sure what is the best solution. Maybe something to discuss i= n an IRC meeting?

      Fix for the second failure should be trivial pre-proc= essor fix. Just do not emit this code when it is unused.

  • =

To view, visit change 1441. To unsubscribe, or for help writing mail fi= lters, visit set= tings.

=
Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ib251d546d993b96ed3bd8cb9111= bcc627cdb0fae
Gerrit-Change-Number: 1441
Gerrit-PatchSet: 5
Gerrit-Owner: MaxF <max@...2606...>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-CC: syzzer <steffan@...1856...> <= /div>
Gerrit-Attention: syzzer <steffan@...2115...= .>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: MaxF <max@...2606...> =
Gerrit-Comment-Date: Thu, 15 Jan 2026 17:44:22= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld <frank@...1186...= .2641...>
Comment-In-Reply-To: MaxF <max@...2606...&g= t;
= --7fzqtGSD0zo=--