Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CF9EEC3A59D for ; Mon, 24 Oct 2022 00:45:29 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1A0FA849F1; Mon, 24 Oct 2022 02:45:27 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=benettiengineering.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=aruba.it header.i=@aruba.it header.b="fV6dkRIl"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9579A838D9; Mon, 24 Oct 2022 02:45:24 +0200 (CEST) Received: from smtpcmd0987.aruba.it (smtpcmd0987.aruba.it [62.149.156.87]) by phobos.denx.de (Postfix) with ESMTP id B0D84849F1 for ; Mon, 24 Oct 2022 02:45:21 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=benettiengineering.com Authentication-Results: phobos.denx.de; spf=none smtp.mailfrom=giulio.benetti@benettiengineering.com Received: from smtpclient.apple ([146.241.87.206]) by Aruba Outgoing Smtp with ESMTPA id mlaioSWuRaWj1mlaio6eK8; Mon, 24 Oct 2022 02:45:21 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aruba.it; s=a1; t=1666572321; bh=HQaGJKvhlwmeMOXIfBNSJRr12abWbeonGNPKgIZDDpA=; h=Content-Type:From:Mime-Version:Subject:Date:To; b=fV6dkRIliAZh+R8g6VIyBAiF5QJV1Q5Fp4iRbqrs59pN8tBi7UOULjVZf/7tPmE+y sQ3DC1Njume4lTUnz+JFyVmbM/3YLWfiMjemPEQbuNhkHeYWnH8shz9P0SFt5V2BB1 6Bl63X4049MBzDao1ChvuspLdbsRyw1mtximR3QbQDUrLhVXZW4k3/mzpH7+tKLxXP 0NLxfIvNGd+SI2ok5S1goobn/hEUTTHh+ze5TlOjrFZkrMEl4y72lN+TZx9Z+QV6Su aJm+GQr1S0VZIECnpkQAGvA6yCT7owGJqcWrWpE/vq/nb9+TPDjRnPlVQ2ZB9TvI+0 sCstmWojLZzbA== Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: Giulio Benetti Mime-Version: 1.0 (1.0) Subject: Re: [PATCH v3 2/8] imxrt1020: fix lpuart issue in common u-boot device tree Date: Mon, 24 Oct 2022 02:45:08 +0200 Message-Id: <3949AF3D-650A-4283-B3C4-E85FD9FF20DF@benettiengineering.com> References: <71315cca2987acaf52678f26c4c6874bf4681ab9.camel@toradex.com> Cc: u-boot@lists.denx.de, festevam@gmail.com, uboot-imx@nxp.com, sbabic@denx.de, Mr.Bossman075@gmail.com In-Reply-To: <71315cca2987acaf52678f26c4c6874bf4681ab9.camel@toradex.com> To: Marcel Ziswiler X-Mailer: iPhone Mail (20A392) X-CMAE-Envelope: MS4xfP90aL5AMy1jyyQVfJiQDM35Gl8wuUm+3WqBG4/99xHA4sZI1RysM3n58P2YnIYrOjjRBwP0QdkIy//6Leh3yPfjLJM3elRW/PlsSI6eBHJAV3q5JnrW mvvwwMlBZbfPFvJOY8tbZ1HeLCWkYU+A49lSKGOy60b6fDy/xjsBjuDlcxQUadpw2ylnOzdCSKhZOf4GDaSwZhEFnGHvWyy18e4thXhO74ALKtX5g1H6i1fe dYITVMNeAvxF2WUYqAzjm/30gK5chS/wkjvdinXB42rmHdQI5EuA8/fEqbInJPVWiL/GIDvjaHDgYwcquoGAOkhC9BCnLckEjB2oAfEuxVxaiKtHQUd+U/ME MHGBaEbeb8hdbJfDMZJPceUcAcirEg== X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi Marcel, > Il giorno 24 ott 2022, alle ore 00:01, Marcel Ziswiler ha scritto: >=20 > =EF=BB=BFHi Giulio >=20 >> On Sun, 2022-10-23 at 01:32 +0200, Giulio Benetti wrote: >> Hi Marcel, >>=20 >> thanks for contributing, >=20 > You are very welcome. >=20 >> Il 22/10/2022 23:42, Marcel Ziswiler ha scritto: >>> From: Marcel Ziswiler >>>=20 >>> Fix lpuart issue in common U-Boot device tree. >>=20 >> There's no need to repeat in commit log the subject. >=20 > Well, most maintainers do want an actual commit message and won't accept i= t being empty. For trivial commits > like this one it is quite common to therefore just repeat the subject. You=E2=80=99re right, this is project dependent, here in uboot they want it l= ike that. >=20 >>> Signed-off-by: Marcel Ziswiler >>> --- >>>=20 >>> (no changes since v1) >>>=20 >>> arch/arm/dts/imxrt1020-evk-u-boot.dtsi | 7 ++++--- >>> arch/arm/dts/imxrt1020-evk.dts | 1 - >>> 2 files changed, 4 insertions(+), 4 deletions(-) >>>=20 >>> diff --git a/arch/arm/dts/imxrt1020-evk-u-boot.dtsi b/arch/arm/dts/imxrt= 1020-evk-u-boot.dtsi >>> index 9e1b074d2e..7cab486f5f 100644 >>> --- a/arch/arm/dts/imxrt1020-evk-u-boot.dtsi >>> +++ b/arch/arm/dts/imxrt1020-evk-u-boot.dtsi >>> @@ -67,9 +67,6 @@ >>> =20 >>> imxrt1020-evk { >>> u-boot,dm-spl; >>> - pinctrl_lpuart1: lpuart1grp { >>> - u-boot,dm-spl; >>> - }; >>> =20 >>> pinctrl_semc: semcgrp { >>> u-boot,dm-spl; >>> @@ -81,6 +78,10 @@ >>> }; >>> }; >>> =20 >>> +&pinctrl_lpuart1 { >>> + u-boot,dm-spl; >>> +}; >>> + >>=20 >> I don't understand the goal of this change, can you elaborate? >=20 > Well, the goal is to use them Linux kernel device trees and have any requi= red changes in such -u-boot.dtsi > device tree include files. As such we may just reference resp. node by its= handle and subsequently add that U- > Boot specific property. Ah yes and >=20 >> As I remember pinctrl_lpuart1 already works correctly. The same goes >> for: >> pinctrl_semc >> pinctrl_usdhc0 >>=20 >> So you're not fixing something. >=20 > Well, I am basically fixing it for when them device trees get synchronised= from the Linux kernel. One may > basically consider out-of-synch device trees being an issue in need of fix= ing. Yes. Can you please add this explanation in commit log? It=E2=80=99s easier t= o keep track and to review too. >=20 >>> &usdhc1 { >>> u-boot,dm-spl; >>> }; >>> diff --git a/arch/arm/dts/imxrt1020-evk.dts b/arch/arm/dts/imxrt1020-evk= .dts >>> index 22ae5ed735..d4d1de4ea8 100644 >>> --- a/arch/arm/dts/imxrt1020-evk.dts >>> +++ b/arch/arm/dts/imxrt1020-evk.dts >>> @@ -6,7 +6,6 @@ >>> =20 >>> /dts-v1/; >>> #include "imxrt1020.dtsi" >>> -#include "imxrt1020-evk-u-boot.dtsi" >>=20 >> This ^^^ is needed, please revert it. >=20 > No, you do not understand. We just synchronise them device trees from the L= inux kernel. Nothing should ever be > changed here. Any and all U-Boot specific changes need to go into the -u-b= oot.dtsi device tree include files > which BTW get included automatically by the U-Boot build system. This has been changed during time. Can you please add this note too in commi= t log? >=20 >>> #include "imxrt1020-pinfunc.h" >>> =20 >>> / { >>=20 >> Have you also tested the change on a board? >=20 > As outlined in the cover letter I did not test each and every board as I d= o not have them all available. If you > do have some of those boards available I would appreciate you giving it a t= ry. Yes I do have 1020 so I can give a try of V4. Best regards Giulio >=20 > Thanks! >=20 >> Best regards >> --=20 >> Giulio Benetti >> CEO/CTO@Benetti Engineering sas >=20 > Cheers >=20 > Marcel