From: Dongdong Zhang Date: Tue, 29 Nov 2022 17:10:31 +0800 (GMT+08:00) Subject: [PATCH 1/1] firmware: Minor optimization for relocate In-Reply-To: References: <20221129035407.28946-1-zhangdongdong@eswincomputing.com> <20221129035407.28946-2-zhangdongdong@eswincomputing.com> Message-ID: <3960020f.aa5e.184c2a6f2c1.Coremail.zhangdongdong@eswincomputing.com> List-Id: To: opensbi@lists.infradead.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Hi, Bin Thank you for your review, and I will pay attention to the style of the commit message next time. > -----????-----???:"Bin Meng" ????:2022-11-29 15:51:33 (???)???:"Dongdong Zhang" ??:opensbi at lists.infradead.org??:Re: [PATCH 1/1] firmware: Minor optimization for relocate > > On Tue, Nov 29, 2022 at 11:57 AM Dongdong Zhang > wrote: > > > > The t3 register stores the address of _load_end. If relocation is not required, it is unnecessary to calculate the address of _load_end. > > nits: commit messages should be written like about 70 characters per line. > > > > > This can reduce the operation time of two instructions. > > > > Signed-off-by: Dongdong Zhang > > --- > > firmware/fw_base.S | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > Reviewed-by: Bin Meng