From: "d12fk (Code Review)"
Date: Wed, 10 Jan 2024 15:47:32 +0000
In-Reply-To:
References:
Reply-To: heiko@...515..., arne-openvpn@...1227...,
openvpn-devel@lists.sourceforge.net, frank@...2641...,
gert@...1296..., lstipakov@...277...
Message-ID: <397dd26148f180cedda65089aa0307889bbc28f0-EmailReviewComments-HTML@...2715...>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="SxdvATCE3f0="; charset=UTF-8
Subject: [Openvpn-devel] [L] Change in openvpn[master]: Windows: enforce
'block-local' with WFP filters
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Cc: stipa , flichtenheld , cron2 , plaisthos , openvpn-devel
--SxdvATCE3f0=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: cron2, flichtenheld, plaisthos, stipa.
d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/ope=
nvpn/+/489?usp=3Demail )
Change subject: Windows: enforce 'block-local' with WFP filters
......................................................................
Patch Set 4:
(5 comments)
File include/openvpn-msg.h:
http://gerrit.openvpn.net/c/openvpn/+/489/comment/8bc08e9f_7c28e168 :
PS4, Line 27: #include
> why those are needed here?
They define some types used in the header. Not that all wouldn't compile wi=
thout them, but when looking at the single file (like clangd does) these un=
definedness.
File src/openvpn/route.c:
http://gerrit.openvpn.net/c/openvpn/+/489/comment/25c045e0_c6d575fc :
PS4, Line 621: do_block_local(const struct route_list *rl)
> since this function doesn't really do any blocking and only check options=
, maybe rename to "is_block [=E2=80=A6]
Done
File src/openvpn/wfp_block.c:
http://gerrit.openvpn.net/c/openvpn/+/489/comment/50237516_00bec708 :
PS4, Line 310: /* Fifth filter. Permit IPv4 for the VPN interface.
> Permit DNS or all IPv4 traffic for the VPN interface?
Done
http://gerrit.openvpn.net/c/openvpn/+/489/comment/7e9bc610_f12f2c41 :
PS4, Line 327: /* Sixth filter. Permit IPv6 for the VPN interface.
> Same as above - Permit DNS or all IPv6 traffic for the VPN interface?
Done
File src/openvpn/win32.h:
http://gerrit.openvpn.net/c/openvpn/+/489/comment/fff56b45_305383c8 :
PS4, Line 28: #include
> why those changes?
They define some types used in the header. Not that all wouldn't compile wi=
thout them, but when looking at the single file (like clangd does) these un=
definedness.
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/489?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ic9bf797bfc7e2d471998a84cb0f071db3e4832ba
Gerrit-Change-Number: 489
Gerrit-PatchSet: 4
Gerrit-Owner: d12fk
Gerrit-Reviewer: flichtenheld
Gerrit-Reviewer: plaisthos
Gerrit-CC: cron2
Gerrit-CC: openvpn-devel
Gerrit-CC: stipa
Gerrit-Attention: plaisthos
Gerrit-Attention: cron2
Gerrit-Attention: flichtenheld
Gerrit-Attention: stipa
Gerrit-Comment-Date: Wed, 10 Jan 2024 15:47:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: stipa
Gerrit-MessageType: comment
--SxdvATCE3f0=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: cron2, flichtenheld, plaisthos, s=
tipa.
View C=
hange
5 comments:
They define some types u=
sed in the header. Not that all wouldn't compile without them, but when=
looking at the single file (like clangd does) these undefinedness.
File src/openvpn/route.c=
:
File src/openvpn/wfp_block.c:
Patch Set #4, Line 310: /* Fifth filter. Permit IPv4 for the VPN interfac=
e.
Permit DNS or all IPv4 traffic for the VPN interfa=
ce?
Done
Patch Set #4, Line 327: /* Sixth filter. Permit IPv6 for the VPN int=
erface.
Same as above - Permit DNS or all IPv6 traffi=
c for the VPN interface?
Done
File src/openvpn/win32.h:
Patch Set #4, Line 28: #include <iphlpapi.h>
why t=
hose changes?
They define some types used in the header. Not that all would=
n't compile without them, but when looking at the single file (like cla=
ngd does) these undefinedness.
To view, visit change 489=
a>. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ic9bf797bfc7e2d471998a84cb0f=
071db3e4832ba
Gerrit-Change-Number: 489
Gerrit-PatchSet: 4
Gerrit-Owner: d12fk <heiko@...515...> =
div>
Gerrit-Reviewer: flichtenheld <frank@...2716...=
1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...=
.1227...>
Gerrit-CC: cron2 <gert@...1296...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...=
ts.sourceforge.net>
Gerrit-CC: stipa <lstipakov@...277...> <=
/div>
Gerrit-Attention: plaisthos <arne-openvpn@...220...=
..1227...>
Gerrit-Attention: cron2 <gert@...1296...>=
;
Gerrit-Attention: flichtenheld <frank@...2375...=
41...>
Gerrit-Attention: stipa <lstipakov@...1663...=
.>
Gerrit-Comment-Date: Wed, 10 Jan 2024 15:47:32=
+0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: stipa <lstipakov@...1664...=
7...>
Gerrit-MessageType: comment
--SxdvATCE3f0=--