Received-SPF: neutral (google.com: 212.227.126.130 is neither permitted nor denied by best guess record for domain of arnd@arndb.de) client-ip=212.227.126.130;
From: Arnd Bergmann <arnd@arndb.de>
To: y2038@lists.linaro.org
Cc: Amitoj Kaur Chawla <amitoj1606@gmail.com>, outreachy-kernel@googlegroups.com
Subject: Re: [Y2038] [PATCH 2/2] scsi: bfa: Replace struct timeval with ktime_t
Date: Wed, 04 Nov 2015 00:56:14 +0100
Message-ID: <3991598.sWF2Cv7hDN@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <5acb9a010438369d26ce6be07b8ae90974ed24f0.1446003130.git.amitoj1606@gmail.com>
References: <cover.1446003130.git.amitoj1606@gmail.com> <5acb9a010438369d26ce6be07b8ae90974ed24f0.1446003130.git.amitoj1606@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"

On Wednesday 28 October 2015 09:13:51 Amitoj Kaur Chawla wrote:
> 
> diff --git a/drivers/scsi/bfa/bfa_defs_svc.h b/drivers/scsi/bfa/bfa_defs_svc.h
> index 638f441f..e7acf41 100644
> --- a/drivers/scsi/bfa/bfa_defs_svc.h
> +++ b/drivers/scsi/bfa/bfa_defs_svc.h
> @@ -1454,7 +1454,7 @@ struct bfa_aen_entry_s {
>         enum bfa_aen_category   aen_category;
>         u32                     aen_type;
>         union bfa_aen_data_u    aen_data;
> -       struct timeval          aen_tv;
> +       ktime_t                 aen_time;
>         u32                     seq_num;
>         u32                     bfad_num;
>  };
> diff --git a/drivers/scsi/bfa/bfad_im.h b/drivers/scsi/bfa/bfad_im.h
> index f6c1023..b37fcba 100644
> --- a/drivers/scsi/bfa/bfad_im.h
> +++ b/drivers/scsi/bfa/bfad_im.h
> @@ -131,7 +131,7 @@ struct bfad_im_s {
>  
>  /* post fc_host vendor event */
>  #define bfad_im_post_vendor_event(_entry, _drv, _cnt, _cat, _evt) do {       \
> -       do_gettimeofday(&(_entry)->aen_tv);                                   \
> +       (_entry)->aen_time = ktime_get();                                     \
>         (_entry)->bfad_num = (_drv)->inst_no;                                 \
>         (_entry)->seq_num = (_cnt);                                           \
>         (_entry)->aen_category = (_cat);                                      \
> -- 
> 

This can't be right: you are only writing to the variable. If there is anyone
reading from it elsewhere, that code needs to be changed as well in the
same patch. If not, the variable can just be removed.

	Arnd