Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFA85C43467 for ; Thu, 8 Oct 2020 08:39:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A4C582083B for ; Thu, 8 Oct 2020 08:39:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726141AbgJHIjK (ORCPT ); Thu, 8 Oct 2020 04:39:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59094 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725916AbgJHIjJ (ORCPT ); Thu, 8 Oct 2020 04:39:09 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A49A5C061755 for ; Thu, 8 Oct 2020 01:39:09 -0700 (PDT) Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94) (envelope-from ) id 1kQRS7-001UWo-U5; Thu, 08 Oct 2020 10:39:08 +0200 Message-ID: <39d5d6f1a5dad25d20a45c46dffdcd45cd28286e.camel@sipsolutions.net> Subject: Re: [PATCH v2 2/2] mac80211: initialize last_rate for S1G STAs From: Johannes Berg To: Thomas Pedersen Cc: linux-wireless Date: Thu, 08 Oct 2020 10:39:02 +0200 In-Reply-To: <20201005164522.18069-2-thomas@adapt-ip.com> References: <20201005164522.18069-1-thomas@adapt-ip.com> <20201005164522.18069-2-thomas@adapt-ip.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5 (3.36.5-1.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Mon, 2020-10-05 at 09:45 -0700, Thomas Pedersen wrote: > last_rate is initialized to zero by sta_info_alloc(), but > this indicates legacy bitrate for the last TX rate (and > invalid for the last RX rate). To avoid a warning when > decoding the last rate as legacy (before a data frame > has been sent), initialize them as S1G MCS. Oh, I see, this fixes the warning ... OK, never mind, I'll just apply both. johannes