Received: from out-18.mta0.migadu.com (out-18.mta0.migadu.com [91.218.175.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D99217C7 for ; Tue, 13 Jun 2023 02:17:15 +0000 (UTC) Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1686622633; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=17ugyNFhbrwEanCoHF7v9qrJ1jJmHx/jdN9D7BRY9oE=; b=m7DmPVEXGMkpf0bo+q5pbu5oDDKH189Z/XzRq7Dih/3Dx0SQfpjZXQWTSJWS3TkVoCDoXU +v02nL8NwADRue1ybe3/uGEqr48aSC+9ZD5XlLUCSo4eNSNQeoeI8A91KFFzRGT1sCbUPr MXmvlJA1v+AC/K7Zq4kbQC18O8E8+QA= Precedence: bulk X-Mailing-List: damon@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH v3 0/3] Encapsulate PTE contents from non-arch code X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: <20230612151545.3317766-1-ryan.roberts@arm.com> Date: Tue, 13 Jun 2023 10:16:26 +0800 Cc: Andrew Morton , SeongJae Park , "Matthew Wilcox (Oracle)" , "Kirill A. Shutemov" , Mike Rapoport , Yu Zhao , Jason Gunthorpe , David Airlie , Daniel Vetter , Dimitri Sivanich , Alex Williamson , Oleksandr Tyshchenko , Alexander Viro , Christian Brauner , Mike Kravetz , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter , =?utf-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Naoya Horiguchi , Miaohe Lin , Pasha Tatashin , Uladzislau Rezki , Christoph Hellwig , Lorenzo Stoakes , linux-kernel@vger.kernel.org, Linux Memory Management List , damon@lists.linux.dev Content-Transfer-Encoding: quoted-printable Message-Id: <3ECE40AA-536E-4A2C-82BA-FE74AA6FB689@linux.dev> References: <20230612151545.3317766-1-ryan.roberts@arm.com> To: Ryan Roberts X-Migadu-Flow: FLOW_OUT > On Jun 12, 2023, at 23:15, Ryan Roberts wrote: >=20 > Hi All, >=20 > (Including wider audience this time since changes touch a fair few = subsystems) >=20 > This is the second half of v3 of a series to improve the encapsulation = of pte > entries by disallowing non-arch code from directly dereferencing pte_t = pointers. > Based on earlier feedback, I split the series in 2; the first part, = fixes for > existing bugs, was already posted at [3] and merged into mm-stable. = This second > part contains the conversion from direct dereferences to instead use > ptep_get()/ptep_get_lockless(). >=20 > See the v1 cover letter at [1] for rationale for this work. >=20 > Based on feedback at v2, I've removed the new ptep_deref() helper I = originally > added, and am now using the existing ptep_get() and = ptep_get_lockless() helpers. When I first saw the name of ptep_get()/ptep_get_lockless(), I thought the pte seems like to be protected by the refcount mechanism (Why I have this though? Because Qi Zheng has proposed a approach to free pte page = tables by using the refcount mechanism [1]). And your proposed name of = ptep_deref() is intuitive for me, so I have another thought, should we rename = ptep_get() to ptep_deref()? Just a thought from me, I'd like to hear if others = object. Thanks. [1] = https://lore.kernel.org/lkml/20211110105428.32458-7-zhengqi.arch@bytedance= .com/=