From: "cron2 (Code Review)" Date: Wed, 17 Dec 2025 08:25:55 +0000 References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net Message-ID: <3a06bff0c2c0a8c5f15cd9e9c866a4088ceb69c3-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="ggqWAAzUods="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[release/2.6]: Add check for bind-dev in DCO options List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: openvpn-devel --ggqWAAzUods= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1447?usp=3Demail to review the following change. Change subject: Add check for bind-dev in DCO options ...................................................................... Add check for bind-dev in DCO options Change-Id: I5d5fca3f5f7a724b4f9ec98832d3a785459f36a5 --- M src/openvpn/dco.c 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/47/1447/1 diff --git a/src/openvpn/dco.c b/src/openvpn/dco.c index e41d59f..06d5920 100644 --- a/src/openvpn/dco.c +++ b/src/openvpn/dco.c @@ -317,6 +317,12 @@ } } + if (o->bind_dev) + { + msg(msglevel, "Note: bind-dev not supported with DCO, disabling da= ta channel offload"); + return false; + } + #if defined(_WIN32) if (o->mode =3D=3D MODE_SERVER) { -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1447?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: newchange Gerrit-Project: openvpn Gerrit-Branch: release/2.6 Gerrit-Change-Id: I5d5fca3f5f7a724b4f9ec98832d3a785459f36a5 Gerrit-Change-Number: 1447 Gerrit-PatchSet: 1 Gerrit-Owner: cron2 Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos --ggqWAAzUods= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is cur= rently required from: plaisthos.

cron2 would like plaisthos to review this change.

V= iew Change

Add check for bind-dev in DCO options
Change-Id: I5d5fca3f5f7a724b4f9ec98832d3a785459f36a5
---
M src/open= vpn/dco.c
1 file changed, 6 insertions(+), 0 deletions(-)

<= pre class=3D"blocks" style=3D"font-family: monospace,monospace; white-space= : pre-wrap;">git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/4= 7/1447/1
diff --git a/src/openvpn/dco.c b/src/openvpn/dco.c<=
br>index e41d59f..06d5920 100644
--- a/src/openvpn/dc= o.c
+++ b/src/openvpn/dco.c
@@ -317,6 +317,= 12 @@
}
}

+ if (o->bind_de= v)
+ {
<= span style=3D"color: hsl(120, 100%, 40%);">+ msg(msglevel, "Not= e: bind-dev not supported with DCO, disabling data channel offload");<= /span>
+ return false= ;
+ }
+

#if defined(_W= IN32)
if (o->mode =3D=3D MODE_SERVER)
{

To view, visit change 1447. To un= subscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: release/2.6
Gerrit-Change-Id: I5d5fca3f5f7a724b4f9ec98832d= 3a785459f36a5
Gerrit-Change-Number: 1447
Gerrit-PatchSet: 1
Gerrit-Owner: cron2 <gert@...1296...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
= --ggqWAAzUods=--