From: "mattock (Code Review)" Date: Thu, 9 Jan 2025 12:13:08 +0000 In-Reply-To: References: Reply-To: samuli@...515..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <3a506977cf55747526eb78301a41904d0b46513c-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="xUnS8yuXZ8M="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: Add lwip support to t_server_null List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: flichtenheld , plaisthos , openvpn-devel --xUnS8yuXZ8M= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, plaisthos. mattock has posted comments on this change. ( http://gerrit.openvpn.net/c/o= penvpn/+/811?usp=3Demail ) Change subject: Add lwip support to t_server_null ...................................................................... Patch Set 7: (5 comments) Patchset: PS7: I believe all the issues have now been fixed. File doc/t_server_null.rst: http://gerrit.openvpn.net/c/openvpn/+/811/comment/2d1c9ea4_216d5c5f : PS4, Line 129: Note that all ovpnlwip test names need to include a "_lwip" = suffix: without if > "without it" Fixed. File tests/lwip_client_up.sh: http://gerrit.openvpn.net/c/openvpn/+/811/comment/d09bbc1c_eac12c14 : PS4, Line 4: if ! grep "$ifconfig_local" ./$test_name.ips; then > Should use grep -q Fixed. File tests/t_server_null_client.sh: http://gerrit.openvpn.net/c/openvpn/+/811/comment/05185aa6_2c43584f : PS4, Line 61: echo "ERROR: pinging one or more openvpnlwip clie= nt IP addresses failed!" > This should use FAIL since it actually causes the test to fail. [=E2=80= =A6] Fixed. File tests/t_server_null_default.rc: http://gerrit.openvpn.net/c/openvpn/+/811/comment/ab8689e8_99bd56fe : PS4, Line 22: LWIPOVPN_PATH=3D"${LWIPOVPN_PATH:-lwipovpn}" > This is extremely misleading. This seems to indicate that you can overrid= e `LWIPOVPN_PATH`. [=E2=80=A6] I actually mentioned this in my comment to patchset 2, quoted below in full: --- It is now possible to do LWIPOVPN_PATH=3D/some/path/to/lwipovpn make check To use a custom location. It would have been nicer to be able to override it it t_server_null.rc, but= that file gets loaded too late for it to have any practical effect on the = actual client command-lines. --- This override mechanism is already used in openvpn-buildbot, see https://github.com/OpenVPN/openvpn-buildbot/blob/master/buildbot-host/build= master/master.cfg#L506 I've added a comment to the file that explains how this works. The details are already lost in the mists of time, but I remember not seein= g an obvious alternative solution to this that would not have involved a fa= ir amount of refactoring. Hence I opted for this simple solution which I ag= ree was misleading, especially when not documented. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/811?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ie63f302402f469c3aa48ac146ca6b8c029f0d250 Gerrit-Change-Number: 811 Gerrit-PatchSet: 7 Gerrit-Owner: mattock Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-Comment-Date: Thu, 09 Jan 2025 12:13:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld Gerrit-MessageType: comment --xUnS8yuXZ8M= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld, plaisthos.

View C= hange

5 comments:

  • File te= sts/t_server_null_client.sh:

    • Patch Set #4, Line 61: echo "ERROR: pinging one or more openvpnlwip cli= ent IP addresses failed!"

      This should use FAIL s= ince it actually causes the test to fail. [=E2=80=A6]

      Fixed.

    <= /li>
  • File tests/t_server_null_defaul= t.rc:

    • Patch Set #4,= Line 22: LWIPOVPN_PATH= =3D"${LWIPOVPN_PATH:-lwipovpn}"

      This is ext= remely misleading. This seems to indicate that you can override `LWIPOVPN_P= ATH`. [=E2=80=A6]

      I actually mentioned this in my comment to patchset 2, qu= oted below in full:

      ---

      It= is now possible to do

      LWIPOVPN_PATH=3D/some/path/to/lwipovpn make check

      To use a custom location.

      It would have b= een nicer to be able to override it it t_server_null.rc, but that file gets= loaded too late for it to have any practical effect on the actual client c= ommand-lines.

      ---

      This ove= rride mechanism is already used in openvpn-buildbot, see

      https://github.com/OpenVPN/open= vpn-buildbot/blob/master/buildbot-host/buildmaster/master.cfg#L506

      I've added a comm= ent to the file that explains how this works.

      The details are already lost in the mists = of time, but I remember not seeing an obvious alternative solution to this = that would not have involved a fair amount of refactoring. Hence I opted fo= r this simple solution which I agree was misleading, especially when not do= cumented.

  • To view, visit change 811. To unsubscribe, o= r for help writing mail filters, visit settings.

    =
    Gerrit-Project: openvpn
    Gerrit-Branch: master
    Gerrit-Change-Id: Ie63f302402f469c3aa48ac146ca= 6b8c029f0d250
    Gerrit-Change-Number: 811
    Gerrit-PatchSet: 7
    Gerrit-Owner: mattock <samuli@...515...>=
    Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
    Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
    Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
    Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
    Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
    Gerrit-Comment-Date: Thu, 09 Jan 2025 12:13:08= +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: flichtenheld <frank@...1186...= .2641...>
    Gerrit-MessageType: comment
    --xUnS8yuXZ8M=--