From: "flichtenheld (Code Review)" Date: Wed, 28 Feb 2024 14:37:38 +0000 In-Reply-To: References: Reply-To: frank@...2641..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net Message-ID: <3b48d1257f9c543e88a981b6cbec2d3490b49235-EmailReplacePatchSet-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="rn5MJcRDngE="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: forked-test-driver: Show test output always List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: openvpn-devel --rn5MJcRDngE= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld. Hello plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/479?usp=3Demail to look at the new patch set (#10). The change is no longer submittable: checks~ChecksSubmitRule is unsatisfied= now. Change subject: forked-test-driver: Show test output always ...................................................................... forked-test-driver: Show test output always We want to see the progress, at least for slow tests like t_client.sh. Change-Id: I11e0091482d9acee89ca018374cb8d96d22f8514 Signed-off-by: Frank Lichtenheld --- M forked-test-driver 1 file changed, 7 insertions(+), 2 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/79/479/10 diff --git a/forked-test-driver b/forked-test-driver index be73b80..6971dfb 100755 --- a/forked-test-driver +++ b/forked-test-driver @@ -108,9 +108,14 @@ # Test script is run here. We create the file first, then append to it, # to ameliorate tests themselves also writing to the log file. Our tests # don't, but others can (automake bug#35762). +# OVPN changes: +# - add tee to see output of tests +# - needs portable pipefail mechanism +estatusfile=3D"${trs_file}.exit" : >"$log_file" -"$@" >>"$log_file" 2>&1 -estatus=3D$? +("$@" 2>&1; estatus=3D$?; echo $estatus >"$estatusfile") | tee -a "$log_fi= le" +estatus=3D$(cat "$estatusfile") +rm -f "$estatusfile" if test $enable_hard_errors =3D no && test $estatus -eq 99; then tweaked_estatus=3D1 -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/479?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I11e0091482d9acee89ca018374cb8d96d22f8514 Gerrit-Change-Number: 479 Gerrit-PatchSet: 10 Gerrit-Owner: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: flichtenheld Gerrit-MessageType: newpatchset --rn5MJcRDngE= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld.

flichtenheld uploaded patch set #10 to this change.

=

View C= hange

The change is no longer submittable: checks~ChecksSubmitRul= e is unsatisfied now.

forked-test-driver: Show test output always

We= want to see the progress, at least for slow tests
like t_client.sh.
=
Change-Id: I11e0091482d9acee89ca018374cb8d96d22f8514
Signed-off-by: = Frank Lichtenheld <frank@...2641...>
---
M forked-test-driver1 file changed, 7 insertions(+), 2 deletions(-)

git pull ssh:=
//gerrit.openvpn.net:29418/openvpn refs/changes/79/479/10
diff --=
git a/forked-test-driver b/forked-test-driver
index be73b80= ..6971dfb 100755
--- a/forked-test-driver
+= ++ b/forked-test-driver
@@ -108,9 +108,14 @@
# Test script is run here. We create the file first, then append to it,<= /span>
# to ameliorate tests themselves also writing to the log f= ile. Our tests
# don't, but others can (automake bug#3= 5762).
+# OVPN change= s:
+# - add tee to s= ee output of tests
+#= - needs portable pipefail mechanism
+estatusfile=3D"${trs_file}.exit"
: >"$log_file"
-"$@" >>"$log_file" 2>&1-estatus=3D$?
+("$@" 2>&1; estatus= =3D$?; echo $estatus >"$estatusfile") | tee -a "$log_file= "
+estatus=3D$(c= at "$estatusfile")
+rm -f "$estatusfile"

= if test $enable_hard_errors =3D no && test $estatus -eq 99; then
tweaked_estatus=3D1

To= view, visit change 479. To unsubscribe, or for help writing mail filters, visit= settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I11e0091482d9acee89ca018374c= b8d96d22f8514
Gerrit-Change-Number: 479
Gerrit-PatchSet: 10
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-MessageType: newpatchset
--rn5MJcRDngE=--