From: "cron2 (Code Review)" Date: Fri, 17 Jan 2025 11:29:12 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., marco@...2726..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <3b51c36035fe16c2a1ff980743b1a340ee8679f3-EmailReplacePatchSet-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="uPeo/f/p2OY="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: IPv6 MADDR LOG: Wrap IPv6 addresses in square brackets and print port... List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: mrbff , plaisthos , flichtenheld Cc: openvpn-devel --uPeo/f/p2OY= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable cron2 has uploaded a new patch set (#3) to the change originally created by= mrbff. ( http://gerrit.openvpn.net/c/openvpn/+/870?usp=3Demail ) The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: IPv6 MADDR LOG: Wrap IPv6 addresses in square brackets and = print port when the port is specified ...................................................................... IPv6 MADDR LOG: Wrap IPv6 addresses in square brackets and print port when = the port is specified Updated the mroute_addr_print_ex() function to wrap IPv6 addresses in squ= are brackets and printing the port when the port is specified, e.g., [2001:db= 8::1]:8080 . When the port is not specified the IPv6 address formatting remain the sam= e, e.g., 2001:db8::1 . Change-Id: Ia58cff107d14e29e51df0a988e8337cbb70ebfbb Signed-off-by: Marco Baffo Acked-by: Gert Doering Message-Id: <20250117110422.921-1-gert@...1296...> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg30= 480.html Signed-off-by: Gert Doering --- M src/openvpn/mroute.c 1 file changed, 8 insertions(+), 7 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/70/870/3 diff --git a/src/openvpn/mroute.c b/src/openvpn/mroute.c index f4539dc..80e18b7 100644 --- a/src/openvpn/mroute.c +++ b/src/openvpn/mroute.c @@ -430,18 +430,19 @@ { buf_printf(&out, "%s", print_in_addr_t(maddr.v4mappedv= 6.addr, IA_NET_ORDER, g= c)); - /* we only print port numbers for v4mapped v6 as of - * today, because "v6addr:port" is too ambiguous - */ - if (maddr.type & MR_WITH_PORT) - { - buf_printf(&out, ":%d", ntohs(maddr.v6.port)); - } + } + else if (maddr.type & MR_WITH_PORT) + { + buf_printf(&out, "[%s]", print_in6_addr(maddr.v6.addr,= 0, gc)); } else { buf_printf(&out, "%s", print_in6_addr(maddr.v6.addr, 0= , gc)); } + if (maddr.type & MR_WITH_PORT) + { + buf_printf(&out, ":%d", ntohs(maddr.v6.port)); + } if (maddr.type & MR_WITH_NETBITS) { buf_printf(&out, "/%d", maddr.netbits); -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/870?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ia58cff107d14e29e51df0a988e8337cbb70ebfbb Gerrit-Change-Number: 870 Gerrit-PatchSet: 3 Gerrit-Owner: mrbff Gerrit-Reviewer: cron2 Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-MessageType: newpatchset --uPeo/f/p2OY= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

cron2 uploaded patch set #3 to the change originally cr= eated by mrbff.

View Change

The following approvals got outdated and= were removed: Code-Review+2 by cron2

IPv6 MADDR LOG: Wrap IPv6 addresses in square bracke=
ts and print port when the port is specified

Updated the mroute_ad= dr_print_ex() function to wrap IPv6 addresses in square
brackets and p= rinting the port when the port is specified, e.g., [2001:db8::1]:8080 .
= When the port is not specified the IPv6 address formatting remain the sam= e, e.g., 2001:db8::1 .

Change-Id: Ia58cff107d14e29e51df0a988e8337cbb= 70ebfbb
Signed-off-by: Marco Baffo <marco@...2726...>
Acked-by:= Gert Doering <gert@...1296...>
Message-Id: <20250117110422.921= -1-gert@...1296...>
URL: https://www.mail-archive.com/openvpn-devel@...465...= ists.sourceforge.net/msg30480.html
Signed-off-by: Gert Doering <gert@= ...1296...>
---
M src/openvpn/mroute.c
1 file changed, 8 insert= ions(+), 7 deletions(-)

git pull ssh://gerrit.openvpn.net:29418/o=
penvpn refs/changes/70/870/3
diff --git a/src/openvpn/mroute.c b/sr=
c/openvpn/mroute.c
index f4539dc..80e18b7 100644
= --- a/src/openvpn/mroute.c
+++ b/src/openvpn/mroute.c=
@@ -430,18 +430,19 @@
{
buf_printf(&out, "%s", pr= int_in_addr_t(maddr.v4mappedv6.addr,
= IA_NET_ORDER, gc));
- /* we only print po= rt numbers for v4mapped v6 as of
- * today, because "v6addr:port" is= too ambiguous
- = */
- = if (maddr.type & MR_WITH_PORT)
- {
- buf_printf(&out, &q= uot;:%d", ntohs(maddr.v6.port));
- }
+ }
+ else if (maddr.type & MR_WITH_PORT)
+ {
+ buf_p= rintf(&out, "[%s]", print_in6_addr(maddr.v6.addr, 0, gc));
}
else
{
buf_pri= ntf(&out, "%s", print_in6_addr(maddr.v6.addr, 0, gc));=
}
+ if (maddr.type & MR_WITH_PORT)
+ {

+ buf_printf(&o= ut, ":%d", ntohs(maddr.v6.port));
+ }
= if (maddr.type & MR_WITH_NETBITS)
{
buf_printf(&out, "/%d", ma= ddr.netbits);

To view, visit change 870. To = unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ia58cff107d14e29e51df0a988e8= 337cbb70ebfbb
Gerrit-Change-Number: 870
Gerrit-PatchSet: 3
Gerrit-Owner: mrbff <marco@...2726...> <= /div>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-MessageType: newpatchset
--uPeo/f/p2OY=--