From: "flichtenheld (Code Review)" Date: Mon, 2 Jun 2025 10:25:16 +0000 In-Reply-To: References: Reply-To: frank@...2641..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, gert@...1296... Message-ID: <3b54dabe7d41665a32c5d7e752f8c4b3f0f51a60-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="qBPKJ1E/52Q="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: Define a .clang-format file for the project List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: plaisthos , openvpn-devel --qBPKJ1E/52Q= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: cron2, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.ne= t/c/openvpn/+/790?usp=3Demail ) Change subject: Define a .clang-format file for the project ...................................................................... Patch Set 15: (1 comment) File .pre-commit-config.yaml: http://gerrit.openvpn.net/c/openvpn/+/790/comment/258aae77_531d3e83 : PS15, Line 9: > I don't really like this - call me oldfashioned, but requiring python to = install something magic fro [=E2=80=A6] This is "take it or leave it". I really am not willing to maintain some sor= t-of-working shell code instead of a 3rd-party solution that comes with man= y additional features. Most importantly using the exact version of clang-fo= rmat I specify. I maintain a dozen of repositories, I really will not maint= ain a hook in every one of those. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/790?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I40f6af10c5ee2f5aed4185d783fc622a2e3c19ff Gerrit-Change-Number: 790 Gerrit-PatchSet: 15 Gerrit-Owner: flichtenheld Gerrit-Reviewer: cron2 Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: cron2 Gerrit-Comment-Date: Mon, 02 Jun 2025 10:25:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: cron2 Gerrit-MessageType: comment --qBPKJ1E/52Q= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: cron2, plaisthos.

View C= hange

1 comment:

To view, visit change 790. To unsubscribe, or= for help writing mail filters, visit settings.

<= /div>
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I40f6af10c5ee2f5aed4185d783f= c622a2e3c19ff
Gerrit-Change-Number: 790
Gerrit-PatchSet: 15
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: cron2 <gert@...1296...>= ;
Gerrit-Comment-Date: Mon, 02 Jun 2025 10:25:16= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: cron2 <gert@...1296...= >
Gerrit-MessageType: comment
--qBPKJ1E/52Q=--