Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C64F6C43465 for ; Mon, 21 Sep 2020 14:22:50 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6F1FE2193E for ; Mon, 21 Sep 2020 14:22:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b="YZHUP7QB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6F1FE2193E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kKMi6-0007V1-M4; Mon, 21 Sep 2020 14:22:30 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kKMi5-0007Uw-7Q for xen-devel@lists.xenproject.org; Mon, 21 Sep 2020 14:22:29 +0000 X-Inumbo-ID: 3aa210a6-1798-4a7d-a368-7629164ae617 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 3aa210a6-1798-4a7d-a368-7629164ae617; Mon, 21 Sep 2020 14:22:28 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1600698147; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YW8ic/c5GqniT+8NGF22mGMNx6z/3bq1S+5yqEavRL8=; b=YZHUP7QBaaV0UTYr1gVGZkvhhV2CZAcRmvQAroK2PO7gEcXD2xFl53u7XYclNtVwPnibwq otOsmV2U4d8Idxsx5FscQsgovJBNSWbEgdPEg07aSSUHXPRZbX3sbmkLnbEtC9XVLzYnw2 qy8TaPtvoKU7bK/o0FAdqzvR5x2XOXo= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id A2816B251; Mon, 21 Sep 2020 14:23:03 +0000 (UTC) Subject: Re: [PATCH] x86/mm: do not mark IO regions as Xen heap To: Roger Pau Monne Cc: xen-devel@lists.xenproject.org, Andrew Cooper , Wei Liu , Paul Durrant References: <20200910133514.82155-1-roger.pau@citrix.com> From: Jan Beulich Message-ID: <3b61c04e-b2ef-a9c6-c3c4-e1d8624e7115@suse.com> Date: Mon, 21 Sep 2020 16:22:26 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20200910133514.82155-1-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 10.09.2020 15:35, Roger Pau Monne wrote: > arch_init_memory will treat all the gaps on the physical memory map > between RAM regions as MMIO and use share_xen_page_with_guest in order > to assign them to dom_io. This has the side effect of setting the Xen > heap flag on such pages, and thus is_special_page would then return > true which is an issue in epte_get_entry_emt because such pages will > be forced to use write-back cache attributes. > > Fix this by introducing a new helper to assign the MMIO regions to > dom_io without setting the Xen heap flag on the pages, so that > is_special_page will return false and the pages won't be forced to use > write-back cache attributes. > > Fixes: 81fd0d3ca4b2cd ('x86/hvm: simplify 'mmio_direct' check in epte_get_entry_emt()') Is this really the correct commit? I had this queued for backport, and ended up discarding it from the queue based on this tag, just to then noticing that I remembered correctly that I did backport ca24b2ffdbd9 ("x86/hvm: set 'ipat' in EPT for special pages") to the stable trees already. Isn't it _this_ commit which the change here fixes? Jan