From: Tvrtko Ursulin Subject: Re: [PATCH] drm/i915/sw_fence: Replace private use of wq->flags with bit zero in wq->private Date: Thu, 3 Nov 2016 08:33:58 +0000 Message-ID: <3b81249c-53c5-3c06-badd-3b65112e3982@linux.intel.com> References: <1478106028-27602-1-git-send-email-tvrtko.ursulin@linux.intel.com> <20161102173416.GB22192@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id B3F166E08E for ; Thu, 3 Nov 2016 08:34:01 +0000 (UTC) In-Reply-To: <20161102173416.GB22192@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , Tvrtko Ursulin , Intel-gfx@lists.freedesktop.org, Tvrtko Ursulin List-Id: intel-gfx@lists.freedesktop.org Ck9uIDAyLzExLzIwMTYgMTc6MzQsIENocmlzIFdpbHNvbiB3cm90ZToKPiBPbiBXZWQsIE5vdiAw MiwgMjAxNiBhdCAwNTowMDoyOFBNICswMDAwLCBUdnJ0a28gVXJzdWxpbiB3cm90ZToKPj4gRnJv bTogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4KPj4KPj4gVXNlIG9m IGFuIHVuLWFsbG9jYXRlZCBiaXQgaW4gZmxhZ3MgaXMgbWFraW5nIG1lIG5lcnZvdXMgc28gSQo+ PiB0aG91Z2h0IHRvIHVzZSB0aGUgYml0IHplcm8gb2YgdGhlIHByaXZhdGUgcG9pbnRlciBpbnN0 ZWFkLgo+Pgo+PiBUaGF0IHNob3VsZCBiZSBzYWZlciBhZ2FpbnN0IHRoZSBjb3JlIGtlcm5lbCBj aGFuZ2VzIGFuZCBzYWZlCj4+IHNpbmNlIEkgY2FuJ3QgaW1hZ2luZSB3ZSBjYW4gZ2V0IGEgZmVu Y2UgYXQgdGhlIG9kZCBhZGRyZXNzLgo+Cj4gSSdtIG5vdCBzcXVlYW1pc2ggYWJvdXQgdXNpbmcg ZmxhZ3MgOykKPgo+PiBTaWduZWQtb2ZmLWJ5OiBUdnJ0a28gVXJzdWxpbiA8dHZydGtvLnVyc3Vs aW5AaW50ZWwuY29tPgo+PiBDYzogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28u dWs+Cj4+IC0tLQo+PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9zd19mZW5jZS5jIHwgMjQg KysrKysrKysrKysrKysrKy0tLS0tLS0tCj4+ICAxIGZpbGUgY2hhbmdlZCwgMTYgaW5zZXJ0aW9u cygrKSwgOCBkZWxldGlvbnMoLSkKPj4KPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2k5MTVfc3dfZmVuY2UuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfc3dfZmVuY2Uu Ywo+PiBpbmRleCA5NWYyZjEyZTA5MTcuLmNkNGQ2YjkxNTg0OCAxMDA2NDQKPj4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvaTkxNV9zd19mZW5jZS5jCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2k5MTVfc3dfZmVuY2UuYwo+PiBAQCAtMTMsNyArMTMsOCBAQAo+Pgo+PiAgI2luY2x1 ZGUgImk5MTVfc3dfZmVuY2UuaCIKPj4KPj4gLSNkZWZpbmUgSTkxNV9TV19GRU5DRV9GTEFHX0FM TE9DIEJJVCgzKSAvKiBhZnRlciBXUV9GTEFHXyogZm9yIHNhZmV0eSAqLwo+PiArI2RlZmluZSBJ OTE1X1NXX0ZFTkNFX0ZMQUdfQUxMT0MJKDEpCj4KPiBCSVQoMCkgYmVmb3JlIEpvb25hcyBub3Rp Y2VzLgo+Cj4+ICsjZGVmaW5lIEk5MTVfU1dfRkVOQ0VfUFJJVkFURV9NQVNLCX4oSTkxNV9TV19G RU5DRV9GTEFHX0FMTE9DKQo+Pgo+PiAgc3RhdGljIERFRklORV9TUElOTE9DSyhpOTE1X3N3X2Zl bmNlX2xvY2spOwo+Pgo+PiBAQCAtMTMyLDEyICsxMzMsMTcgQEAgdm9pZCBpOTE1X3N3X2ZlbmNl X2NvbW1pdChzdHJ1Y3QgaTkxNV9zd19mZW5jZSAqZmVuY2UpCj4+ICAJaTkxNV9zd19mZW5jZV9w dXQoZmVuY2UpOwo+PiAgfQo+Pgo+PiArI2RlZmluZSB3cV90b19pOTE1X3N3X2ZlbmNlKHdxKSAo c3RydWN0IGk5MTVfc3dfZmVuY2UgKikgXAo+PiArCSgodW5zaWduZWQgbG9uZykod3EpLT5wcml2 YXRlICYgSTkxNV9TV19GRU5DRV9QUklWQVRFX01BU0spCj4KPiBJIHF1aXRlIGxpa2U6Cj4KPiAj ZGVmaW5lIHdxX3RvX2k5MTVfc3dfZmVuY2Uod3EpICh7Cj4gCXVuc2lnbmVkIGxvbmcgX192ID0g KHVuc2lnbmVkIGxvbmcpKHdxKS0+cHJpdmF0ZTsKPiAJKHN0cnVjdCBpOTE1X3N3X2ZlbmNlICop KF9fdiAmIEk5MTVfU1dfRkVOQ0VfUFJJVkFURV9NQVNLKTsKPiApfQo+Cj4gb3IgYmV0dGVyCj4K PiBzdGF0aWMgaW5saW5lIHN0cnVjdCBpOTE1X3N3X2ZlbmNlICoKPiB3cV90b19pOTE1X3N3X2Zl bmNlKGNvbnN0IHdhaXRfcXVldWVfdCAqd3EpCj4gewo+IAl1bnNpZ25lZCBsb25nIF9fdiA9ICh1 bnNpZ25lZCBsb25nKXdxLT5wcml2YXRlOwo+IAlyZXR1cm4gKHN0cnVjdCBpOTE1X3N3X2ZlbmNl ICopKF9fdiAmIEk5MTVfU1dfRkVOQ0VfUFJJVkFURV9NQVNLKTsKPiB9Cj4KPiBzdGF0aWMgaW5s aW5lIGJvb2wKPiB3cV9pc19hbGxvYyhjb25zdCB3YWl0X3F1ZXVlX3QgKndxKQo+IHsKPiAJdW5z aWduZWQgbG9uZyBfX3YgPSAodW5zaWduZWQgbG9uZyl3cS0+cHJpdmF0ZTsKPiAJcmV0dXJuIF9f diAmIEk5MTVfU1dfRkVOQ0VfRkxBR19BTExPQzsKPiB9Cj4KPj4gKwo+PiAgc3RhdGljIGludCBp OTE1X3N3X2ZlbmNlX3dha2Uod2FpdF9xdWV1ZV90ICp3cSwgdW5zaWduZWQgbW9kZSwgaW50IGZs YWdzLCB2b2lkICprZXkpCj4+ICB7Cj4+ICsJc3RydWN0IGk5MTVfc3dfZmVuY2UgKmZlbmNlID0g d3FfdG9faTkxNV9zd19mZW5jZSh3cSk7Cj4+ICsKPj4gIAlsaXN0X2RlbCgmd3EtPnRhc2tfbGlz dCk7Cj4+IC0JX19pOTE1X3N3X2ZlbmNlX2NvbXBsZXRlKHdxLT5wcml2YXRlLCBrZXkpOwo+PiAt CWk5MTVfc3dfZmVuY2VfcHV0KHdxLT5wcml2YXRlKTsKPj4gLQlpZiAod3EtPmZsYWdzICYgSTkx NV9TV19GRU5DRV9GTEFHX0FMTE9DKQo+PiArCV9faTkxNV9zd19mZW5jZV9jb21wbGV0ZShmZW5j ZSwga2V5KTsKPj4gKwlpOTE1X3N3X2ZlbmNlX3B1dChmZW5jZSk7Cj4+ICsJaWYgKCh1bnNpZ25l ZCBsb25nKXdxLT5wcml2YXRlICYgSTkxNV9TV19GRU5DRV9GTEFHX0FMTE9DKQo+PiAgCQlrZnJl ZSh3cSk7Cj4+ICAJcmV0dXJuIDA7Cj4+ICB9Cj4+IEBAIC0xNTcsNyArMTYzLDggQEAgc3RhdGlj IGJvb2wgX19pOTE1X3N3X2ZlbmNlX2NoZWNrX2lmX2FmdGVyKHN0cnVjdCBpOTE1X3N3X2ZlbmNl ICpmZW5jZSwKPj4gIAkJaWYgKHdxLT5mdW5jICE9IGk5MTVfc3dfZmVuY2Vfd2FrZSkKPj4gIAkJ CWNvbnRpbnVlOwo+Pgo+PiAtCQlpZiAoX19pOTE1X3N3X2ZlbmNlX2NoZWNrX2lmX2FmdGVyKHdx LT5wcml2YXRlLCBzaWduYWxlcikpCj4+ICsJCWlmIChfX2k5MTVfc3dfZmVuY2VfY2hlY2tfaWZf YWZ0ZXIod3FfdG9faTkxNV9zd19mZW5jZSh3cSksCj4+ICsJCQkJCQkgICBzaWduYWxlcikpCj4+ ICAJCQlyZXR1cm4gdHJ1ZTsKPj4gIAl9Cj4+Cj4+IEBAIC0xNzUsNyArMTgyLDcgQEAgc3RhdGlj IHZvaWQgX19pOTE1X3N3X2ZlbmNlX2NsZWFyX2NoZWNrZWRfYml0KHN0cnVjdCBpOTE1X3N3X2Zl bmNlICpmZW5jZSkKPj4gIAkJaWYgKHdxLT5mdW5jICE9IGk5MTVfc3dfZmVuY2Vfd2FrZSkKPj4g IAkJCWNvbnRpbnVlOwo+Pgo+PiAtCQlfX2k5MTVfc3dfZmVuY2VfY2xlYXJfY2hlY2tlZF9iaXQo d3EtPnByaXZhdGUpOwo+PiArCQlfX2k5MTVfc3dfZmVuY2VfY2xlYXJfY2hlY2tlZF9iaXQod3Ff dG9faTkxNV9zd19mZW5jZSh3cSkpOwo+PiAgCX0KPj4gIH0KPj4KPj4gQEAgLTIyMSwxMyArMjI4 LDE0IEBAIHN0YXRpYyBpbnQgX19pOTE1X3N3X2ZlbmNlX2F3YWl0X3N3X2ZlbmNlKHN0cnVjdCBp OTE1X3N3X2ZlbmNlICpmZW5jZSwKPj4gIAkJCXJldHVybiAwOwo+PiAgCQl9Cj4+Cj4+IC0JCXBl bmRpbmcgfD0gSTkxNV9TV19GRU5DRV9GTEFHX0FMTE9DOwo+PiArCQlwZW5kaW5nID0gSTkxNV9T V19GRU5DRV9GTEFHX0FMTE9DOwo+PiAgCX0KPj4KPj4gIAlJTklUX0xJU1RfSEVBRCgmd3EtPnRh c2tfbGlzdCk7Cj4+IC0Jd3EtPmZsYWdzID0gcGVuZGluZzsKPgo+IFdlIHN0aWxsIG5lZWQgdG8g c2V0IHdxLT5mbGFncyB0byAwLgoKT29vcHMuCgo+IEl0IGxvb2tzIG9rLCBidXQgSSBqdXN0IGRv bid0IHNlZSB0aGUgcG9pbnQuIHdxLT5mbGFncyBpcyBwcml2YXRlIHRvIHRoZQo+IHdxLT5mdW5j IGNhbGxiYWNrLgoKQSB2ZXJ5IHN1cGVyZmljaWFsIHNraW0gc2hvd3MgdGhhdCB3YWtlX3VwX2Nv bW1vbiBhdCBsZWFzdCBsb29rcyBhdCB0aGUgCmZsYWdzLiBTbyBJIHRob3VnaHQsIGFzIGxvbmcg YXMgd2FrZV91cF9zb21ldGhpbmcgZ2V0cyBjYWxsZWQgZm9ybSAKc29tZXdoZXJlIG9uIHRoZXNl IG9uZXMsIGl0IHdvdWxkIGJlIHNhZmVyIG5vdCB0byBwb3RlbnRpYWxseSBzaWxlbnRseSAKY29s bGlkZSB3aXRoIHNvbWUgY29yZSBmbGFnLgoKT3IgYXJlIHlvdSBzYXlpbmcgbm8gb25lIGV2ZXIg dG91Y2hlcyB0aGVtIG91dHNpZGUgaTkxNV9zd19mZW5jZS5jID8gSG0sIApJIGhhdmUgdG8gYWRt aXQgSSBoYXZlbid0IGZpZ3VyZWQgaXQgYWxsIG91dCB5ZXQgc28gSSBhbSBub3Qgc3VyZS4KClJl Z2FyZHMsCgpUdnJ0a28KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwt Z2Z4Cg==