From: "d12fk (Code Review)"
Date: Thu, 27 Mar 2025 01:28:37 +0000
In-Reply-To:
References:
Reply-To: heiko@...515..., arne-openvpn@...1227...,
openvpn-devel@lists.sourceforge.net, frank@...2641...,
lstipakov@...277...
Message-ID: <3ba80217c64952f64d332024121c9ed61f8d0d01-EmailReviewComments-HTML@...2715...>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="2ZgjVo4pdNA="; charset=UTF-8
Subject: [Openvpn-devel] [XL] Change in openvpn[master]: win: implement
--dns option support with NRPT
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Cc: stipa , flichtenheld , plaisthos , openvpn-devel
--2ZgjVo4pdNA=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: plaisthos, stipa.
d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/ope=
nvpn/+/837?usp=3Demail )
Change subject: win: implement --dns option support with NRPT
......................................................................
Patch Set 14:
(2 comments)
File src/openvpnserv/interactive.c:
http://gerrit.openvpn.net/c/openvpn/+/837/comment/d4afefe5_56002315 :
PS14, Line 2259: MsgToEventLog(M_SYSERR, TEXT("IsInterfaceConnected=
: "
> Sure. In my case it is probably Hyper-V virtual adapters. [=E2=80=A6]
The code fails now without error message if ConvertInterfaceGuidToLuid() fa=
ils. However, I wonder why it fails in the first place with those interface=
s. Basically that means that for any interface, where this conversion fails=
, there will be no exclude rules ever, and not even a diagnostic message to=
explain this. Leaves an uneasy feeling behind for me.
http://gerrit.openvpn.net/c/openvpn/+/837/comment/085ad92a_b096baa2 :
PS14, Line 2510: for (int i =3D 0; i < _countof(data); ++i)
> But there are: https://usercontent.irccloud-cdn.com/file/eJy2zlR6/image. =
[=E2=80=A6]
Done
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/837?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I576e74f3276362606e9cbd50bb5adbebaaf209cc
Gerrit-Change-Number: 837
Gerrit-PatchSet: 14
Gerrit-Owner: d12fk
Gerrit-Reviewer: flichtenheld
Gerrit-Reviewer: plaisthos
Gerrit-Reviewer: stipa
Gerrit-CC: openvpn-devel
Gerrit-Attention: plaisthos
Gerrit-Attention: stipa
Gerrit-Comment-Date: Thu, 27 Mar 2025 01:28:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: d12fk
Comment-In-Reply-To: stipa
Gerrit-MessageType: comment
--2ZgjVo4pdNA=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: plaisthos, stipa.
Sure. In my case it is probably Hyper-V virtual adapters. [=E2=80=A6]=
blockquote>
T=
he code fails now without error message if ConvertInterfaceGuidToLuid() fai=
ls. However, I wonder why it fails in the first place with those interfaces=
. Basically that means that for any interface, where this conversion fails,=
there will be no exclude rules ever, and not even a diagnostic message to =
explain this. Leaves an uneasy feeling behind for me.