From: "its_Giaan (Code Review)" Date: Mon, 19 Feb 2024 15:52:50 +0000 In-Reply-To: References: Reply-To: gianmarco@...2726..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <3bb97539d6fed783b7cf4e88f4fde742bf6b3f12-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="ZbjQECkcM7s="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: Route: add support for user defined routing table List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: flichtenheld , plaisthos , openvpn-devel --ZbjQECkcM7s= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, plaisthos. its_Giaan has posted comments on this change. ( http://gerrit.openvpn.net/c= /openvpn/+/524?usp=3Demail ) Change subject: Route: add support for user defined routing table ...................................................................... Patch Set 1: (2 comments) Patchset: PS1: I defined it but not set it to make sure that when retrieving the whitelist= of pullable options in pull_permission_mask() the pull were not allowed bu= t rather it printed an options error. File src/openvpn/options.h: http://gerrit.openvpn.net/c/openvpn/+/524/comment/81e9279e_e04fe802 : PS1, Line 745: #define OPT_P_ROUTE_TABLE (1<<31) > it is not clear to my why you need a separate permission entry here? Shou= ld maybe add a comment abou [=E2=80=A6] Acknowledged -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/524?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I3e4ebef484d2a04a383a65ede5617ee98bf218a7 Gerrit-Change-Number: 524 Gerrit-PatchSet: 1 Gerrit-Owner: its_Giaan Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-Comment-Date: Mon, 19 Feb 2024 15:52:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld Gerrit-MessageType: comment --ZbjQECkcM7s= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld, plaisthos.

View C= hange

2 comments:

    =
  • Patchset:

    • Patch Set #1:

      I defined it but not set it to make sure that whe= n retrieving the whitelist of pullable options in pull_permission_mask() th= e pull were not allowed but rather it printed an options error.

    • File src/openvpn/options.h:<= /p>

      • Patch Set #1, Line = 745: #define OPT_P_ROUT= E_TABLE (1<<31)

        it is not clear to my why y= ou need a separate permission entry here? Should maybe add a comment abou [= =E2=80=A6]

        Acknowledged

    To view, visit change 524. To = unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: openvpn
    Gerrit-Branch: master
    Gerrit-Change-Id: I3e4ebef484d2a04a383a65ede56= 17ee98bf218a7
    Gerrit-Change-Number: 524
    Gerrit-PatchSet: 1
    Gerrit-Owner: its_Giaan <gianmarco@...2786...= ..>
    Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
    Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
    Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
    Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
    Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
    Gerrit-Comment-Date: Mon, 19 Feb 2024 15:52:50= +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: flichtenheld <frank@...1186...= .2641...>
    Gerrit-MessageType: comment
    --ZbjQECkcM7s=--