Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 403E9C63777 for ; Mon, 30 Nov 2020 16:47:00 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 631D620691 for ; Mon, 30 Nov 2020 16:46:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="EzAipZe2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 631D620691 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:56438 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kjmKI-0001VS-5d for qemu-devel@archiver.kernel.org; Mon, 30 Nov 2020 11:46:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34888) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kjmHa-0008Fj-JE for qemu-devel@nongnu.org; Mon, 30 Nov 2020 11:44:12 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:35533) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kjmHU-0003hK-OR for qemu-devel@nongnu.org; Mon, 30 Nov 2020 11:44:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606754644; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ho1evf6y8Ipc5mATWKA4lqfnfmNacT7uPKu4MhQGmk0=; b=EzAipZe21XYDJ0vliOH+5YCPFwVA7sYd1R30Dt2h7gHF07p1VYfrbsF9xqhizdUGUgfvkO 1NrRTHS92kFbdvkb2he590unZCroeipAz56SbxT1VKgSJT5jJLmqr9BpWrBtHc8zh6DQgv CzG8leBlEPpokx0l236+y1NRWDnxmbM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-193-NC1-QW-EM9SHAgTNLTSqCQ-1; Mon, 30 Nov 2020 11:43:59 -0500 X-MC-Unique: NC1-QW-EM9SHAgTNLTSqCQ-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C4B6A80B727; Mon, 30 Nov 2020 16:43:57 +0000 (UTC) Received: from [10.3.113.230] (ovpn-113-230.phx2.redhat.com [10.3.113.230]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EC842189C4; Mon, 30 Nov 2020 16:43:56 +0000 (UTC) Subject: Re: [PATCH v2 4/6] migration: Add zstd support in multi-thread compression To: Zeyu Jin , quintela@redhat.com, dgilbert@redhat.com References: <20201127093215.2659-1-jinzeyu@huawei.com> From: Eric Blake Organization: Red Hat, Inc. Message-ID: <3bd561fd-0503-308a-e728-1509375663d2@redhat.com> Date: Mon, 30 Nov 2020 10:43:56 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20201127093215.2659-1-jinzeyu@huawei.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eblake@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=eblake@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.496, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ying Fang , qemu-devel@nongnu.org, zhang.zhanghailiang@huawei.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 11/27/20 3:32 AM, Zeyu Jin wrote: > This patch enables zstd option in multi-thread compression. > > Signed-off-by: Zeyu Jin > Signed-off-by: Ying Fang > --- > +++ b/qapi/migration.json > @@ -536,7 +536,7 @@ > # > ## > { 'enum': 'CompressMethod', > - 'data': [ 'zlib' ] } > + 'data': [ 'zlib', { 'name': 'zstd', 'if': 'defined(CONFIG_ZSTD)' } ] } Missing documentation of the new value, including a '(since 6.0)' marker. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org